{"thread":{"id":"53505","subject":"[PATCH] fsck: use ERROR_MULTI_PACK_INDEX","startedAt":"2020-05-19T19:48:50Z","lastAt":"2020-05-19T23:13:05Z","messageCount":2,"participants":["Derrick Stolee via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"398215","messageId":"pull.637.git.1589917725263.gitgitgadget@gmail.com","threadId":"53505","inReplyTo":null,"subject":"[PATCH] fsck: use ERROR_MULTI_PACK_INDEX","fromName":"Derrick Stolee via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-05-19T19:48:45Z","receivedAt":"2020-05-19T19:48:50Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"From: Derrick Stolee <dstolee@microsoft.com>\n\nThe multi-pack-index was added to the data verified by git-fsck in\nea5ae6c3 \"fsck: verify multi-pack-index\". This implementation was\nbased on the implementation for verifying the commit-graph, and a\ncopy-paste error kept the ERROR_COMMIT_GRAPH flag as the bit set\nwhen an error appears in the multi-pack-index.\n\nAdd a new flag, ERROR_MULTI_PACK_INDEX, and use that instead.\n\nSigned-off-by: Derrick Stolee <dstolee@microsoft.com>\n---\n    fsck: use ERROR_MULTI_PACK_INDEX\n    \n    Here is a clean-up that I forgot to send a while back.\n    \n    Thanks, -Stolee\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-637%2Fderrickstolee%2Ffsck-midx-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-637/derrickstolee/fsck-midx-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/637\n\n builtin/fsck.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/builtin/fsck.c b/builtin/fsck.c\nindex 8d13794b141..f02cbdb439b 100644\n--- a/builtin/fsck.c\n+++ b/builtin/fsck.c\n@@ -49,6 +49,7 @@ static int name_objects;\n #define ERROR_PACK 04\n #define ERROR_REFS 010\n #define ERROR_COMMIT_GRAPH 020\n+#define ERROR_MULTI_PACK_INDEX 040\n \n static const char *describe_object(const struct object_id *oid)\n {\n@@ -952,7 +953,7 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)\n \t\t\tmidx_argv[2] = \"--object-dir\";\n \t\t\tmidx_argv[3] = odb->path;\n \t\t\tif (run_command(&midx_verify))\n-\t\t\t\terrors_found |= ERROR_COMMIT_GRAPH;\n+\t\t\t\terrors_found |= ERROR_MULTI_PACK_INDEX;\n \t\t}\n \t}\n \n\nbase-commit: efcab5b7a3d2ce2ae4bf808b335938098b18d960\n-- \ngitgitgadget\n"},{"id":"398224","messageId":"xmqq1rnfzfgk.fsf@gitster.c.googlers.com","threadId":"53505","inReplyTo":"pull.637.git.1589917725263.gitgitgadget@gmail.com","subject":"Re: [PATCH] fsck: use ERROR_MULTI_PACK_INDEX","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-05-19T23:12:59Z","receivedAt":"2020-05-19T23:13:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Derrick Stolee via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Derrick Stolee <dstolee@microsoft.com>\n>\n> The multi-pack-index was added to the data verified by git-fsck in\n> ea5ae6c3 \"fsck: verify multi-pack-index\".\n\nThat's 66ec0390 (fsck: verify multi-pack-index, 2018-09-13) that\nfirst appeared in v2.20\n\n> This implementation was\n> based on the implementation for verifying the commit-graph, and a\n> copy-paste error kept the ERROR_COMMIT_GRAPH flag as the bit set\n> when an error appears in the multi-pack-index.\n>\n> Add a new flag, ERROR_MULTI_PACK_INDEX, and use that instead.\n\nThanks.  Will queue.\n"}]}