{"thread":{"id":"53498","subject":"[PATCH] git-bugreport.txt: adjust reference to strftime(3)","startedAt":"2020-05-18T19:37:46Z","lastAt":"2020-05-18T20:18:37Z","messageCount":3,"participants":["Todd Zullinger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"398136","messageId":"20200518193736.19320-1-tmz@pobox.com","threadId":"53498","inReplyTo":null,"subject":"[PATCH] git-bugreport.txt: adjust reference to strftime(3)","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2020-05-18T19:37:36Z","receivedAt":"2020-05-18T19:37:46Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"The strftime(3) man page is outside of the Git suite. Refererence it as\nwe do other external man pages and avoid creating a broken link when\ngenerating the HTML documentation.\n\nSigned-off-by: Todd Zullinger \n---\n\nHi Emily,\n\nWhile building 2.27.0-rc0, I noticed a broken link crept into the HTML\ndocs for git-bugreport. I believe this change matches most of our\nexisting references to external man pages.\n\nSome are enclosed in backticks, while most are not. My first instinct\nwas to use backticks. I avoided that to be consistent with the majority\nof other references. But I didn't look closely to see if newer\nadditions use backticks versus older changes do not.\n\nThe current \"link:strftime[3]\" tries to create a link to strftime named\n3, which doesn't seem like what we want. :)\n\nThanks,\nTodd\n\n Documentation/git-bugreport.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-bugreport.txt b/Documentation/git-bugreport.txt\nindex 7fe9aef34e..9edad66a63 100644\n--- a/Documentation/git-bugreport.txt\n+++ b/Documentation/git-bugreport.txt\n@@ -46,7 +46,7 @@ OPTIONS\n --suffix ::\n \tSpecify an alternate suffix for the bugreport name, to create a file\n \tnamed 'git-bugreport-'. This should take the form of a\n-\tlink:strftime[3] format string; the current local time will be used.\n+\tstrftime(3) format string; the current local time will be used.\n \n GIT\n ---\n-- \n2.26.1\n\n"},{"id":"398137","messageId":"xmqqa7252f5t.fsf@gitster.c.googlers.com","threadId":"53498","inReplyTo":"20200518193736.19320-1-tmz@pobox.com","subject":"Re: [PATCH] git-bugreport.txt: adjust reference to strftime(3)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-05-18T19:53:34Z","receivedAt":"2020-05-18T19:53:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger writes:\n\n> The strftime(3) man page is outside of the Git suite. Refererence it as\n> we do other external man pages and avoid creating a broken link when\n> generating the HTML documentation.\n>\n> Signed-off-by: Todd Zullinger \n> ---\n>\n> Hi Emily,\n>\n> While building 2.27.0-rc0, I noticed a broken link crept into the HTML\n> docs for git-bugreport. I believe this change matches most of our\n> existing references to external man pages.\n\nThanks. This was noticed elsewhere in a different thread but let's\ntake this as a patch independent from the other documentation topic.\n\n> diff --git a/Documentation/git-bugreport.txt b/Documentation/git-bugreport.txt\n> index 7fe9aef34e..9edad66a63 100644\n> --- a/Documentation/git-bugreport.txt\n> +++ b/Documentation/git-bugreport.txt\n> @@ -46,7 +46,7 @@ OPTIONS\n> --suffix ::\n> \tSpecify an alternate suffix for the bugreport name, to create a file\n> \tnamed 'git-bugreport-'. This should take the form of a\n> -\tlink:strftime[3] format string; the current local time will be used.\n> +\tstrftime(3) format string; the current local time will be used.\n> \n> GIT\n> ---\n"},{"id":"398142","messageId":"20200518201828.GW24220@pobox.com","threadId":"53498","inReplyTo":"xmqqa7252f5t.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] git-bugreport.txt: adjust reference to strftime(3)","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2020-05-18T20:18:28Z","receivedAt":"2020-05-18T20:18:37Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Junio C Hamano wrote:\n> Todd Zullinger writes:\n> \n>> The strftime(3) man page is outside of the Git suite. Refererence it as\n>> we do other external man pages and avoid creating a broken link when\n>> generating the HTML documentation.\n>>\n[...]\n> Thanks. This was noticed elsewhere in a different thread but let's\n> take this as a patch independent from the other documentation topic.\n\nAhh, I have gotten behind on my reading (and only just got\nto testing rc0¹). I'm glad this unintended redundancy\nworked out well, by chance.\n\nThank you.\n\n¹ FWIW, this was the only issue I found in building for the\n various architectures Fedora supports: aarch64, armv7hl,\n ppc64le, x86, x86_64, and, last -- but by far the most\n likely to turn up issues -- s390x.\n\n-- \nTodd\n"}]}