{"thread":{"id":"53495","subject":"[PATCH] ci/config: correct instruction for CI preferences","startedAt":"2020-05-18T14:52:46Z","lastAt":"2020-05-18T15:42:18Z","messageCount":2,"participants":["Đoàn Trần Công Danh","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"398074","messageId":"20200518145234.20424-1-congdanhqx@gmail.com","threadId":"53495","inReplyTo":null,"subject":"[PATCH] ci/config: correct instruction for CI preferences","fromName":"Đoàn Trần Công Danh","fromEmail":"congdanhqx@gmail.com","sentAt":"2020-05-18T14:52:34Z","receivedAt":"2020-05-18T14:52:46Z","isPatch":true,"sender":{"key":"congdanhqx@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42673067?v=4"},"body":"From e76eec3554 (ci: allow per-branch config for GitHub Actions,\n2020-05-07), we started to allow contributors decide which branch\nthey want to build with GitHub Actions\nby checking for a file named \"ci/config/allow-ref\".\n\nIn order to assist those contributors,\nwe provided a sample in \"ci/config/allow-refs.sample\",\nand instructed them to drop the \".sample\",\nthen commit that file to their repository.\n\nWe've misspelt the filename in that change.\nLet's fix the spelling.\n\nWhile we're at it, also instruct our contributors introduce that new\nfile to Git before commit, in case of they've never told Git before.\n\nSigned-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>\n---\n\nThis is a merge from:\n<20200508180047.GD637136@coredump.intra.peff.net>\n<20200509012304.GB2111@danh.dev>\n\nIt's slipped over the crack.\n\nHence, it may need Peff's SoB.\nCc: Jeff King <peff@peff.net>\nCc: Junio C Hamano <gitster@pobox.com>\n\n ci/config/{allow-refs.sample => allow-ref.sample} | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n rename ci/config/{allow-refs.sample => allow-ref.sample} (91%)\n\ndiff --git a/ci/config/allow-refs.sample b/ci/config/allow-ref.sample\nsimilarity index 91%\nrename from ci/config/allow-refs.sample\nrename to ci/config/allow-ref.sample\nindex f157f1945a..af0e076f8a 100755\n--- a/ci/config/allow-refs.sample\n+++ b/ci/config/allow-ref.sample\n@@ -7,8 +7,9 @@\n # your repository:\n #\n #   git checkout -b ci-config\n-#   cp allow-refs.sample allow-refs\n-#   $EDITOR allow-refs\n+#   cp allow-ref.sample allow-ref\n+#   $EDITOR allow-ref\n+#   git add allow-ref\n #   git commit -am \"implement my ci preferences\"\n #   git push\n #\n-- \n2.26.2.672.g232c24e857\n\n"},{"id":"398078","messageId":"20200518154216.GA41356@coredump.intra.peff.net","threadId":"53495","inReplyTo":"20200518145234.20424-1-congdanhqx@gmail.com","subject":"Re: [PATCH] ci/config: correct instruction for CI preferences","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-05-18T15:42:16Z","receivedAt":"2020-05-18T15:42:18Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, May 18, 2020 at 09:52:34PM +0700, Đoàn Trần Công Danh wrote:\n\n> From e76eec3554 (ci: allow per-branch config for GitHub Actions,\n> 2020-05-07), we started to allow contributors decide which branch\n> they want to build with GitHub Actions\n> by checking for a file named \"ci/config/allow-ref\".\n> \n> In order to assist those contributors,\n> we provided a sample in \"ci/config/allow-refs.sample\",\n> and instructed them to drop the \".sample\",\n> then commit that file to their repository.\n> \n> We've misspelt the filename in that change.\n> Let's fix the spelling.\n> \n> While we're at it, also instruct our contributors introduce that new\n> file to Git before commit, in case of they've never told Git before.\n> \n> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>\n> ---\n> \n> This is a merge from:\n> <20200508180047.GD637136@coredump.intra.peff.net>\n> <20200509012304.GB2111@danh.dev>\n> \n> It's slipped over the crack.\n\nYep, looks good. thanks for tying up this loose end.\n\n> Hence, it may need Peff's SoB.\n> Cc: Jeff King <peff@peff.net>\n\nSigned-off-by: Jeff King <peff@peff.net>\n\n-Peff\n"}]}