{"thread":{"id":"53377","subject":"tig: bug when binding to 'generic'?","startedAt":"2020-05-02T19:04:37Z","lastAt":"2020-05-04T23:14:14Z","messageCount":6,"participants":["Wolfram Sang","Kevin Daudt","Taylor Blau","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"396842","messageId":"20200502190433.GB25220@ninjato","threadId":"53377","inReplyTo":null,"subject":"tig: bug when binding to 'generic'?","fromName":"Wolfram Sang","fromEmail":"wsa@kernel.org","sentAt":"2020-05-02T19:04:33Z","receivedAt":"2020-05-02T19:04:37Z","isPatch":false,"sender":{"key":"wsa@kernel.org","avatar":null},"body":"Hi,\n\nhere is a minimal, problematic .tigrc:\n\n===\nbind\tgeneric\tF\t!echo \"Hello World!\"\n===\n\nThis works for most views, but not for 'main' where it still toggles the\nrefs. Adding a specific 'main' binding works:\n\n===\nbind\tmain\tF\t!echo \"Hello World!\"\n===\n\nIt also works if I bind the 'generic' command to an unused key, e.g. '4'.\n\nDiscovered with Debian's 2.4.1, but confirmed against HEAD of today.\n\nA bug?\n\nThanks,\n\n Wolfram\n\n"},{"id":"396843","messageId":"20200502190729.GC1838755@alpha","threadId":"53377","inReplyTo":"20200502190433.GB25220@ninjato","subject":"Re: tig: bug when binding to 'generic'?","fromName":"Kevin Daudt","fromEmail":"me@ikke.info","sentAt":"2020-05-02T19:07:29Z","receivedAt":"2020-05-02T19:07:35Z","isPatch":false,"sender":{"key":"me@ikke.info","avatar":"https://avatars.githubusercontent.com/u/135698?v=4"},"body":"On Sat, May 02, 2020 at 09:04:33PM +0200, Wolfram Sang wrote:\n> Hi,\n> \n> here is a minimal, problematic .tigrc:\n> \n> ===\n> bind\tgeneric\tF\t!echo \"Hello World!\"\n> ===\n> \n> This works for most views, but not for 'main' where it still toggles the\n> refs. Adding a specific 'main' binding works:\n> \n> ===\n> bind\tmain\tF\t!echo \"Hello World!\"\n> ===\n> \n> It also works if I bind the 'generic' command to an unused key, e.g. '4'.\n> \n> Discovered with Debian's 2.4.1, but confirmed against HEAD of today.\n> \n> A bug?\n> \n> Thanks,\n> \n> Wolfram\n> \n\nHello Wolfram,\n\nTig is a third-party interface, not maintained by git. You can report\nissues for tig on [github][0]\n\nKind regards, Kevin\n\n[0]:https://github.com/jonas/tig/issues\n\n"},{"id":"396844","messageId":"20200502193102.GA1160@kunai","threadId":"53377","inReplyTo":"20200502190729.GC1838755@alpha","subject":"Re: tig: bug when binding to 'generic'?","fromName":"Wolfram Sang","fromEmail":"wsa@the-dreams.de","sentAt":"2020-05-02T19:31:02Z","receivedAt":"2020-05-02T19:31:49Z","isPatch":false,"sender":{"key":"wsa@the-dreams.de","avatar":null},"body":"Hi Kevin,\n\n> Tig is a third-party interface, not maintained by git. You can report\n> issues for tig on [github][0]\n\nI know it is third-party. Seems the README in tig needs fixing, too:\n\n===\nBugs and feature requests can be reported using the issue tracker or by\nmail to either the Git mailing list or directly to the maintainer.\n==\n\nI prefer the mail option, so I wrote here and CCed the maintainers.\n\nKind regards,\n\n Wolfram\n\n"},{"id":"397000","messageId":"20200504220517.GE45250@syl.local","threadId":"53377","inReplyTo":"20200502193102.GA1160@kunai","subject":"Re: tig: bug when binding to 'generic'?","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-05-04T22:05:17Z","receivedAt":"2020-05-04T22:05:21Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sat, May 02, 2020 at 09:31:02PM +0200, Wolfram Sang wrote:\n> Hi Kevin,\n>\n> > Tig is a third-party interface, not maintained by git. You can report\n> > issues for tig on [github][0]\n>\n> I know it is third-party. Seems the README in tig needs fixing, too:\n>\n> ===\n> Bugs and feature requests can be reported using the issue tracker or by\n> mail to either the Git mailing list or directly to the maintainer.\n> ==\n>\n> I prefer the mail option, so I wrote here and CCed the maintainers.\n\nThanks for clarifying. I was a little confused when I read your patch\nseries, since on first blush I thought that you were submitting it to be\napplied in Git's integration branches, and not Tig's.\n\nIn either case, the heads-up is appreciated, but I do not think\nnecessary in general. I am not sure about the feelings of others, but I\ndo not think Tig-specific bugs need to be reported on Git's mailing\nlist.\n\nOf course, if there are Git bugs that affect Tig (or any other project),\nwe would be interested in hearing about them.\n\nThat's all to say that I think the README there should be updated.\n\n> Kind regards,\n>\n> Wolfram\n>\n\nThanks,\nTaylor\n"},{"id":"397005","messageId":"xmqqsggfe23v.fsf@gitster.c.googlers.com","threadId":"53377","inReplyTo":"20200504220517.GE45250@syl.local","subject":"Re: tig: bug when binding to 'generic'?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-05-04T23:01:40Z","receivedAt":"2020-05-04T23:01:45Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n> Thanks for clarifying. I was a little confused when I read your patch\n> series, since on first blush I thought that you were submitting it to be\n> applied in Git's integration branches, and not Tig's.\n>\n> In either case, the heads-up is appreciated, but I do not think\n> necessary in general. I am not sure about the feelings of others, but I\n> do not think Tig-specific bugs need to be reported on Git's mailing\n> list.\n>\n> Of course, if there are Git bugs that affect Tig (or any other project),\n> we would be interested in hearing about them.\n>\n> That's all to say that I think the README there should be updated.\n\nFWIW, I do not mind seeing tig related improvements discussed here\n(I am assuming tig does not have its own development list). That is\nhow we've been operating with other \"projects around Git\", like\n\"imerge\" and \"tbdiff\" (no need to look for the latter these days,\nthough).\n\nUnless Jonas and others who are involved find the list traffic here\nis too heavy and messages about tig will be drowned in here, I do\nnot see a reason to kick them out.\n"},{"id":"397012","messageId":"20200504231408.GI45250@syl.local","threadId":"53377","inReplyTo":"xmqqsggfe23v.fsf@gitster.c.googlers.com","subject":"Re: tig: bug when binding to 'generic'?","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-05-04T23:14:08Z","receivedAt":"2020-05-04T23:14:14Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, May 04, 2020 at 04:01:40PM -0700, Junio C Hamano wrote:\n> Taylor Blau writes:\n>\n> > Thanks for clarifying. I was a little confused when I read your patch\n> > series, since on first blush I thought that you were submitting it to be\n> > applied in Git's integration branches, and not Tig's.\n> >\n> > In either case, the heads-up is appreciated, but I do not think\n> > necessary in general. I am not sure about the feelings of others, but I\n> > do not think Tig-specific bugs need to be reported on Git's mailing\n> > list.\n> >\n> > Of course, if there are Git bugs that affect Tig (or any other project),\n> > we would be interested in hearing about them.\n> >\n> > That's all to say that I think the README there should be updated.\n>\n> FWIW, I do not mind seeing tig related improvements discussed here\n> (I am assuming tig does not have its own development list). That is\n> how we've been operating with other \"projects around Git\", like\n> \"imerge\" and \"tbdiff\" (no need to look for the latter these days,\n> though).\n\nAh, fair enough: I do remember seeing an imerge query on the list a\ncouple of days (weeks?) ago.\n\n> Unless Jonas and others who are involved find the list traffic here\n> is too heavy and messages about tig will be drowned in here, I do\n> not see a reason to kick them out.\n\nOK, that sounds good (it wasn't really up to me anyway, but I'm glad\nthat I know how you feel about the matter ;)).\n\nThanks,\nTaylor\n"}]}