{"thread":{"id":"53335","subject":"Re: [DRAFT] What's cooking in git.git","startedAt":"2020-04-28T05:10:39Z","lastAt":"2020-04-28T17:07:49Z","messageCount":2,"participants":["Son Luong Ngoc","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"396432","messageId":"CAL3xRKdrATjL0+xUH9p8XtgXKd7tD+wCW-+TASJ8saVxBnJVZQ@mail.gmail.com","threadId":"53335","inReplyTo":null,"subject":"Re: [DRAFT] What's cooking in git.git","fromName":"Son Luong Ngoc","fromEmail":"sluongng@gmail.com","sentAt":"2020-04-28T05:10:25Z","receivedAt":"2020-04-28T05:10:39Z","isPatch":false,"sender":{"key":"sluongng@gmail.com","avatar":"https://avatars.githubusercontent.com/u/26684313?v=4"},"body":"Hi,\n\nOn Mon, Apr 27, 2020 at 06:17:37PM -0700, Junio C Hamano wrote:\n> * jn/demote-proto2-from-default (2020-04-22) 1 commit\n>   (merged to 'next' on 2020-04-22 at 1a5e0b221a)\n>  + Revert \"fetch: default to protocol version 2\"\n>\n>  Those fetching over protocol v2 from linux-next and other kernel\n>  repositories are reporting that v2 often fetches way too much than\n>  needed.\n>\n>  Will merge to 'master'.\n...\n> * jt/v2-fetch-nego-fix (2020-04-27) 3 commits\n>  - fetch-pack: in protocol v2, reset in_vain upon ACK\n>  - fetch-pack: in protocol v2, in_vain only after ACK\n>  - fetch-pack: return enum from process_acks()\n\nWould it be ok to just proceed with the fix and skip the revert?\nOr do we intend to revert 'jn/demote-proto2-from-default' after the\nfix has landed into 'master'?\n\nCheers,\nSon Luong.\n"},{"id":"396476","messageId":"xmqqblnb4jz3.fsf@gitster.c.googlers.com","threadId":"53335","inReplyTo":"CAL3xRKdrATjL0+xUH9p8XtgXKd7tD+wCW-+TASJ8saVxBnJVZQ@mail.gmail.com","subject":"Re: [DRAFT] What's cooking in git.git","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-04-28T17:07:44Z","receivedAt":"2020-04-28T17:07:49Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Son Luong Ngoc <sluongng@gmail.com> writes:\n\n>> * jt/v2-fetch-nego-fix (2020-04-27) 3 commits\n>>  - fetch-pack: in protocol v2, reset in_vain upon ACK\n>>  - fetch-pack: in protocol v2, in_vain only after ACK\n>>  - fetch-pack: return enum from process_acks()\n>\n> Would it be ok to just proceed with the fix and skip the revert?\n> Or do we intend to revert 'jn/demote-proto2-from-default' after the\n> fix has landed into 'master'?\n\nThe demote patch hasn't even hit 'master'.  \n\nMy preference is to merge the demotion down to 'master' and 'maint'\nwhile merging down this fix to 'next' and to 'master'.\n\nAnd immediately revert the demotion on 'master', which will make the\ntip of 'master' with v2 as the default, with \"this\" fix.\n\nThat way, those who want to help us polish the code further for the\nnext release would use v2 as default with the proposed fix for this\nbreakage and can hunt for other breakages in v2, while those on the\nmaintenance track (and v2.26.3 JNeider wants to see happen soon)\nwould revert to the original protocol as default.\n\n\n\n\n\n"}]}