{"thread":{"id":"53319","subject":"[PATCH] macos: move PTHREAD_LIBS out of Makefile","startedAt":"2020-04-25T10:26:55Z","lastAt":"2020-04-25T10:26:55Z","messageCount":1,"participants":["Carlo Marcelo Arenas Belón"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"396240","messageId":"20200425102651.51961-1-carenas@gmail.com","threadId":"53319","inReplyTo":null,"subject":"[PATCH] macos: move PTHREAD_LIBS out of Makefile","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2020-04-25T10:26:51Z","receivedAt":"2020-04-25T10:26:55Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"starting with f7d9d04e3b (make: Remove -pthread on Darwin (it is included\nby cstdlib)., 2009-01-26) building in macOS had made sure not to add any\nadditional libraries for thread support.\n\nthe setting was missed when moving the rest of the system specific settings\nto config.uname.mak with e1b6dbb554 (Makefile: hoist uname autodetection to\nconfig.mak.uname, 2013-01-03), so do it now.\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n---\n Makefile         | 4 +++-\n config.mak.uname | 1 +\n 2 files changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex 7e3fc7ca79..4a6739386a 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1290,6 +1290,9 @@ ifeq (no,$(USE_PARENS_AROUND_GETTEXT_N))\n endif\n endif\n \n+# Platform specific configuration should go instead\n+# in config.uname.mak, this is just a last pass to\n+# make sure package managers are supported\n ifeq ($(uname_S),Darwin)\n \tifndef NO_FINK\n \t\tifeq ($(shell test -d /sw/lib && echo y),y)\n@@ -1308,7 +1311,6 @@ ifeq ($(uname_S),Darwin)\n \t\tAPPLE_COMMON_CRYPTO = YesPlease\n \t\tCOMPAT_CFLAGS += -DAPPLE_COMMON_CRYPTO\n \tendif\n-\tPTHREAD_LIBS =\n endif\n \n ifdef NO_LIBGEN_H\ndiff --git a/config.mak.uname b/config.mak.uname\nindex f89acdd15f..1f911a88e3 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -134,6 +134,7 @@ ifeq ($(uname_S),Darwin)\n \tBASIC_CFLAGS += -DPRECOMPOSE_UNICODE\n \tBASIC_CFLAGS += -DPROTECT_HFS_DEFAULT=1\n \tHAVE_BSD_SYSCTL = YesPlease\n+\tPTHREAD_LIBS =\n \tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n \tHAVE_NS_GET_EXECUTABLE_PATH = YesPlease\n \tBASIC_CFLAGS += -I/usr/local/include\n-- \n2.26.2.569.g1d74ac4d14\n\n"}]}