{"thread":{"id":"53318","subject":"[PATCH] macos: move NO_REGEX in macOS to config.mak.uname","startedAt":"2020-04-25T09:15:53Z","lastAt":"2020-04-25T09:15:53Z","messageCount":1,"participants":["Carlo Marcelo Arenas Belón"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"396238","messageId":"20200425091549.42293-1-carenas@gmail.com","threadId":"53318","inReplyTo":null,"subject":"[PATCH] macos: move NO_REGEX in macOS to config.mak.uname","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2020-04-25T09:15:49Z","receivedAt":"2020-04-25T09:15:53Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"29de20504e (Makefile: fix default regex settings on Darwin, 2013-05-11)\nadded this flag to the Makefile since Mac OS X 10.8 at the time didn't\nhave a working REG_EXTENDED|REG_NEWLINE\n\nmove it to config.mak.uname where all the other system specific settings\nare kept since e1b6dbb554 (Makefile: hoist uname autodetection to\nconfig.mak.uname, 2013-01-03) and update the rule so it only applies to\nthose known broken versions as the problem was most likely fixed in the\nnext version when Apple imported TRE on their libc.\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n---\n Makefile         | 1 -\n config.mak.uname | 3 +++\n 2 files changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex dc356ce4dd..7e3fc7ca79 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1308,7 +1308,6 @@ ifeq ($(uname_S),Darwin)\n \t\tAPPLE_COMMON_CRYPTO = YesPlease\n \t\tCOMPAT_CFLAGS += -DAPPLE_COMMON_CRYPTO\n \tendif\n-\tNO_REGEX = YesPlease\n \tPTHREAD_LIBS =\n endif\n \ndiff --git a/config.mak.uname b/config.mak.uname\nindex 0ab8e00938..f89acdd15f 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -125,6 +125,9 @@ ifeq ($(uname_S),Darwin)\n \t\tHAVE_GETDELIM = YesPlease\n \tendif\n \tNO_MEMMEM = YesPlease\n+\tifeq ($(shell test `expr \"$(uname_R)\" : '\\([0-9]*\\)\\.'` -le 12 && echo 1),1)\n+\t\tNO_REGEX = YesPlease\n+\tendif\n \tUSE_ST_TIMESPEC = YesPlease\n \tHAVE_DEV_TTY = YesPlease\n \tCOMPAT_OBJS += compat/precompose_utf8.o\n-- \n2.26.2.569.g1d74ac4d14\n\n"}]}