{"thread":{"id":"53255","subject":"minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio","startedAt":"2020-04-19T04:59:52Z","lastAt":"2020-04-23T05:41:44Z","messageCount":6,"participants":["Dennis Clarke","Junio C Hamano","Jeff King","Kevin Daudt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"395706","messageId":"6bf94982-71c4-78e9-0f4d-7fa4e485c417@blastwave.org","threadId":"53255","inReplyTo":null,"subject":"minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio","fromName":"Dennis Clarke","fromEmail":"dclarke@blastwave.org","sentAt":"2020-04-19T04:52:20Z","receivedAt":"2020-04-19T04:59:52Z","isPatch":false,"sender":{"key":"dclarke@blastwave.org","avatar":null},"body":"\n\nVery minor patch required :\n\n\n--- ./compat/inet_ntop.c.orig Tue Apr 14 01:51:03 2020\n+++ ./compat/inet_ntop.c Sun Apr 19 04:16:39 2020\n@@ -168,7 +168,7 @@\n * Paul Vixie, 1996.\n */\n const char *\n-inet_ntop(int af, const void *src, char *dst, size_t size)\n+inet_ntop(int af, const void *src, char *dst, unsigned int size)\n {\n switch (af) {\n case AF_INET:\n--- ./git-compat-util.h.orig Tue Apr 14 01:51:03 2020\n+++ ./git-compat-util.h Sun Apr 19 03:56:17 2020\n@@ -795,7 +795,7 @@\n #endif\n\n #ifdef NO_INET_NTOP\n-const char *inet_ntop(int af, const void *src, char *dst, size_t size);\n+const char *inet_ntop(int af, const void *src, char *dst, unsigned int \nsize);\n #endif\n\n #ifdef NO_PTHREADS\n#\n# exit\n\nThat allows compile to proceed beatly with :\n\nalpha$\nalpha$ cc -V\ncc: Studio 12.6 Sun C 5.15 SunOS_sparc 2017/05/30\n\n\n\n-- \nDennis Clarke\nRISC-V/SPARC/PPC/ARM/CISC\nUNIX and Linux spoken\nGreyBeard and suspenders optional\n"},{"id":"395709","messageId":"xmqqzhb8rqa6.fsf@gitster.c.googlers.com","threadId":"53255","inReplyTo":"6bf94982-71c4-78e9-0f4d-7fa4e485c417@blastwave.org","subject":"Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-04-19T05:35:45Z","receivedAt":"2020-04-19T05:35:53Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dennis Clarke writes:\n\n> Very minor patch required :\n\nBut both size_t and unsigned int are wrong types, no? Shouldn't we\nbe using socklen_t (and we seem to have autoconf support to figure\nout an appropriate socklen_t fallback typedef)?\n\n> --- ./compat/inet_ntop.c.orig Tue Apr 14 01:51:03 2020\n> +++ ./compat/inet_ntop.c Sun Apr 19 04:16:39 2020\n> @@ -168,7 +168,7 @@\n> * Paul Vixie, 1996.\n> */\n> const char *\n> -inet_ntop(int af, const void *src, char *dst, size_t size)\n> +inet_ntop(int af, const void *src, char *dst, unsigned int size)\n> {\n> switch (af) {\n> case AF_INET:\n> --- ./git-compat-util.h.orig Tue Apr 14 01:51:03 2020\n> +++ ./git-compat-util.h Sun Apr 19 03:56:17 2020\n> @@ -795,7 +795,7 @@\n> #endif\n>\n> #ifdef NO_INET_NTOP\n> -const char *inet_ntop(int af, const void *src, char *dst, size_t size);\n> +const char *inet_ntop(int af, const void *src, char *dst, unsigned\n> int size);\n> #endif\n>\n> #ifdef NO_PTHREADS\n> #\n> # exit\n>\n> That allows compile to proceed beatly with :\n>\n> alpha$\n> alpha$ cc -V\n> cc: Studio 12.6 Sun C 5.15 SunOS_sparc 2017/05/30\n"},{"id":"395885","messageId":"20200422080950.GA464427@coredump.intra.peff.net","threadId":"53255","inReplyTo":"xmqqzhb8rqa6.fsf@gitster.c.googlers.com","subject":"Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-04-22T08:09:50Z","receivedAt":"2020-04-22T08:10:02Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Apr 18, 2020 at 10:35:45PM -0700, Junio C Hamano wrote:\n\n> Dennis Clarke writes:\n> \n> > Very minor patch required :\n> \n> But both size_t and unsigned int are wrong types, no? Shouldn't we\n> be using socklen_t (and we seem to have autoconf support to figure\n> out an appropriate socklen_t fallback typedef)?\n\nThat is generally the right type according to POSIX, but I think there's\nsomething even more subtle going on. If we're defining our own\ninet_ntop(), then the type shouldn't really matter, should it?\n\nDennis didn't show us the compiler errors, but my suspicion is that it\nis complaining because it is seeing the definition of inet_ntop()\nalready from a system header, and ours does not match.\n\nWhich implies that NO_INET_NTOP should not be set in the first place.\nI think this is the same issue discussed in:\n\n https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/\n\nwith a patch (which needs at least a signoff added) in:\n\n https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/\n\nDennis, does building with:\n\n make NO_INET_NTOP= NO_INET_PTON=\n\nhelp?\n\n-Peff\n"},{"id":"395886","messageId":"20200422081156.GB464427@coredump.intra.peff.net","threadId":"53255","inReplyTo":"20200422080950.GA464427@coredump.intra.peff.net","subject":"Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-04-22T08:11:56Z","receivedAt":"2020-04-22T08:11:59Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Apr 22, 2020 at 04:09:50AM -0400, Jeff King wrote:\n\n> Which implies that NO_INET_NTOP should not be set in the first place.\n> I think this is the same issue discussed in:\n> \n> https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/\n> \n> with a patch (which needs at least a signoff added) in:\n> \n> https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/\n> \n> Dennis, does building with:\n> \n> make NO_INET_NTOP= NO_INET_PTON=\n> \n> help?\n\nSorry, I meant to cc Jeffrey Walton from that thread but forgot to.\nDoing so now.\n\n-Peff\n"},{"id":"395967","messageId":"f0beedfb-b50b-51b9-d996-155e0178a90d@blastwave.org","threadId":"53255","inReplyTo":"20200422081156.GB464427@coredump.intra.peff.net","subject":"Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio","fromName":"Dennis Clarke","fromEmail":"dclarke@blastwave.org","sentAt":"2020-04-23T00:09:46Z","receivedAt":"2020-04-23T00:10:06Z","isPatch":false,"sender":{"key":"dclarke@blastwave.org","avatar":null},"body":"On 2020-04-22 04:11, Jeff King wrote:\n> On Wed, Apr 22, 2020 at 04:09:50AM -0400, Jeff King wrote:\n> \n>> Which implies that NO_INET_NTOP should not be set in the first place.\n>> I think this is the same issue discussed in:\n>>\n>> https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/\n>>\n>> with a patch (which needs at least a signoff added) in:\n>>\n>> https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/\n>>\n>> Dennis, does building with:\n>>\n>> make NO_INET_NTOP= NO_INET_PTON=\n>>\n\nI will give that a try today and see what happens. There seems to be a \n2.26.2 release from yesterday and may as well get that going. What was \nthe changelog reason for the bump from 2.26.1 to 2.26.2 ?\n\nDennis\n\n\n"},{"id":"395979","messageId":"20200423054139.GA1838755@alpha","threadId":"53255","inReplyTo":"f0beedfb-b50b-51b9-d996-155e0178a90d@blastwave.org","subject":"Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio","fromName":"Kevin Daudt","fromEmail":"me@ikke.info","sentAt":"2020-04-23T05:41:39Z","receivedAt":"2020-04-23T05:41:44Z","isPatch":false,"sender":{"key":"me@ikke.info","avatar":"https://avatars.githubusercontent.com/u/135698?v=4"},"body":"On Wed, Apr 22, 2020 at 08:09:46PM -0400, Dennis Clarke wrote:\n> On 2020-04-22 04:11, Jeff King wrote:\n> > On Wed, Apr 22, 2020 at 04:09:50AM -0400, Jeff King wrote:\n> > \n> > > Which implies that NO_INET_NTOP should not be set in the first place.\n> > > I think this is the same issue discussed in:\n> > > \n> > > https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/\n> > > \n> > > with a patch (which needs at least a signoff added) in:\n> > > \n> > > https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/\n> > > \n> > > Dennis, does building with:\n> > > \n> > > make NO_INET_NTOP= NO_INET_PTON=\n> > > \n> \n> I will give that a try today and see what happens. There seems to be a\n> 2.26.2 release from yesterday and may as well get that going. What was the\n> changelog reason for the bump from 2.26.1 to 2.26.2 ?\n> \n> Dennis\n> \n> \n\nHello Dennis,\n\nThere was another CVE disclosed:\n\nhttps://lore.kernel.org/git/xmqq4kterq5s.fsf@gitster.c.googlers.com/\n\nKind regards, Kevin\n"}]}