{"thread":{"id":"53161","subject":"The closing bracket is missing.","startedAt":"2020-04-03T02:47:48Z","lastAt":"2020-04-03T21:25:58Z","messageCount":3,"participants":["number201724","brian m. carlson","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"394636","messageId":"8d439c14-6b39-bbb7-a558-61c1e79ff1f3@me.com","threadId":"53161","inReplyTo":null,"subject":"The closing bracket is missing.","fromName":"number201724","fromEmail":"number201724@me.com","sentAt":"2020-04-03T02:39:10Z","receivedAt":"2020-04-03T02:47:48Z","isPatch":false,"sender":{"key":"number201724@me.com","avatar":null},"body":"command-list.h:53:69: error: expected ‘}’ before ‘;’ token\n    53 |  { \"git-apply\", N_(\"Apply a patch to files and/or to the \nindex\"), 0};\n\ncommand-list.h  The closing bracket is missing. In the master branch.\n\n"},{"id":"394699","messageId":"20200403202709.GC6369@camp.crustytoothpaste.net","threadId":"53161","inReplyTo":"8d439c14-6b39-bbb7-a558-61c1e79ff1f3@me.com","subject":"Re: The closing bracket is missing.","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2020-04-03T20:27:09Z","receivedAt":"2020-04-03T20:27:19Z","isPatch":false,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2020-04-03 at 02:39:10, number201724 wrote:\n> command-list.h:53:69: error: expected ‘}’ before ‘;’ token\n>    53 |  { \"git-apply\", N_(\"Apply a patch to files and/or to the index\"),\n> 0};\n> \n> command-list.h  The closing bracket is missing. In the master branch.\n\nI don't see this behavior when compiling on my system, which is a Debian\nsid/amd64 system.  Can you tell us a little more about your system and\nits version, including what shell is being used for /bin/sh, how you're\nbuilding (with make or with configure), and anything else that might be\nrelevant?\n-- \nbrian m. carlson: Houston, Texas, US\nOpenPGP: https://keybase.io/bk2204\n"},{"id":"394719","messageId":"xmqqzhbsxnvm.fsf@gitster.c.googlers.com","threadId":"53161","inReplyTo":"20200403202709.GC6369@camp.crustytoothpaste.net","subject":"Re: The closing bracket is missing.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-04-03T21:25:49Z","receivedAt":"2020-04-03T21:25:58Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"brian m. carlson\" <sandals@crustytoothpaste.net> writes:\n\n> On 2020-04-03 at 02:39:10, number201724 wrote:\n>> command-list.h:53:69: error: expected ‘}’ before ‘;’ token\n>>    53 |  { \"git-apply\", N_(\"Apply a patch to files and/or to the index\"),\n>> 0};\n>> \n>> command-list.h  The closing bracket is missing. In the master branch.\n>\n> I don't see this behavior when compiling on my system, which is a Debian\n> sid/amd64 system.  Can you tell us a little more about your system and\n> its version, including what shell is being used for /bin/sh, how you're\n> building (with make or with configure), and anything else that might be\n> relevant?\n\nGood suggestion.  As this is a generated file, we can have issues\nwith the different behaviour in the commands used in the toolchain\nto create it.\n"}]}