{"thread":{"id":"5311","subject":"[PATCH] gitweb: bugfix: commitdiff regression","startedAt":"2006-08-17T20:52:09Z","lastAt":"2006-08-18T04:09:00Z","messageCount":2,"participants":["Luben Tuikov","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"25508","messageId":"20060817205209.98624.qmail@web31801.mail.mud.yahoo.com","threadId":"5311","inReplyTo":null,"subject":"[PATCH] gitweb: bugfix: commitdiff regression","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-17T20:52:09Z","receivedAt":"2006-08-17T20:52:09Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Fix regression in git_commitdiff() introduced\nby commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.\n\nSigned-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex bb77b55..b97342f 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2414,7 +2414,7 @@ sub git_commitdiff {\n \t\t\t\t      $cgi->a({-href => href(action=>\"blob\", hash=>$from_id, hash_base=>$hash_parent, file_name=>$file)}, $from_id) .\n \t\t\t\t      \" -> \" .\n \t\t\t\t      file_type($to_mode) . \":\" .\n-\t\t\t\t      $cgi->a({-href => href(action=>\"blob\", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id) .\n+\t\t\t\t      $cgi->a({-href => href(action=>\"blob\", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id);\n \t\t\t\tprint \"</div>\\n\";\n \t\t\t\tgit_diff_print($from_id, \"a/$file\",  $to_id, \"b/$file\");\n \t\t\t}\n-- \n1.4.2.g75c01\n\n"},{"id":"25516","messageId":"7vveoqelcz.fsf@assigned-by-dhcp.cox.net","threadId":"5311","inReplyTo":"20060817205209.98624.qmail@web31801.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: bugfix: commitdiff regression","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-18T04:09:00Z","receivedAt":"2006-08-18T04:09:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Well spotted; thanks.\n"}]}