{"thread":{"id":"53106","subject":"[PATCH 0/2] test shell-library cleanups","startedAt":"2020-03-26T08:23:40Z","lastAt":"2020-03-26T08:33:50Z","messageCount":4,"participants":["Jeff King","Denton Liu"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"394063","messageId":"20200326082338.GA3611364@coredump.intra.peff.net","threadId":"53106","inReplyTo":null,"subject":"[PATCH 0/2] test shell-library cleanups","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-03-26T08:23:38Z","receivedAt":"2020-03-26T08:23:40Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"Inspired by Dscho's cleanup of lib-gpg.sh in [1], I noticed a few other\nthings.\n\n  [1/2]: t/lib-credential.sh: drop shebang line\n  [2/2]: t/lib-*.sh: drop executable bit\n\n t/lib-credential.sh       | 3 ++-\n t/lib-gpg.sh              | 0\n t/lib-log-graph.sh        | 0\n t/lib-submodule-update.sh | 0\n 4 files changed, 2 insertions(+), 1 deletion(-)\n mode change 100755 => 100644 t/lib-credential.sh\n mode change 100755 => 100644 t/lib-gpg.sh\n mode change 100755 => 100644 t/lib-log-graph.sh\n mode change 100755 => 100644 t/lib-submodule-update.sh\n\n-Peff\n\n[1] https://lore.kernel.org/git/c1811d54190a62e3d35505e2b806c89238b56de8.1585114881.git.gitgitgadget@gmail.com/\n"},{"id":"394064","messageId":"20200326082527.GA3611762@coredump.intra.peff.net","threadId":"53106","inReplyTo":"20200326082338.GA3611364@coredump.intra.peff.net","subject":"[PATCH 1/2] t/lib-credential.sh: drop shebang line","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-03-26T08:25:27Z","receivedAt":"2020-03-26T08:25:29Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"The purpose of lib-credential.sh is to be sourced into other test\nscripts. It doesn't need a \"#!/bin/sh\" line, as running it directly\nmakes no sense. Nor does it serve any real filetype documentation\npurpose, as the file is cleary named with a \".sh\" extension.\n\nIn the spirit of c74c72034f (test: replace shebangs with descriptions in\nshell libraries, 2013-11-25), let's replace it with a human-readable\ndescription.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nI left the similar case in lib-gpg alone so as not to conflict with\nDscho's version.\n\n t/lib-credential.sh | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/t/lib-credential.sh b/t/lib-credential.sh\nindex 937b831ea6..5ea8bc9f1d 100755\n--- a/t/lib-credential.sh\n+++ b/t/lib-credential.sh\n@@ -1,4 +1,5 @@\n-#!/bin/sh\n+# Shell library for testing credential handling including helpers. See t0302\n+# for an example of testing a specific helper.\n \n # Try a set of credential helpers; the expected stdin,\n # stdout and stderr should be provided on stdin,\n-- \n2.26.0.576.gb87790c3c1\n\n"},{"id":"394065","messageId":"20200326082553.GB3611762@coredump.intra.peff.net","threadId":"53106","inReplyTo":"20200326082338.GA3611364@coredump.intra.peff.net","subject":"[PATCH 2/2] t/lib-*.sh: drop executable bit","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-03-26T08:25:53Z","receivedAt":"2020-03-26T08:25:55Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"There's no need for shell libraries to have the executable bit. They're\nmeant to be sourced, and running them stand-alone is pointless. Let's\nreduce any possible confusion by making it more clear they're not meant\nto be run this way.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\n t/lib-credential.sh       | 0\n t/lib-gpg.sh              | 0\n t/lib-log-graph.sh        | 0\n t/lib-submodule-update.sh | 0\n 4 files changed, 0 insertions(+), 0 deletions(-)\n mode change 100755 => 100644 t/lib-credential.sh\n mode change 100755 => 100644 t/lib-gpg.sh\n mode change 100755 => 100644 t/lib-log-graph.sh\n mode change 100755 => 100644 t/lib-submodule-update.sh\n\ndiff --git a/t/lib-credential.sh b/t/lib-credential.sh\nold mode 100755\nnew mode 100644\ndiff --git a/t/lib-gpg.sh b/t/lib-gpg.sh\nold mode 100755\nnew mode 100644\ndiff --git a/t/lib-log-graph.sh b/t/lib-log-graph.sh\nold mode 100755\nnew mode 100644\ndiff --git a/t/lib-submodule-update.sh b/t/lib-submodule-update.sh\nold mode 100755\nnew mode 100644\n-- \n2.26.0.576.gb87790c3c1\n"},{"id":"394075","messageId":"20200326083346.GA1891350@generichostname","threadId":"53106","inReplyTo":"20200326082527.GA3611762@coredump.intra.peff.net","subject":"Re: [PATCH 1/2] t/lib-credential.sh: drop shebang line","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2020-03-26T08:33:46Z","receivedAt":"2020-03-26T08:33:50Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"On Thu, Mar 26, 2020 at 04:25:27AM -0400, Jeff King wrote:\n> The purpose of lib-credential.sh is to be sourced into other test\n> scripts. It doesn't need a \"#!/bin/sh\" line, as running it directly\n> makes no sense. Nor does it serve any real filetype documentation\n> purpose, as the file is cleary named with a \".sh\" extension.\n\ns/cleary/clearly/\n\nPatch and message look obviously good otherwise.\n"}]}