{"thread":{"id":"53038","subject":"[GSoC] Query regarding Microproject","startedAt":"2020-03-20T06:37:35Z","lastAt":"2020-03-25T13:52:05Z","messageCount":6,"participants":["Shanthanu Rai","Christian Couder","Shanthanu"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"393520","messageId":"CAGNOEmugZDWpvAHsOzmm_Fqo_Vj5GcC--GfTg3JHPm701HjBXA@mail.gmail.com","threadId":"53038","inReplyTo":null,"subject":"[GSoC] Query regarding Microproject","fromName":"Shanthanu Rai","fromEmail":"shanthanu.s.rai9@gmail.com","sentAt":"2020-03-20T06:37:20Z","receivedAt":"2020-03-20T06:37:35Z","isPatch":false,"sender":{"key":"shanthanu.s.rai9@gmail.com","avatar":"https://gravatar.com/avatar/609b002d0db85d343299e3e807bbb1c8eb333ac17aa7cc4069f93385600e5053?d=mp&s=160"},"body":"Hi, I am a 3rd Computer Science Undergrad at National Institute of\nTechnology Surathkal, India. I wish to apply to git for GSoC.\n\nI am currently working on the microproject titled \"Avoid pipes in git\nrelated commands in test scripts\". I found 't/t9116-git-svn-log.sh' to\nhave some commands wherein output of git is redirected to grep (using\npipe). So shall I go ahead and make the required changes, i.e., redirect\nthe output of git to a file and grep this file, in the relevant commands?\n\n--\nRegards,\nShanthanu S Rai\n"},{"id":"393529","messageId":"CAP8UFD2bgzvc2K2Sj4HSeXo16kB8D8se=+=Y7gp6FN+4Y3C1BQ@mail.gmail.com","threadId":"53038","inReplyTo":"CAGNOEmugZDWpvAHsOzmm_Fqo_Vj5GcC--GfTg3JHPm701HjBXA@mail.gmail.com","subject":"Re: [GSoC] Query regarding Microproject","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2020-03-20T13:41:29Z","receivedAt":"2020-03-20T13:41:45Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Hi,\n\nOn Fri, Mar 20, 2020 at 7:39 AM Shanthanu Rai\n wrote:\n>\n> Hi, I am a 3rd Computer Science Undergrad at National Institute of\n> Technology Surathkal, India. I wish to apply to git for GSoC.\n>\n> I am currently working on the microproject titled \"Avoid pipes in git\n> related commands in test scripts\". I found 't/t9116-git-svn-log.sh' to\n> have some commands wherein output of git is redirected to grep (using\n> pipe). So shall I go ahead and make the required changes, i.e., redirect\n> the output of git to a file and grep this file, in the relevant commands?\n\nYeah, sure.\n\nIn 't/t9116-git-svn-log.sh' it seems to me that some refactoring might\nbe needed too.\n\nBest,\nChristian.\n"},{"id":"393540","messageId":"47a1db25-914a-2e59-c0a6-6d0ff77bc2aa@gmail.com","threadId":"53038","inReplyTo":"CAP8UFD2bgzvc2K2Sj4HSeXo16kB8D8se=+=Y7gp6FN+4Y3C1BQ@mail.gmail.com","subject":"Re: [GSoC] Query regarding Microproject","fromName":"Shanthanu","fromEmail":"shanthanu.s.rai9@gmail.com","sentAt":"2020-03-20T16:27:15Z","receivedAt":"2020-03-20T16:27:24Z","isPatch":false,"sender":{"key":"shanthanu.s.rai9@gmail.com","avatar":"https://gravatar.com/avatar/609b002d0db85d343299e3e807bbb1c8eb333ac17aa7cc4069f93385600e5053?d=mp&s=160"},"body":"Hey, I had faced some issues while running tests with the below command:\nsh t9116-git-svn-log.sh\n\nI ran the test without making any changes to the file.\n\nTo get more verbose output for the reason of failure, I ran:\nsh t9116-git-svn-log.sh -v -i -d (-i to figure out why the first test fails)\n\nIn the verbose output, I got the below error msg:\n\nCouldn't open a repository: Unable to connect to a repository at URL\n'file:///{hidden}/git/t/trash%20directory.t9116-git-svn-log/svnrepo':\nUnable to open an ra_local session to URL: Unable to open repository\n'file:///{hidden}/git/t/trash%20directory.t9116-git-svn-log/svnrepo':\nExpected FS format between '1' and '6'; found format '7' at\n{hidden}/git/perl/build/lib/Git/SVN.pm line 310.\n\nI can share the entire verbose output if needed.\n\nOn 20/03/20 7:11 pm, Christian Couder wrote:\n> Hi,\n>\n> On Fri, Mar 20, 2020 at 7:39 AM Shanthanu Rai\n> wrote:\n>> Hi, I am a 3rd Computer Science Undergrad at National Institute of\n>> Technology Surathkal, India. I wish to apply to git for GSoC.\n>>\n>> I am currently working on the microproject titled \"Avoid pipes in git\n>> related commands in test scripts\". I found 't/t9116-git-svn-log.sh' to\n>> have some commands wherein output of git is redirected to grep (using\n>> pipe). So shall I go ahead and make the required changes, i.e., redirect\n>> the output of git to a file and grep this file, in the relevant commands?\n> Yeah, sure.\n>\n> In 't/t9116-git-svn-log.sh' it seems to me that some refactoring might\n> be needed too.\n>\n> Best,\n> Christian.\n"},{"id":"393607","messageId":"d676674d-7ab5-b476-8dbb-2b3323db2c89@gmail.com","threadId":"53038","inReplyTo":"47a1db25-914a-2e59-c0a6-6d0ff77bc2aa@gmail.com","subject":"Re: [GSoC] Query regarding Microproject","fromName":"Shanthanu","fromEmail":"shanthanu.s.rai9@gmail.com","sentAt":"2020-03-21T09:49:20Z","receivedAt":"2020-03-21T09:49:27Z","isPatch":false,"sender":{"key":"shanthanu.s.rai9@gmail.com","avatar":"https://gravatar.com/avatar/609b002d0db85d343299e3e807bbb1c8eb333ac17aa7cc4069f93385600e5053?d=mp&s=160"},"body":"I found the solution to my issue. The main error message I had got was\n\n> Expected FS format between '1' and '6'; found format '7' at\n> {hidden}/git/perl/build/lib/Git/SVN.pm line 310.\nAfter some online searches, I found out that file system format 7\nwas 'understood' by subversion 1.9 (Filesystem formats section in\nhttps://svn.apache.org/repos/asf/subversion/trunk/subversion/libsvn_fs_fs/structure).\nThat's when I realized I was using version 1.9 of subversion.\n\nWhen I downgraded to subversion 1.8 (which understands file format 6),\nall tests passed.\n\nSo shouldn't the test file itself have mentioned (say as a comment at \nthe top\nor in a separate README) that it was expecting subversion 1.8 or lesser on\nthe system? I am using Ubuntu 18.04 and by default the package manager\ninstalls subversion 1.9.\n\nThis issue might also be present in other git-svn test files. (I haven't \nchecked\nthough, not sure how to run just git-svn tests)\n\n"},{"id":"393806","messageId":"CAP8UFD3fAQyiXsO0w_uG6Oe8EfvkL6=ijUqHp4j8GD8A50Jo+g@mail.gmail.com","threadId":"53038","inReplyTo":"d676674d-7ab5-b476-8dbb-2b3323db2c89@gmail.com","subject":"Re: [GSoC] Query regarding Microproject","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2020-03-23T19:31:01Z","receivedAt":"2020-03-23T19:31:15Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Sat, Mar 21, 2020 at 10:49 AM Shanthanu wrote:\n>\n> I found the solution to my issue. The main error message I had got was\n>\n> > Expected FS format between '1' and '6'; found format '7' at\n> > {hidden}/git/perl/build/lib/Git/SVN.pm line 310.\n> After some online searches, I found out that file system format 7\n> was 'understood' by subversion 1.9 (Filesystem formats section in\n> https://svn.apache.org/repos/asf/subversion/trunk/subversion/libsvn_fs_fs/structure).\n> That's when I realized I was using version 1.9 of subversion.\n>\n> When I downgraded to subversion 1.8 (which understands file format 6),\n> all tests passed.\n\nGreat!\n\n> So shouldn't the test file itself have mentioned (say as a comment at\n> the top\n> or in a separate README) that it was expecting subversion 1.8 or lesser on\n> the system? I am using Ubuntu 18.04 and by default the package manager\n> installs subversion 1.9.\n\nIt would be better if the test could be fixed to work with subversion\n1.9. Otherwise the test could perhaps check the subversion version and\nrun only if subversion is version 1.8 or lesser.\n\n> This issue might also be present in other git-svn test files. (I haven't\n> checked\n> though, not sure how to run just git-svn tests)\n\nMaybe with something like:\n\n$ cd t\n$ prove --jobs 8 t91*-svn*.sh\n"},{"id":"393965","messageId":"165cc039-2092-2520-e23e-5734fd3fc0f8@gmail.com","threadId":"53038","inReplyTo":"CAP8UFD3fAQyiXsO0w_uG6Oe8EfvkL6=ijUqHp4j8GD8A50Jo+g@mail.gmail.com","subject":"Re: [GSoC] Query regarding Microproject","fromName":"Shanthanu","fromEmail":"shanthanu.s.rai9@gmail.com","sentAt":"2020-03-25T13:51:58Z","receivedAt":"2020-03-25T13:52:05Z","isPatch":false,"sender":{"key":"shanthanu.s.rai9@gmail.com","avatar":"https://gravatar.com/avatar/609b002d0db85d343299e3e807bbb1c8eb333ac17aa7cc4069f93385600e5053?d=mp&s=160"},"body":"\nOn 24/03/20 1:01 am, Christian Couder wrote:\n>> So shouldn't the test file itself have mentioned (say as a comment at\n>> the top\n>> or in a separate README) that it was expecting subversion 1.8 or lesser on\n>> the system? I am using Ubuntu 18.04 and by default the package manager\n>> installs subversion 1.9.\n> It would be better if the test could be fixed to work with subversion\n> 1.9. Otherwise the test could perhaps check the subversion version and\n> run only if subversion is version 1.8 or lesser.\n\nYeah that makes sense. I will try to look into how the tests can be\nfixed to work with svn 1.9.\n\n>> This issue might also be present in other git-svn test files. (I haven't\n>> checked\n>> though, not sure how to run just git-svn tests)\n> Maybe with something like:\n>\n> $ cd t\n> $ prove --jobs 8 t91*-svn*.sh\n\nThanks. I ran the command and found that all tests (except t9119) fail for\nsvn 1.9 and pass for 1.8.\nt9119 gives the below output for svn 1.8:\nskipped: skipping svn-info test (SVN version: 1.8.13 not supported)\n\n't9119-git-svn-info.sh' seems to already have the code to check\nthe version of subversion. So we could use the same code to check\nthe correct version in 'lib-git-svn.sh'?\n\nNote that I haven't checked which all subversion versions work for\na given test (only know that svn 1.8 works for all).\n\n"}]}