{"thread":{"id":"53031","subject":"[GSoC][Patch 0/2] t4131: update test script","startedAt":"2020-03-19T13:30:22Z","lastAt":"2020-03-20T17:14:27Z","messageCount":17,"participants":["Harshit Jain","Shourya Shukla","Kaartic Sivaraam","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"393445","messageId":"20200319132957.17813-1-harshitjain1371999@gmail.com","threadId":"53031","inReplyTo":null,"subject":"[GSoC][Patch 0/2] t4131: update test script","fromName":"Harshit Jain","fromEmail":"harshitjain1371999@gmail.com","sentAt":"2020-03-19T13:29:55Z","receivedAt":"2020-03-19T13:30:22Z","isPatch":true,"sender":{"key":"harshitjain1371999@gmail.com","avatar":null},"body":"\nGreetings!\n\nHere is my very first contribution to the open-source community. I have always been a great admirer of the open-source developments and am really excited to begin my journey in the open source development.\n\nIn this patch, I have:\n - modernized the script code to adhere to the CodingGuidelines\n - replaced 'test -f' with the helper function 'test_path_is_file' as it make the code more readable and also gives better error messages\n\nJust to add, I have done this as a microproject for my GSoC application, and am hoping to contribute more to the git during the coming summers.\n\nThanks,\nHarshit Jain\n\n"},{"id":"393446","messageId":"20200319132957.17813-2-harshitjain1371999@gmail.com","threadId":"53031","inReplyTo":"20200319132957.17813-1-harshitjain1371999@gmail.com","subject":"[GSoC][PATCH 1/2] t4131: modernize style","fromName":"Harshit Jain","fromEmail":"harshitjain1371999@gmail.com","sentAt":"2020-03-19T13:29:56Z","receivedAt":"2020-03-19T13:30:33Z","isPatch":true,"sender":{"key":"harshitjain1371999@gmail.com","avatar":null},"body":"The tests in 't4131-apply-fake-ancestor.sh' were written a long time ago, and have a few style violations. Update it to adhere to the CodingGuidelines.\n\nSigned-off-by: Harshit Jain \n---\n t/t4131-apply-fake-ancestor.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t4131-apply-fake-ancestor.sh b/t/t4131-apply-fake-ancestor.sh\nindex b1361ce546..828d1a355b 100755\n--- a/t/t4131-apply-fake-ancestor.sh\n+++ b/t/t4131-apply-fake-ancestor.sh\n@@ -17,8 +17,8 @@ test_expect_success 'setup' '\n \n test_expect_success 'apply --build-fake-ancestor' '\n \tgit checkout 2 &&\n-\techo \"A\" > 1.t &&\n-\tgit diff > 1.patch &&\n+\techo \"A\" >1.t &&\n+\tgit diff >1.patch &&\n \tgit reset --hard &&\n \tgit checkout 1 &&\n \tgit apply --build-fake-ancestor 1.ancestor 1.patch\n@@ -26,8 +26,8 @@ test_expect_success 'apply --build-fake-ancestor' '\n \n test_expect_success 'apply --build-fake-ancestor in a subdirectory' '\n \tgit checkout 3 &&\n-\techo \"C\" > sub/3.t &&\n-\tgit diff > 3.patch &&\n+\techo \"C\" >sub/3.t &&\n+\tgit diff >3.patch &&\n \tgit reset --hard &&\n \tgit checkout 4 &&\n \t(\n-- \n2.26.0.rc2\n\n"},{"id":"393447","messageId":"20200319132957.17813-3-harshitjain1371999@gmail.com","threadId":"53031","inReplyTo":"20200319132957.17813-1-harshitjain1371999@gmail.com","subject":"[GSoC][PATCH 2/2] t4131: use helper function to replace test -f ","fromName":"Harshit Jain","fromEmail":"harshitjain1371999@gmail.com","sentAt":"2020-03-19T13:29:57Z","receivedAt":"2020-03-19T13:30:42Z","isPatch":true,"sender":{"key":"harshitjain1371999@gmail.com","avatar":null},"body":"Replace 'test -f' with the helper function 'test_path_is_file' as the helper function improves the code readability and also gives better error messages.\n\nSigned-off-by: Harshit Jain \n---\n t/t4131-apply-fake-ancestor.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4131-apply-fake-ancestor.sh b/t/t4131-apply-fake-ancestor.sh\nindex 828d1a355b..21ee359632 100755\n--- a/t/t4131-apply-fake-ancestor.sh\n+++ b/t/t4131-apply-fake-ancestor.sh\n@@ -33,7 +33,7 @@ test_expect_success 'apply --build-fake-ancestor in a subdirectory' '\n \t(\n \t\tcd sub &&\n \t\tgit apply --build-fake-ancestor 3.ancestor ../3.patch &&\n-\t\ttest -f 3.ancestor\n+\t\ttest_path_is_file 3.ancestor\n \t) &&\n \tgit apply --build-fake-ancestor 3.ancestor 3.patch &&\n \ttest_cmp sub/3.ancestor 3.ancestor\n-- \n2.26.0.rc2\n\n"},{"id":"393470","messageId":"20200319163817.4239-1-shouryashukla.oo@gmail.com","threadId":"53031","inReplyTo":"20200319132957.17813-2-harshitjain1371999@gmail.com","subject":"Re: [GSoC][PATCH 1/2] t4131: modernize style","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-03-19T16:38:17Z","receivedAt":"2020-03-19T16:38:29Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"Hello Harshit,\n\n> The tests in 't4131-apply-fake-ancestor.sh' were written a long time ago, and have a few style violations. Update it to adhere to the CodingGuidelines.\n\nMaybe add a commit title and then have a body? To do so, do a 'git commit' instead of 'git commit -m \"message\"'. This will open a text editor\nin which you can edit your commit message. You may refer to this answer I gave on StackOverflow on commit messages:\n\nhttps://stackoverflow.com/a/60755299/10751129\n\nAlso, commit messages are generally around 72 characters per line. What are the\nstyle violations you are talking about BTW?\n\nThe commit title can be of the form:\n\nt4131: modernise style\n\n<>\n\n\nRegards,\nShourya Shukla\n"},{"id":"393471","messageId":"20200319164234.4441-1-shouryashukla.oo@gmail.com","threadId":"53031","inReplyTo":"20200319132957.17813-3-harshitjain1371999@gmail.com","subject":"Re: [GSoC][PATCH 2/2] t4131: use helper function to replace test -f ","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-03-19T16:42:34Z","receivedAt":"2020-03-19T16:42:47Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"Hello Harshit,\n\n> Replace 'test -f' with the helper function 'test_path_is_file' as the helper function improves the code readability and also gives better error messages.\n\nAgain the same thing, you may follow what I stated before regarding commit messages.\n\nThe commit title can be of the form:\n\nt4131: use helpers to replace test -f \n\n<>\n\nIf you still face any problem, feel free to drop a message :)\n\nRegards,\nShourya Shukla\n"},{"id":"393482","messageId":"555da203-0740-3d79-15cf-83c5a8d5dbae@gmail.com","threadId":"53031","inReplyTo":"20200319164234.4441-1-shouryashukla.oo@gmail.com","subject":"Re: [GSoC][PATCH 2/2] t4131: use helper function to replace test -f ","fromName":"Kaartic Sivaraam","fromEmail":"kaartic.sivaraam@gmail.com","sentAt":"2020-03-19T17:33:24Z","receivedAt":"2020-03-19T17:34:22Z","isPatch":true,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"On 19-03-2020 22:12, Shourya Shukla wrote:\n> Hello Harshit,\n> \n>> Replace 'test -f' with the helper function 'test_path_is_file' as the helper function improves the code readability and also gives better error messages.\n> \n> Again the same thing, you may follow what I stated before regarding commit messages.\n> \n> The commit title can be of the form:\n> \n> t4131: use helpers to replace test -f \n> \n> <>\n> \n\nJust curious, isn't the commit title already like that in this patch? \nThe subject does read:\n\n [GSoC][PATCH 2/2] t4131: use helper function to replace test -f \"\n\nWhat am I missing?\n\n-- \nSivaraam\n"},{"id":"393484","messageId":"CACuU+s9WbKyg3P+ai8pnQqvRJDv+OoyqU-730K=1R7uasc=09g@mail.gmail.com","threadId":"53031","inReplyTo":"20200319163817.4239-1-shouryashukla.oo@gmail.com","subject":"Re: [GSoC][PATCH 1/2] t4131: modernize style","fromName":"Harshit Jain","fromEmail":"harshitjain1371999@gmail.com","sentAt":"2020-03-19T17:45:32Z","receivedAt":"2020-03-19T17:45:48Z","isPatch":true,"sender":{"key":"harshitjain1371999@gmail.com","avatar":null},"body":"Hi Shourya,\n\n> > The tests in 't4131-apply-fake-ancestor.sh' were written a long time ago, and have a few style violations. Update it to adhere to the CodingGuidelines.\n>\n> Maybe add a commit title and then have a body? To do so, do a 'git commit' instead of 'git commit -m \"message\"'. This will open a text editor\n> in which you can edit your commit message. You may refer to this answer I gave on StackOverflow on commit messages:\n>\n> https://stackoverflow.com/a/60755299/10751129\n\nI used 'git commit' only and not 'git commit -m \"message\". But\napparently, the git format-patch tool takes the first line of commit\nmessage i.e. the\ncommit title as the file name and the lines after that as the text for\nthe body. And hence, the patch emails, just start with the commit\ndescription\nand not the commit title.\n\nSo, should I explicitly add the commit title in the patch files\ngenerated or else how to handle this?\n\n> Also, commit messages are generally around 72 characters per line. What are the\n> style violations you are talking about BTW?\n\nThe git coding guidelines says that we shouldn't have a space after\nthe redirection operators, hence I corrected this in the test file.\n\nRegards,\nHarshit Jain\n"},{"id":"393486","messageId":"CACuU+s-0VQgDOhdoc66FRFunHLdKGUu55NAwL95LcHNEK8J6Vw@mail.gmail.com","threadId":"53031","inReplyTo":"555da203-0740-3d79-15cf-83c5a8d5dbae@gmail.com","subject":"Re: [GSoC][PATCH 2/2] t4131: use helper function to replace test -f ","fromName":"Harshit Jain","fromEmail":"harshitjain1371999@gmail.com","sentAt":"2020-03-19T20:18:09Z","receivedAt":"2020-03-19T20:18:24Z","isPatch":true,"sender":{"key":"harshitjain1371999@gmail.com","avatar":null},"body":"On Thu, Mar 19, 2020 at 11:04 PM Kaartic Sivaraam\n wrote:\n>\n> On 19-03-2020 22:12, Shourya Shukla wrote:\n> > Hello Harshit,\n> >\n> >> Replace 'test -f' with the helper function 'test_path_is_file' as the helper function improves the code readability and also gives better error messages.\n> >\n> > Again the same thing, you may follow what I stated before regarding commit messages.\n> >\n> > The commit title can be of the form:\n> >\n> > t4131: use helpers to replace test -f \n> >\n> > <>\n> >\n>\n> Just curious, isn't the commit title already like that in this patch?\n> The subject does read:\n>\n> [GSoC][PATCH 2/2] t4131: use helper function to replace test -f \"\n>\n> What am I missing?\n>\n\nHey Shourya,\nCan you please clarify, I am also a bit confused.\n\nRegards,\nHarshit Jain\n"},{"id":"393489","messageId":"xmqq5zf0dn7n.fsf@gitster.c.googlers.com","threadId":"53031","inReplyTo":"CACuU+s9WbKyg3P+ai8pnQqvRJDv+OoyqU-730K=1R7uasc=09g@mail.gmail.com","subject":"Re: [GSoC][PATCH 1/2] t4131: modernize style","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-03-19T21:55:08Z","receivedAt":"2020-03-19T21:55:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Harshit Jain writes:\n\n>> > The tests in 't4131-apply-fake-ancestor.sh' were written a long\n>> > time ago, and have a few style violations. Update it to adhere\n>> > to the CodingGuidelines.\n>> ...\n> I used 'git commit' only and not 'git commit -m \"message\". But\n\nI'd suggest developers, especially the new ones, to stay away from\nusing '-m \"message\"' form, too.\n\nIn your editor, you would probably have written something like\n\n\t-- -- -- -- -- the contents of editor window -- -- -- -- --\n\tt4131: modernize style\n\n\tThe tests in 't4131-apply-fake-ancestor.sh' were written ...\n\t...\n\n\t-- -- -- -- -- the contents of editor window -- -- -- -- --\n\nAs you observed, the first paragraph of the log message text is\ntaken as the title of the commit, and \"git format-patch\" places the\ntitle on the \"Subject:\" line (if you had more than one line in the\nfirst paragraph, since the payload on the \"Subject: \" line has to be\na logically single line, you'd end up getting a single long line\nthat has the contents on all lines in the first paragraph).\n\nThe second and subsequent paragraphs become the body of the message.\n\nYour title looks reasonable; there is nothing that needs to be\n\"fixed\" or \"improved\" there.\n\nYour second paragraph is not so good---it should wrap the lines at a\nreasonable length (say 65-70 columns).\n\nYour last paragraph, which consists of a single \"Signed-off-by:\"\nline in this case, is good. It matches the identity recorded on the\n\"From:\" line of the message.\n\n>> Also, commit messages are generally around 72 characters per line. What are the\n>> style violations you are talking about BTW?\n>\n> The git coding guidelines says that we shouldn't have a space after\n> the redirection operators, hence I corrected this in the test file.\n\nThat is a good thing to write in the commit log message. \n\n\"written a long time ago\" does not have much value by itself (it\ndoes serve as a backstory to explain a half of why it does not use\nthe more modern style, though). \"have a few style violations.\" is\nalmost meaningless (otherwise, you would not be doing a \"modernize\nstyle\" patch in the first place ;-).\n\n\tt4131: modernize style.\n\n\tThe tests in t4131 leaves a SP between a redirection\n\toperator and the file that is the redirection target,\n\twhich does not conform to the modern coding style.\n\n\tFix them.\n\n\tSigned-off-by: ...\n\nperhaps.\n"},{"id":"393490","messageId":"xmqq1rpodn25.fsf@gitster.c.googlers.com","threadId":"53031","inReplyTo":"20200319164234.4441-1-shouryashukla.oo@gmail.com","subject":"Re: [GSoC][PATCH 2/2] t4131: use helper function to replace test -f ","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-03-19T21:58:26Z","receivedAt":"2020-03-19T21:58:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Shourya Shukla writes:\n\n> Hello Harshit,\n>\n>> Replace 'test -f' with the helper function 'test_path_is_file' as the helper function improves the code readability and also gives better error messages.\n>\n> Again the same thing, you may follow what I stated before regarding commit messages.\n>\n> The commit title can be of the form:\n>\n> t4131: use helpers to replace test -f \n>\n> <>\n\nI think Harshit is writing the title of the commit in the right\nplace. Format-wise, the only thing that is wrong is that each\nparagraph is too long without line wrapping.\n\nWhat is wrong in these two e-mail thread is that you are not reading\nthe log message correctly. When made into a piece of e-mail, the\ntitle goes to the \"Subject:\" field in the header and there is no\nneed to repeat it in the body of the e-mail.\n"},{"id":"393526","messageId":"20200320130845.23257-1-harshitjain1371999@gmail.com","threadId":"53031","inReplyTo":"xmqq1rpodn25.fsf@gitster.c.googlers.com","subject":"[GSoC][Patch 0/2] made the changes as per community suggestions","fromName":"Harshit Jain","fromEmail":"harshitjain1371999@gmail.com","sentAt":"2020-03-20T13:08:43Z","receivedAt":"2020-03-20T13:09:16Z","isPatch":true,"sender":{"key":"harshitjain1371999@gmail.com","avatar":null},"body":"\nGreetings!\n\nThank you for suggesting the changes in my patches. I have made the changes\nas advised by Junio C Hamano in the following patch emails. Please look into\nthose patch mails and suggest any further changes if needed.\n\nThank you once again.\n\nHarshit Jain\n\n"},{"id":"393527","messageId":"20200320130845.23257-2-harshitjain1371999@gmail.com","threadId":"53031","inReplyTo":"20200320130845.23257-1-harshitjain1371999@gmail.com","subject":"[PATCH 1/2] t4131: modernize style","fromName":"Harshit Jain","fromEmail":"harshitjain1371999@gmail.com","sentAt":"2020-03-20T13:08:44Z","receivedAt":"2020-03-20T13:09:23Z","isPatch":true,"sender":{"key":"harshitjain1371999@gmail.com","avatar":null},"body":"The tests in t4131 leave a space character between the redirection operator\nand the file i.e. the redirection target which does not conform to the\nmodern coding style.\n\nFix them.\n\nSigned-off-by: Harshit Jain \n---\n t/t4131-apply-fake-ancestor.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t4131-apply-fake-ancestor.sh b/t/t4131-apply-fake-ancestor.sh\nindex b1361ce546..828d1a355b 100755\n--- a/t/t4131-apply-fake-ancestor.sh\n+++ b/t/t4131-apply-fake-ancestor.sh\n@@ -17,8 +17,8 @@ test_expect_success 'setup' '\n \n test_expect_success 'apply --build-fake-ancestor' '\n \tgit checkout 2 &&\n-\techo \"A\" > 1.t &&\n-\tgit diff > 1.patch &&\n+\techo \"A\" >1.t &&\n+\tgit diff >1.patch &&\n \tgit reset --hard &&\n \tgit checkout 1 &&\n \tgit apply --build-fake-ancestor 1.ancestor 1.patch\n@@ -26,8 +26,8 @@ test_expect_success 'apply --build-fake-ancestor' '\n \n test_expect_success 'apply --build-fake-ancestor in a subdirectory' '\n \tgit checkout 3 &&\n-\techo \"C\" > sub/3.t &&\n-\tgit diff > 3.patch &&\n+\techo \"C\" >sub/3.t &&\n+\tgit diff >3.patch &&\n \tgit reset --hard &&\n \tgit checkout 4 &&\n \t(\n-- \n2.26.0.rc2\n\n"},{"id":"393528","messageId":"20200320130845.23257-3-harshitjain1371999@gmail.com","threadId":"53031","inReplyTo":"20200320130845.23257-1-harshitjain1371999@gmail.com","subject":"[PATCH 2/2] t4131: use helper function to replace 'test -f'","fromName":"Harshit Jain","fromEmail":"harshitjain1371999@gmail.com","sentAt":"2020-03-20T13:08:45Z","receivedAt":"2020-03-20T13:09:28Z","isPatch":true,"sender":{"key":"harshitjain1371999@gmail.com","avatar":null},"body":"Replace 'test -f' with the helper function 'test_path_is_file' as the\nhelper function improves the code readability and also gives better\nerror messages.\n\nSigned-off-by: Harshit Jain \n---\n t/t4131-apply-fake-ancestor.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4131-apply-fake-ancestor.sh b/t/t4131-apply-fake-ancestor.sh\nindex 828d1a355b..21ee359632 100755\n--- a/t/t4131-apply-fake-ancestor.sh\n+++ b/t/t4131-apply-fake-ancestor.sh\n@@ -33,7 +33,7 @@ test_expect_success 'apply --build-fake-ancestor in a subdirectory' '\n \t(\n \t\tcd sub &&\n \t\tgit apply --build-fake-ancestor 3.ancestor ../3.patch &&\n-\t\ttest -f 3.ancestor\n+\t\ttest_path_is_file 3.ancestor\n \t) &&\n \tgit apply --build-fake-ancestor 3.ancestor 3.patch &&\n \ttest_cmp sub/3.ancestor 3.ancestor\n-- \n2.26.0.rc2\n\n"},{"id":"393532","messageId":"20200320153905.6156-1-shouryashukla.oo@gmail.com","threadId":"53031","inReplyTo":"555da203-0740-3d79-15cf-83c5a8d5dbae@gmail.com","subject":"Re: Re: RFC][Feature] submodule","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-03-20T15:39:05Z","receivedAt":"2020-03-20T15:39:14Z","isPatch":false,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"Hello Kaartic,\n\nApologies, I totally missed out on that.\n\nRegards,\nShourya Shukla\n"},{"id":"393534","messageId":"20200320154315.6746-1-shouryashukla.oo@gmail.com","threadId":"53031","inReplyTo":"xmqq1rpodn25.fsf@gitster.c.googlers.com","subject":"Re: Re: [GSoC][Patch]","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-03-20T15:43:15Z","receivedAt":"2020-03-20T15:43:26Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"Apologies, I totally missed that out for some reason. Silly me! :/\n"},{"id":"393536","messageId":"20200320155604.7854-1-shouryashukla.oo@gmail.com","threadId":"53031","inReplyTo":"20200320130845.23257-2-harshitjain1371999@gmail.com","subject":"Re: Re: [GSoC][Patch]","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-03-20T15:56:04Z","receivedAt":"2020-03-20T15:56:13Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"Hello Harshit,\n\n> The tests in t4131 leave a space character between the redirection operator\n> and the file i.e. the redirection target which does not conform to the\n> modern coding style.\n\n> Fix them.\n\nI think something like,\n\nThe tests in t4131 were written a long time ago and hence contain style violations\nsuch as an extra space between the redirection operator(>) and the redirection target.\nUpdate it to match the latest CodingGuidelines.\n\nmay be better.\n\nAlso, when you deliver a newer version of the patch, i.e., version 2 in your case,\nyou have a [PATCH v2 1/n] as the subject, so that people know that it is the v2 and\nhence avoid confusion.\n\nIf you are using 'git format-patch' to formulate your mails, you can do:\n\n'git format-patch -v2 <..>' to get a v2 based mail.\n\nRegards,\nShourya Shukla\n\n"},{"id":"393541","messageId":"CACuU+s-s2zMJq5xymyTz45AVyT0gL1sgcpk3rUcA-Bp-D+F=2g@mail.gmail.com","threadId":"53031","inReplyTo":"20200320155604.7854-1-shouryashukla.oo@gmail.com","subject":"Re: Re: [GSoC][Patch]","fromName":"Harshit Jain","fromEmail":"harshitjain1371999@gmail.com","sentAt":"2020-03-20T17:14:09Z","receivedAt":"2020-03-20T17:14:27Z","isPatch":true,"sender":{"key":"harshitjain1371999@gmail.com","avatar":null},"body":"Hi Shourya,\n\nOn Fri, Mar 20, 2020 at 9:26 PM Shourya Shukla\n wrote:\n>\n> Hello Harshit,\n>\n> > The tests in t4131 leave a space character between the redirection operator\n> > and the file i.e. the redirection target which does not conform to the\n> > modern coding style.\n>\n> > Fix them.\n>\n> I think something like,\n>\n> The tests in t4131 were written a long time ago and hence contain style violations\n> such as an extra space between the redirection operator(>) and the redirection target.\n> Update it to match the latest CodingGuidelines.\n>\n> may be better.\n>\n\nPlease see the comment made by Junio Hamano, pasted below:\n\n\"written a long time ago\" does not have much value by itself (it\ndoes serve as a backstory to explain a half of why it does not use\nthe more modern style, though). \"have a few style violations.\" is\nalmost meaningless (otherwise, you would not be doing a \"modernize\nstyle\" patch in the first place ;-).\n\nI myself also agree with the above comment and hence, wrote the commit message\naccordingly. What do you think?\n\n> Also, when you deliver a newer version of the patch, i.e., version 2 in your case,\n> you have a [PATCH v2 1/n] as the subject, so that people know that it is the v2 and\n> hence avoid confusion.\n>\n> If you are using 'git format-patch' to formulate your mails, you can do:\n>\n> 'git format-patch -v2 <..>' to get a v2 based mail.\n>\n\nOh nice, didn't know about this. I will keep this in mind for future\npatch submissions.\nShould I do this for the current patch as well?\n\nRegards,\nHarshit Jain\n"}]}