{"thread":{"id":"52998","subject":"[PATCH] oidset: remove unnecessary include","startedAt":"2020-03-15T02:20:27Z","lastAt":"2020-03-16T19:28:56Z","messageCount":2,"participants":["Elijah Newren via GitGitGadget","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"393251","messageId":"pull.727.git.git.1584213347500.gitgitgadget@gmail.com","threadId":"52998","inReplyTo":null,"subject":"[PATCH] oidset: remove unnecessary include","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-03-14T19:15:47Z","receivedAt":"2020-03-15T02:20:27Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"From: Elijah Newren <newren@gmail.com>\n\nWhen commit 8b2f8cbcb1 (\"oidset: use khash\", 2018-10-04) moved from\nusing oidmap to khash, it replaced the oidmap.h include with both one\nfor hashmap.h and khash.h.  Since the hashmap.h header is unnecessary,\nand the point of the patch was to switch from hashmap (used by oidmap)\nto khash.h, remove the unneccessary include.\n\nSigned-off-by: Elijah Newren <newren@gmail.com>\n---\n    oidset: remove unnecessary include\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-727%2Fnewren%2Foidset-cleanup-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-727/newren/oidset-cleanup-v1\nPull-Request: https://github.com/git/git/pull/727\n\n oidset.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/oidset.h b/oidset.h\nindex 5346563b0bc..d8a106b1275 100644\n--- a/oidset.h\n+++ b/oidset.h\n@@ -1,7 +1,6 @@\n #ifndef OIDSET_H\n #define OIDSET_H\n \n-#include \"hashmap.h\"\n #include \"khash.h\"\n \n /**\n\nbase-commit: 30e9940356dc67959877f4b2417da33ebdefbb79\n-- \ngitgitgadget\n"},{"id":"393326","messageId":"20200316192852.GC1073710@coredump.intra.peff.net","threadId":"52998","inReplyTo":"pull.727.git.git.1584213347500.gitgitgadget@gmail.com","subject":"Re: [PATCH] oidset: remove unnecessary include","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-03-16T19:28:52Z","receivedAt":"2020-03-16T19:28:56Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Mar 14, 2020 at 07:15:47PM +0000, Elijah Newren via GitGitGadget wrote:\n\n> From: Elijah Newren <newren@gmail.com>\n> \n> When commit 8b2f8cbcb1 (\"oidset: use khash\", 2018-10-04) moved from\n> using oidmap to khash, it replaced the oidmap.h include with both one\n> for hashmap.h and khash.h.  Since the hashmap.h header is unnecessary,\n> and the point of the patch was to switch from hashmap (used by oidmap)\n> to khash.h, remove the unneccessary include.\n\nGood catch. I doubt this is causing problems, but it's obviously the\nright thing to do. I ran \"make hdr-check\" to confirm that no _other_\nheaders were subtly relying on this include.\n\n-Peff\n"}]}