{"thread":{"id":"52901","subject":"[PATCH] t5537: adjust test_oid label","startedAt":"2020-02-27T20:22:37Z","lastAt":"2020-03-04T16:45:41Z","messageCount":3,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"392637","messageId":"pull.717.git.git.1582834951742.gitgitgadget@gmail.com","threadId":"52901","inReplyTo":null,"subject":"[PATCH] t5537: adjust test_oid label","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-02-27T20:22:31Z","receivedAt":"2020-02-27T20:22:37Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nWe recently switched to using Perl instead of `sed` in the httpd-based\ntests. Let's reflect that in the label we give the corresponding commit\nhashes.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    Follow-up for \"ci: upgrade to the latest Azure Pipelines agent pools\"\n    \n    This is a companion patch for https://github.com/git/git/pull/714,\n    adding a patch that would not apply to maint but applies to master. It\n    is intended to be applied on top of the merge that pulls in the agent\n    pool upgrade (which in turn is intended to be applied on top of maint).\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-717%2Fdscho%2Fazure-pipelines-latest-pools-test_oid-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-717/dscho/azure-pipelines-latest-pools-test_oid-v1\nPull-Request: https://github.com/git/git/pull/717\n\n t/t5537-fetch-shallow.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh\nindex 4f10057e9f1..4f681dbbe11 100755\n--- a/t/t5537-fetch-shallow.sh\n+++ b/t/t5537-fetch-shallow.sh\n@@ -17,8 +17,8 @@ test_expect_success 'setup' '\n \tcommit 4 &&\n \tgit config --global transfer.fsckObjects true &&\n \ttest_oid_cache <<-EOF\n-\tsed sha1:s/0034shallow %s/0036unshallow %s/\n-\tsed sha256:s/004cshallow %s/004eunshallow %s/\n+\tperl sha1:s/0034shallow %s/0036unshallow %s/\n+\tperl sha256:s/004cshallow %s/004eunshallow %s/\n \tEOF\n '\n \n@@ -243,7 +243,7 @@ test_expect_success 'shallow fetches check connectivity before writing shallow f\n \t# with an empty packfile. This is done by refetching with a shorter\n \t# depth (to ensure that the packfile is empty), and overwriting the\n \t# shallow line in the response with the unshallow line we want.\n-\tprintf \"$(test_oid sed)\" \\\n+\tprintf \"$(test_oid perl)\" \\\n \t       \"$(git -C \"$REPO\" rev-parse HEAD)\" \\\n \t       \"$(git -C \"$REPO\" rev-parse HEAD^)\" \\\n \t       >\"$HTTPD_ROOT_PATH/one-time-perl\" &&\n\nbase-commit: 4ee93512ad4f5270d941006faa162586e2d45f7a\n-- \ngitgitgadget\n"},{"id":"392859","messageId":"pull.717.v2.git.git.1583337192946.gitgitgadget@gmail.com","threadId":"52901","inReplyTo":"pull.717.git.git.1582834951742.gitgitgadget@gmail.com","subject":"[PATCH v2] t5537: adjust test_oid label","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-03-04T15:53:12Z","receivedAt":"2020-03-04T15:53:20Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nWe recently switched to using Perl instead of `sed` in the httpd-based\ntests. Let's reflect that in the label we give the corresponding commit\nhashes.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    Follow-up for \"ci: upgrade to the latest Azure Pipelines agent pools\"\n    \n    This is a companion patch for https://github.com/git/git/pull/714,\n    adding a patch that would not apply to maint but applies to master. It\n    is intended to be applied on top of the merge that pulls in the agent\n    pool upgrade (which in turn is intended to be applied on top of maint).\n    \n    Changes since v1:\n    \n     * Rebased onto master, as it now has all the building blocks needed for\n       this.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-717%2Fdscho%2Fazure-pipelines-latest-pools-test_oid-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-717/dscho/azure-pipelines-latest-pools-test_oid-v2\nPull-Request: https://github.com/git/git/pull/717\n\nRange-diff vs v1:\n\n 1:  79ad5eaa75b ! 1:  a6e4e9cc6ad t5537: adjust test_oid label\n     @@ -30,4 +30,4 @@\n      +\tprintf \"$(test_oid perl)\" \\\n       \t       \"$(git -C \"$REPO\" rev-parse HEAD)\" \\\n       \t       \"$(git -C \"$REPO\" rev-parse HEAD^)\" \\\n     - \t       >\"$HTTPD_ROOT_PATH/one-time-perl\" &&\n     + \t       >\"$HTTPD_ROOT_PATH/one-time-sed\" &&\n\n\n t/t5537-fetch-shallow.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh\nindex 9e16512fe31..287d2c336be 100755\n--- a/t/t5537-fetch-shallow.sh\n+++ b/t/t5537-fetch-shallow.sh\n@@ -17,8 +17,8 @@ test_expect_success 'setup' '\n \tcommit 4 &&\n \tgit config --global transfer.fsckObjects true &&\n \ttest_oid_cache <<-EOF\n-\tsed sha1:s/0034shallow %s/0036unshallow %s/\n-\tsed sha256:s/004cshallow %s/004eunshallow %s/\n+\tperl sha1:s/0034shallow %s/0036unshallow %s/\n+\tperl sha256:s/004cshallow %s/004eunshallow %s/\n \tEOF\n '\n \n@@ -243,7 +243,7 @@ test_expect_success 'shallow fetches check connectivity before writing shallow f\n \t# with an empty packfile. This is done by refetching with a shorter\n \t# depth (to ensure that the packfile is empty), and overwriting the\n \t# shallow line in the response with the unshallow line we want.\n-\tprintf \"$(test_oid sed)\" \\\n+\tprintf \"$(test_oid perl)\" \\\n \t       \"$(git -C \"$REPO\" rev-parse HEAD)\" \\\n \t       \"$(git -C \"$REPO\" rev-parse HEAD^)\" \\\n \t       >\"$HTTPD_ROOT_PATH/one-time-sed\" &&\n\nbase-commit: 2f268890c2cd2f115424936bbee27f8269080e5e\n-- \ngitgitgadget\n"},{"id":"392865","messageId":"xmqq8skg5as2.fsf@gitster-ct.c.googlers.com","threadId":"52901","inReplyTo":"pull.717.v2.git.git.1583337192946.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] t5537: adjust test_oid label","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-03-04T16:45:33Z","receivedAt":"2020-03-04T16:45:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" <gitgitgadget@gmail.com>\nwrites:\n\n> From: Johannes Schindelin <johannes.schindelin@gmx.de>\n>\n> We recently switched to using Perl instead of `sed` in the httpd-based\n> tests. Let's reflect that in the label we give the corresponding commit\n> hashes.\n>\n> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> ---\n>     Follow-up for \"ci: upgrade to the latest Azure Pipelines agent pools\"\n>     \n>     This is a companion patch for https://github.com/git/git/pull/714,\n>     adding a patch that would not apply to maint but applies to master. It\n>     is intended to be applied on top of the merge that pulls in the agent\n>     pool upgrade (which in turn is intended to be applied on top of maint).\n>     \n>     Changes since v1:\n>     \n>      * Rebased onto master, as it now has all the building blocks needed for\n>        this.\n\nA timely update that is very much appreciated.\n\nWill apply.  Thanks.\n\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-717%2Fdscho%2Fazure-pipelines-latest-pools-test_oid-v2\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-717/dscho/azure-pipelines-latest-pools-test_oid-v2\n> Pull-Request: https://github.com/git/git/pull/717\n>\n> Range-diff vs v1:\n>\n>  1:  79ad5eaa75b ! 1:  a6e4e9cc6ad t5537: adjust test_oid label\n>      @@ -30,4 +30,4 @@\n>       +\tprintf \"$(test_oid perl)\" \\\n>        \t       \"$(git -C \"$REPO\" rev-parse HEAD)\" \\\n>        \t       \"$(git -C \"$REPO\" rev-parse HEAD^)\" \\\n>      - \t       >\"$HTTPD_ROOT_PATH/one-time-perl\" &&\n>      + \t       >\"$HTTPD_ROOT_PATH/one-time-sed\" &&\n>\n>\n>  t/t5537-fetch-shallow.sh | 6 +++---\n>  1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh\n> index 9e16512fe31..287d2c336be 100755\n> --- a/t/t5537-fetch-shallow.sh\n> +++ b/t/t5537-fetch-shallow.sh\n> @@ -17,8 +17,8 @@ test_expect_success 'setup' '\n>  \tcommit 4 &&\n>  \tgit config --global transfer.fsckObjects true &&\n>  \ttest_oid_cache <<-EOF\n> -\tsed sha1:s/0034shallow %s/0036unshallow %s/\n> -\tsed sha256:s/004cshallow %s/004eunshallow %s/\n> +\tperl sha1:s/0034shallow %s/0036unshallow %s/\n> +\tperl sha256:s/004cshallow %s/004eunshallow %s/\n>  \tEOF\n>  '\n>  \n> @@ -243,7 +243,7 @@ test_expect_success 'shallow fetches check connectivity before writing shallow f\n>  \t# with an empty packfile. This is done by refetching with a shorter\n>  \t# depth (to ensure that the packfile is empty), and overwriting the\n>  \t# shallow line in the response with the unshallow line we want.\n> -\tprintf \"$(test_oid sed)\" \\\n> +\tprintf \"$(test_oid perl)\" \\\n>  \t       \"$(git -C \"$REPO\" rev-parse HEAD)\" \\\n>  \t       \"$(git -C \"$REPO\" rev-parse HEAD^)\" \\\n>  \t       >\"$HTTPD_ROOT_PATH/one-time-sed\" &&\n>\n> base-commit: 2f268890c2cd2f115424936bbee27f8269080e5e\n"}]}