{"thread":{"id":"52873","subject":"gitk feature requests: (1) \"diff.orderFile\" and (2) \"--function-context\"","startedAt":"2020-02-23T15:06:29Z","lastAt":"2020-02-23T15:06:29Z","messageCount":1,"participants":["Laszlo Ersek"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"392357","messageId":"d972c1f1-c49a-f644-ab1c-6a3e26c43ee3@redhat.com","threadId":"52873","inReplyTo":null,"subject":"gitk feature requests: (1) \"diff.orderFile\" and (2) \"--function-context\"","fromName":"Laszlo Ersek","fromEmail":"lersek@redhat.com","sentAt":"2020-02-23T15:06:19Z","receivedAt":"2020-02-23T15:06:29Z","isPatch":false,"sender":{"key":"lersek@redhat.com","avatar":null},"body":"Hello,\n\nas of commit c1a63459ed73 (\"gitk: Preserve window dimensions on exit\nwhen not using ttk themes\", 2019-12-15), gitk seems to lack two features\nthat I consider \"killer\" ones, for reviewing patches (including my own\npatches, of course):\n\n- support for the \"--function-context\" (\"-W\") option,\n- support for the \"-O<orderfile>\" (aka \"diff.orderFile\") setting.\n\nThese flags are in fact mentioned in the gitk source code, going back to\nhistorical commit ee66e089c1d4 (\"gitk: Make updates go faster\", 2008-05-09).\n\nThe options are stashed in vdflags($n), and then summarily ignored. A\ncomment says, \"These request or affect diff output, which we don't\nwant\", and I don't understand why; I would very much like them, please :)\n\nWhy I'm not proposing patches myself: my knowledge of Tcl/Tk is weaker\nthan my knowledge of Perl. My knowledge of Perl is... well, let's change\nthe topic. :) I have basically zero idea what \"gitk\" source does, for\nthe most part.\n\nCould someone please write gitk patches for honoring \"diff.orderFile\"\nand \"--function-context\"?\n\nAccepting \"--find-copies-harder\" too would be the icing on the cake.\n\nThank you!\nLaszlo\n\n"}]}