{"thread":{"id":"5287","subject":"[PATCH] gitweb: Show project's git URL on summary page","startedAt":"2006-08-15T18:03:05Z","lastAt":"2006-08-17T09:31:23Z","messageCount":10,"participants":["Jakub Narebski","David Rientjes","Aneesh Kumar K.V","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"25372","messageId":"200608152003.05693.jnareb@gmail.com","threadId":"5287","inReplyTo":null,"subject":"[PATCH] gitweb: Show project's git URL on summary page","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-15T18:03:05Z","receivedAt":"2006-08-15T18:03:05Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Add support for showing multiple clone/fetch git URLs for project on\na summary page. URL for project is created from base URL and project\nname.\n\nFor example for XMMS2 project (xmms.se) the git base URL would be\ngit://git.xmms.se/xmms2.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nThis probably could be combined with Aneesh Kumar patches \n  \"[PATCH] gitweb: Add support for cloneurl.\"\n  \"[PATCH] gitweb: Support multiple clone urls\"\nwhich reads from clone/fetch URLs from $GIT_DIR/cloneurl file,\ni.e. from $projectroot/$project/cloneurl file.  Default would be to\nuse base URL from @git_base_url_list, and if there is cloneurl file\nfor a project, use it instead.\n\nI'm not so sure of benefits of yet another way to provide\nclone/fetch URL, namely Yasushi SHOJI\n  \"[PATCH] gitweb: configurable home link string\"\n\nThis patch is port (with improvements) of Sham Chukoury patch\n  \"Show project tree git url on summary page\" (8e327dfbd)\nfor gitweb-xmms2. Should I add below line to commit message?\n\nSigned-off-by: Sham Chukoury <eleusis@xmms.org>\n\n\n Makefile           |    2 ++\n gitweb/gitweb.perl |   18 ++++++++++++++++--\n 2 files changed, 18 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex a538710..ae77d99 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -125,6 +125,7 @@ # default configuration for gitweb\n GITWEB_CONFIG = gitweb_config.perl\n GITWEB_SITENAME =\n GITWEB_PROJECTROOT = /pub/git\n+GITWEB_BASE_URL =\n GITWEB_LIST =\n GITWEB_HOMETEXT = indextext.html\n GITWEB_CSS = gitweb.css\n@@ -619,6 +620,7 @@ gitweb/gitweb.cgi: gitweb/gitweb.perl\n \t    -e 's|++GITWEB_CONFIG++|$(GITWEB_CONFIG)|g' \\\n \t    -e 's|++GITWEB_SITENAME++|$(GITWEB_SITENAME)|g' \\\n \t    -e 's|++GITWEB_PROJECTROOT++|$(GITWEB_PROJECTROOT)|g' \\\n+\t    -e 's|++GITWEB_BASE_URL++|$(GITWEB_BASE_URL)|g' \\\n \t    -e 's|++GITWEB_LIST++|$(GITWEB_LIST)|g' \\\n \t    -e 's|++GITWEB_HOMETEXT++|$(GITWEB_HOMETEXT)|g' \\\n \t    -e 's|++GITWEB_CSS++|$(GITWEB_CSS)|g' \\\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex ab28caa..6dcf6a2 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -51,6 +51,10 @@ our $logo = \"++GITWEB_LOGO++\";\n # source of projects list\n our $projects_list = \"++GITWEB_LIST++\";\n \n+# list of git base URLs used for URL to where fetch project from,\n+# i.e. full URL is \"$git_base_url/$project\"\n+our @git_base_url_list = (\"++GIT_BASE_URL++\");\n+\n # default blob_plain mimetype and default charset for text/plain blob\n our $default_blob_plain_mimetype = 'text/plain';\n our $default_text_plain_charset  = undef;\n@@ -1665,8 +1669,18 @@ sub git_summary {\n \tprint \"<table cellspacing=\\\"0\\\">\\n\" .\n \t      \"<tr><td>description</td><td>\" . esc_html($descr) . \"</td></tr>\\n\" .\n \t      \"<tr><td>owner</td><td>$owner</td></tr>\\n\" .\n-\t      \"<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\\n\" .\n-\t      \"</table>\\n\";\n+\t      \"<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\\n\";\n+\tmy $is_first_url = 1;\n+\tforeach my $git_base_url (@git_base_url_list) {\n+\t\tnext unless $git_base_url; # skip empty/zerolength URLs\n+\t\tprint \"<tr><td>\";\n+\t\tif ($is_first_url) {\n+\t\t\tprint \"URL\";\n+\t\t\t$is_first_url = 0;\n+\t\t}\n+\t\tprint \"</td><td>$git_base_url/$project</td></tr>\\n\";\n+\t}\n+\tprint \"</table>\\n\";\n \n \topen my $fd, \"-|\", $GIT, \"rev-list\", \"--max-count=17\", git_get_head_hash($project)\n \t\tor die_error(undef, \"Open git-rev-list failed\");\n-- \n1.4.1.1\n"},{"id":"25373","messageId":"Pine.LNX.4.63.0608151139280.29668@chino.corp.google.com","threadId":"5287","inReplyTo":"200608152003.05693.jnareb@gmail.com","subject":"Re: [PATCH] gitweb: Show project's git URL on summary page","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-15T18:43:04Z","receivedAt":"2006-08-15T18:43:04Z","isPatch":true,"sender":{"key":"rientjes@google.com","avatar":null},"body":"On Tue, 15 Aug 2006, Jakub Narebski wrote:\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index ab28caa..6dcf6a2 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -51,6 +51,10 @@ our $logo = \"++GITWEB_LOGO++\";\n>  # source of projects list\n>  our $projects_list = \"++GITWEB_LIST++\";\n>  \n> +# list of git base URLs used for URL to where fetch project from,\n> +# i.e. full URL is \"$git_base_url/$project\"\n> +our @git_base_url_list = (\"++GIT_BASE_URL++\");\n> +\n>  # default blob_plain mimetype and default charset for text/plain blob\n>  our $default_blob_plain_mimetype = 'text/plain';\n>  our $default_text_plain_charset  = undef;\n> @@ -1665,8 +1669,18 @@ sub git_summary {\n>  \tprint \"<table cellspacing=\\\"0\\\">\\n\" .\n>  \t      \"<tr><td>description</td><td>\" . esc_html($descr) . \"</td></tr>\\n\" .\n>  \t      \"<tr><td>owner</td><td>$owner</td></tr>\\n\" .\n> -\t      \"<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\\n\" .\n> -\t      \"</table>\\n\";\n> +\t      \"<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\\n\";\n> +\tmy $is_first_url = 1;\n> +\tforeach my $git_base_url (@git_base_url_list) {\n> +\t\tnext unless $git_base_url; # skip empty/zerolength URLs\n> +\t\tprint \"<tr><td>\";\n> +\t\tif ($is_first_url) {\n> +\t\t\tprint \"URL\";\n> +\t\t\t$is_first_url = 0;\n> +\t\t}\n> +\t\tprint \"</td><td>$git_base_url/$project</td></tr>\\n\";\n> +\t}\n> +\tprint \"</table>\\n\";\n>  \n>  \topen my $fd, \"-|\", $GIT, \"rev-list\", \"--max-count=17\", git_get_head_hash($project)\n>  \t\tor die_error(undef, \"Open git-rev-list failed\");\n> \n\nIsn't it faster to do this (over 1.4.2):\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex b5b89de..82b246d 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -53,6 +53,7 @@ our $logo = \"++GITWEB_LOGO++\";\n \n # source of projects list\n our $projects_list = \"++GITWEB_LIST++\";\n+our @git_base_url_list = (\"++GIT_BASE_URL++\");\n \n # default blob_plain mimetype and default charset for text/plain blob\n our $default_blob_plain_mimetype = 'text/plain';\n@@ -1668,8 +1669,14 @@ sub git_summary {\n \tprint \"<table cellspacing=\\\"0\\\">\\n\" .\n \t      \"<tr><td>description</td><td>\" . esc_html($descr) . \"</td></tr>\\n\" .\n \t      \"<tr><td>owner</td><td>$owner</td></tr>\\n\" .\n-\t      \"<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\\n\" .\n-\t      \"</table>\\n\";\n+\t      \"<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\\n\";\n+\tmy $url_tag = \"URL\";\n+\tforeach my $git_base_url (@git_base_url_list) {\n+\t\tnext unless $git_base_url;\n+\t\tprint \"<tr><td>$url_tag</td><td>$git_base_url/$project</td></tr>\\n\";\n+\t\t$url_tag = \"\";\n+\t}\n+\tprint \"</table>\\n\";\n \n \topen my $fd, \"-|\", $GIT, \"rev-list\", \"--max-count=17\", git_get_head_hash($project)\n \t\tor die_error(undef, \"Open git-rev-list failed\");\n--\n\nAll the series of prints in this script could also probably more elegantly be \nwritten in the form:\n\nprint <<\"(END HTML)\";\n\t<table cellspacing=\"0\">\n\t\t...\n\t</table>\n\t<tr><td>last change</td><td>$cd{'rfc2822'}</td><tr>\n\t...\n(END HTML)\n\nand then all the escape characters around quotes aren't needed.\n\n\t\tDavid\n"},{"id":"25375","messageId":"8fe92b430608151232y3f0ecd8ei435337709557162e@mail.gmail.com","threadId":"5287","inReplyTo":"Pine.LNX.4.63.0608151139280.29668@chino.corp.google.com","subject":"Re: [PATCH] gitweb: Show project's git URL on summary page","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-15T19:32:08Z","receivedAt":"2006-08-15T19:32:08Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On 8/15/06, David Rientjes <rientjes@google.com> wrote:\n> On Tue, 15 Aug 2006, Jakub Narebski wrote:\n\n> > +     my $is_first_url = 1;\n> > +     foreach my $git_base_url (@git_base_url_list) {\n> > +             next unless $git_base_url; # skip empty/zerolength URLs\n> > +             print \"<tr><td>\";\n> > +             if ($is_first_url) {\n> > +                     print \"URL\";\n> > +                     $is_first_url = 0;\n> > +             }\n> > +             print \"</td><td>$git_base_url/$project</td></tr>\\n\";\n> > +     }\n>\n> Isn't it faster to do this (over 1.4.2):\n> +       my $url_tag = \"URL\";\n> +       foreach my $git_base_url (@git_base_url_list) {\n> +               next unless $git_base_url;\n> +               print \"<tr><td>$url_tag</td><td>$git_base_url/$project</td></tr>\\n\";\n> +               $url_tag = \"\";\n> +       }\n\nYes, it is undobtedly better.\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\n-- \nJakub Narebski\n"},{"id":"25383","messageId":"200608152303.17994.jnareb@gmail.com","threadId":"5287","inReplyTo":"200608152003.05693.jnareb@gmail.com","subject":"[PATCH (revised)] gitweb: Show project's git URL on summary page","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-15T21:03:17Z","receivedAt":"2006-08-15T21:03:17Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":">From 31e4de9f22a3b17d4ad0ac800132e4e1a0a15006 Mon Sep 17 00:00:00 2001\nFrom: David Rientjes <rientjes@google.com>\nDate: Tue, 15 Aug 2006 11:43:04 -0700\nSubject: [PATCH] gitweb: Show project's git URL on summary page\n\nAdd support for showing multiple clone/fetch git URLs for project on\na summary page. URL for project is created from base URL and project\nname.\n\nFor example for XMMS2 project (xmms.se) the git base URL would be\ngit://git.xmms.se/xmms2.\n\nWith corrections from David Rientjes <rientjes@google.com>\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n Makefile           |    2 ++\n gitweb/gitweb.perl |   14 ++++++++++++--\n 2 files changed, 14 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex a538710..ae77d99 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -125,6 +125,7 @@ # default configuration for gitweb\n GITWEB_CONFIG = gitweb_config.perl\n GITWEB_SITENAME =\n GITWEB_PROJECTROOT = /pub/git\n+GITWEB_BASE_URL =\n GITWEB_LIST =\n GITWEB_HOMETEXT = indextext.html\n GITWEB_CSS = gitweb.css\n@@ -619,6 +620,7 @@ gitweb/gitweb.cgi: gitweb/gitweb.perl\n \t    -e 's|++GITWEB_CONFIG++|$(GITWEB_CONFIG)|g' \\\n \t    -e 's|++GITWEB_SITENAME++|$(GITWEB_SITENAME)|g' \\\n \t    -e 's|++GITWEB_PROJECTROOT++|$(GITWEB_PROJECTROOT)|g' \\\n+\t    -e 's|++GITWEB_BASE_URL++|$(GITWEB_BASE_URL)|g' \\\n \t    -e 's|++GITWEB_LIST++|$(GITWEB_LIST)|g' \\\n \t    -e 's|++GITWEB_HOMETEXT++|$(GITWEB_HOMETEXT)|g' \\\n \t    -e 's|++GITWEB_CSS++|$(GITWEB_CSS)|g' \\\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex ab28caa..bce3a2a 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -51,6 +51,10 @@ our $logo = \"++GITWEB_LOGO++\";\n # source of projects list\n our $projects_list = \"++GITWEB_LIST++\";\n \n+# list of git base URLs used for URL to where fetch project from,\n+# i.e. full URL is \"$git_base_url/$project\"\n+our @git_base_url_list = (\"++GITWEB_BASE_URL++\");\n+\n # default blob_plain mimetype and default charset for text/plain blob\n our $default_blob_plain_mimetype = 'text/plain';\n our $default_text_plain_charset  = undef;\n@@ -1665,8 +1669,14 @@ sub git_summary {\n \tprint \"<table cellspacing=\\\"0\\\">\\n\" .\n \t      \"<tr><td>description</td><td>\" . esc_html($descr) . \"</td></tr>\\n\" .\n \t      \"<tr><td>owner</td><td>$owner</td></tr>\\n\" .\n-\t      \"<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\\n\" .\n-\t      \"</table>\\n\";\n+\t      \"<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\\n\";\n+\tmy $url_tag = \"URL\";\n+\tforeach my $git_base_url (@git_base_url_list) {\n+\t\tnext unless $git_base_url;\n+\t\tprint \"<tr><td>$url_tag</td><td>$git_base_url/$project</td></tr>\\n\";\n+\t\t$url_tag = \"\";\n+\t}\n+\tprint \"</table>\\n\";\n \n \topen my $fd, \"-|\", $GIT, \"rev-list\", \"--max-count=17\", git_get_head_hash($project)\n \t\tor die_error(undef, \"Open git-rev-list failed\");\n-- \n1.4.1.1\n"},{"id":"25385","messageId":"9ec263480608151436l4a31359erd9acb095247d9095@mail.google.com","threadId":"5287","inReplyTo":"200608152303.17994.jnareb@gmail.com","subject":"Re: [PATCH (revised)] gitweb: Show project's git URL on summary page","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-15T21:36:33Z","receivedAt":"2006-08-15T21:36:33Z","isPatch":true,"sender":{"key":"rientjes@google.com","avatar":null},"body":"On 8/15/06, Jakub Narebski <jnareb@gmail.com> wrote:\n> From 31e4de9f22a3b17d4ad0ac800132e4e1a0a15006 Mon Sep 17 00:00:00 2001\n> From: David Rientjes <rientjes@google.com>\n> Date: Tue, 15 Aug 2006 11:43:04 -0700\n> Subject: [PATCH] gitweb: Show project's git URL on summary page\n>\n> Add support for showing multiple clone/fetch git URLs for project on\n> a summary page. URL for project is created from base URL and project\n> name.\n>\n> For example for XMMS2 project (xmms.se) the git base URL would be\n> git://git.xmms.se/xmms2.\n>\n> With corrections from David Rientjes <rientjes@google.com>\n>\n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n\nSigned-off-by: David Rientjes <rientjes@google.com>\n"},{"id":"25407","messageId":"ebuhjn$kdm$1@sea.gmane.org","threadId":"5287","inReplyTo":"200608152303.17994.jnareb@gmail.com","subject":"Re: [PATCH (revised)] gitweb: Show project's git URL on summary page","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-08-16T07:31:01Z","receivedAt":"2006-08-16T07:31:01Z","isPatch":true,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"Jakub Narebski wrote:\n> From 31e4de9f22a3b17d4ad0ac800132e4e1a0a15006 Mon Sep 17 00:00:00 2001\n> From: David Rientjes <rientjes@google.com>\n> Date: Tue, 15 Aug 2006 11:43:04 -0700\n> Subject: [PATCH] gitweb: Show project's git URL on summary page\n> \n> Add support for showing multiple clone/fetch git URLs for project on\n> a summary page. URL for project is created from base URL and project\n> name.\n> \n> For example for XMMS2 project (xmms.se) the git base URL would be\n> git://git.xmms.se/xmms2.\n> \n> With corrections from David Rientjes <rientjes@google.com>\n>\n\nthis can give wrong value is some case with index.aux as projects_list. I have a setup where\nproject details are displayed via gitweb but not reachable via http:// url and some reachable via http:// url.\n\nFor the first one only ssh:// based clone mechanism will work and for the other both will work. How do we handle \nthat\n\n-aneesh\n"},{"id":"25414","messageId":"200608161450.35118.jnareb@gmail.com","threadId":"5287","inReplyTo":"200608152303.17994.jnareb@gmail.com","subject":"[PATCH 2/2] gitweb: Add support for per project git URLs","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-16T12:50:34Z","receivedAt":"2006-08-16T12:50:34Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"It is now possible for project to have individual clone/fetch URLs.\nThey are provided in new file 'cloneurl' added below project's\n$GIT_DIR directory.\n\nIf there is no cloneurl file, concatenation of git base URLs with\nproject name is used.\n\nThis is merge of Jakub Narebski and David Rientjes\n  gitweb: Show project's git URL on summary page\nwith Aneesh Kumar\n  gitweb: Add support for cloneurl.\n  gitweb: Support multiple clone urls\npatches.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\nSigned-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>\n---\nBased on previous patch.\n\n gitweb/gitweb.perl |   20 +++++++++++++++++---\n 1 files changed, 17 insertions(+), 3 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 37a6284..7c92ac3 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -533,6 +533,16 @@ sub git_get_project_description {\n \treturn $descr;\n }\n \n+sub git_get_project_url_list {\n+\tmy $path = shift;\n+\n+\topen my $fd, \"$projectroot/$path/cloneurl\" or return undef;\n+\tmy @git_project_url_list = map { chomp; $_ } <$fd>;\n+\tclose $fd;\n+\n+\treturn wantarray ? @git_project_url_list : \\@git_project_url_list;\n+}\n+\n sub git_get_projects_list {\n \tmy @list;\n \n@@ -1697,10 +1707,14 @@ sub git_summary {\n \t      \"<tr><td>description</td><td>\" . esc_html($descr) . \"</td></tr>\\n\" .\n \t      \"<tr><td>owner</td><td>$owner</td></tr>\\n\" .\n \t      \"<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\\n\";\n+\t# use per project git URL list in $projectroot/$project/cloneurl\n+\t# or make project git URL from git base URL and project name\n \tmy $url_tag = \"URL\";\n-\tforeach my $git_base_url (@git_base_url_list) {\n-\t\tnext unless $git_base_url;\n-\t\tprint \"<tr><td>$url_tag</td><td>$git_base_url/$project</td></tr>\\n\";\n+\tmy @url_list = git_get_project_url_list($project);\n+\t@url_list = map { \"$_/$project\" } @git_base_url_list unless @url_list;\n+\tforeach my $git_url (@url_list) {\n+\t\tnext unless $git_url;\n+\t\tprint \"<tr><td>$url_tag</td><td>$git_url</td></tr>\\n\";\n \t\t$url_tag = \"\";\n \t}\n \tprint \"</table>\\n\";\n-- \n1.4.1.1\n"},{"id":"25415","messageId":"ebv4jv$fj4$1@sea.gmane.org","threadId":"5287","inReplyTo":"ebuhjn$kdm$1@sea.gmane.org","subject":"Re: [PATCH (revised)] gitweb: Show project's git URL on summary page","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-16T12:56:22Z","receivedAt":"2006-08-16T12:56:22Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Aneesh Kumar K.V wrote:\n\n\n> this can give wrong value is some case with index.aux as projects_list. \n> I have a setup where project details are displayed via gitweb but not\n> reachable via http:// url and some reachable via http:// url. \n> \n> For the first one only ssh:// based clone mechanism will work and for \n> the other both will work. How do we handle that\n\nSee my \"[PATCH 2/2] gitweb: Add support for per project git URLs\" in this\nthread.\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"25426","messageId":"7vveos2z3y.fsf@assigned-by-dhcp.cox.net","threadId":"5287","inReplyTo":"200608161450.35118.jnareb@gmail.com","subject":"Re: [PATCH 2/2] gitweb: Add support for per project git URLs","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-16T20:40:33Z","receivedAt":"2006-08-16T20:40:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> It is now possible for project to have individual clone/fetch URLs.\n> They are provided in new file 'cloneurl' added below project's\n> $GIT_DIR directory.\n>\n> If there is no cloneurl file, concatenation of git base URLs with\n> project name is used.\n>\n> This is merge of Jakub Narebski and David Rientjes\n>   gitweb: Show project's git URL on summary page\n> with Aneesh Kumar\n>   gitweb: Add support for cloneurl.\n>   gitweb: Support multiple clone urls\n> patches.\n>\n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>\n\nI'll take this for now, but we might want to consider moving\n'description' and 'cloneurl' information to the config file to\nprevent cluttering.\n\n        gitweb.description\n        gitweb.giturl\n\nThe URL is not for cloning only, but also for fetch/pull, right?\n"},{"id":"25470","messageId":"ec1cvg$823$1@sea.gmane.org","threadId":"5287","inReplyTo":"7vveos2z3y.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 2/2] gitweb: Add support for per project git URLs","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-17T09:31:23Z","receivedAt":"2006-08-17T09:31:23Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Jakub Narebski <jnareb@gmail.com> writes:\n> \n>> It is now possible for project to have individual clone/fetch URLs.\n>> They are provided in new file 'cloneurl' added below project's\n>> $GIT_DIR directory.\n>>\n>> If there is no cloneurl file, concatenation of git base URLs with\n>> project name is used.\n>>\n>> This is merge of Jakub Narebski and David Rientjes\n>>   gitweb: Show project's git URL on summary page\n>> with Aneesh Kumar\n>>   gitweb: Add support for cloneurl.\n>>   gitweb: Support multiple clone urls\n>> patches.\n>>\n>> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>\n> \n> I'll take this for now, but we might want to consider moving\n> 'description' and 'cloneurl' information to the config file to\n> prevent cluttering.\n> \n>         gitweb.description\n>         gitweb.giturl\n> \n> The URL is not for cloning only, but also for fetch/pull, right?\n\nAs of now reading text file is faster than invoking git-repo-config...\nalthough reimplementing _reading_ part of git-repo-config in Perl should be\neasy...\n\ncloneurl name is leftover from Aneesh Kumar patch. \n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"}]}