{"thread":{"id":"52826","subject":"[PATCH] git-gui: add missing close bracket","startedAt":"2020-02-17T16:11:03Z","lastAt":"2020-02-18T17:32:18Z","messageCount":2,"participants":["Pratyush Yadav"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"391919","messageId":"20200217161056.10864-1-me@yadavpratyush.com","threadId":"52826","inReplyTo":null,"subject":"[PATCH] git-gui: add missing close bracket","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2020-02-17T16:10:56Z","receivedAt":"2020-02-17T16:11:03Z","isPatch":true,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"In d9c6469 (git-gui: update status bar to track operations, 2019-12-01),\nthe status bar was refactored to allow multiple overlapping operations.\n\nSince the refactor changed the status bar interface, all callsites had\nto be refactored to use the new interface. During that refactoring, this\nclosing bracket was missed. This leads to an error message popping up\nwhen doing 'Branch->Reset...'.\n\nSigned-off-by: Pratyush Yadav <me@yadavpratyush.com>\n---\nReported at https://github.com/prati0100/git-gui/issues/28\n\n lib/merge.tcl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/lib/merge.tcl b/lib/merge.tcl\nindex 8df8ffa..664803c 100644\n--- a/lib/merge.tcl\n+++ b/lib/merge.tcl\n@@ -244,7 +244,7 @@ Continue with resetting the current changes?\"]\n \t\tset status_bar_operation [$::main_status \\\n \t\t\tstart \\\n \t\t\t[mc \"Aborting\"] \\\n-\t\t\t[mc \"files reset\"]\n+\t\t\t[mc \"files reset\"]]\n \t\tfileevent $fd readable [namespace code [list \\\n \t\t\t_reset_wait $fd $status_bar_operation]]\n \t} else {\n--\n2.21.1\n\n"},{"id":"391995","messageId":"20200218173209.zxv2uwym7xba4enw@yadavpratyush.com","threadId":"52826","inReplyTo":"20200217161056.10864-1-me@yadavpratyush.com","subject":"Re: [PATCH] git-gui: add missing close bracket","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2020-02-18T17:32:09Z","receivedAt":"2020-02-18T17:32:18Z","isPatch":true,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"On 17/02/20 09:40PM, Pratyush Yadav wrote:\n> In d9c6469 (git-gui: update status bar to track operations, 2019-12-01),\n> the status bar was refactored to allow multiple overlapping operations.\n> \n> Since the refactor changed the status bar interface, all callsites had\n> to be refactored to use the new interface. During that refactoring, this\n> closing bracket was missed. This leads to an error message popping up\n> when doing 'Branch->Reset...'.\n> \n> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>\n\nMerged.\n\n-- \nRegards,\nPratyush Yadav\n"}]}