{"thread":{"id":"5281","subject":"A better way to inform about git clone url. [2de21fac9842650fceb3db68f15711e38fabc3c8]","startedAt":"2006-08-15T06:27:07Z","lastAt":"2006-08-15T17:23:37Z","messageCount":4,"participants":["Aneesh Kumar K.V","Jon Loeliger"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"25339","messageId":"ebrpfs$grn$1@sea.gmane.org","threadId":"5281","inReplyTo":null,"subject":"A better way to inform about git clone url. [2de21fac9842650fceb3db68f15711e38fabc3c8]","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-08-15T06:27:07Z","receivedAt":"2006-08-15T06:27:07Z","isPatch":false,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"http://gitweb.freedesktop.org/?p=PolicyKit.git;a=summary\n\nThis shows it in the URL part of each project. \n\n-aneesh \n"},{"id":"25357","messageId":"44E1DA0C.80602@gmail.com","threadId":"5281","inReplyTo":"ebrpfs$grn$1@sea.gmane.org","subject":"[PATCH] gitweb: Add support for cloneurl.","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-08-15T14:28:28Z","receivedAt":"2006-08-15T14:28:28Z","isPatch":true,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"Aneesh Kumar K.V wrote:\n> http://gitweb.freedesktop.org/?p=PolicyKit.git;a=summary\n> \n> This shows it in the URL part of each project.\n> -aneesh\n\n\nThe below patch implements the same. I am not sure whether the approach is the right one.\nTo see the results you can see \n\nhttp://git.openssi.org/~kvaneesh/gitweb.cgi\n\n-aneesh\n\n\n>From 87503bfc92210ab6791f7a15eba72682d60f74ca Mon Sep 17 00:00:00 2001\nSubject: [PATCH] gitweb: Add support for cloneurl.\n\nA new file cloneurl is added below .git directory for each project.\nThe contents of the file is displayed by gitweb as the url which\nneed to be used for git clone.\n\nSigned-off-by: Aneesh Kumar K.V \n---\n gitweb/gitweb.perl | 12 ++++++++++++\n 1 files changed, 12 insertions(+), 0 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex b5b89de..869c53e 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -503,6 +503,16 @@ sub git_get_project_description {\n \treturn $descr;\n }\n \n+sub git_get_project_cloneurl {\n+\tmy $path = shift;\n+\n+\topen my $fd, \"$projectroot/$path/cloneurl\" or return undef;\n+\tmy $descr = <$fd>;\n+\tclose $fd;\n+\tchomp $descr;\n+\treturn $descr;\n+}\n+\n sub git_get_projects_list {\n \tmy @list;\n \n@@ -1655,6 +1665,7 @@ sub git_project_list {\n sub git_summary {\n \tmy $descr = git_get_project_description($project) || \"none\";\n \tmy $head = git_get_head_hash($project);\n+\tmy $cloneurl = git_get_project_cloneurl($project) || \"none\";\n \tmy %co = parse_commit($head);\n \tmy %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'});\n \n@@ -1669,6 +1680,7 @@ sub git_summary {\n \t \"description\" . esc_html($descr) . \"\\n\" .\n \t \"owner$owner\\n\" .\n \t \"last change$cd{'rfc2822'}\\n\" .\n+\t \"URL$cloneurl\\n\" .\n \t \"\\n\";\n \n \topen my $fd, \"-|\", $GIT, \"rev-list\", \"--max-count=17\", git_get_head_hash($project)\n-- \n1.4.2.rc1.g83e1-dirty\n\n"},{"id":"25362","messageId":"1155659063.10054.65.camel@cashmere.sps.mot.com","threadId":"5281","inReplyTo":"ebrpfs$grn$1@sea.gmane.org","subject":"Re: A better way to inform about git clone url. [2de21fac9842650fceb3db68f15711e38fabc3c8]","fromName":"Jon Loeliger","fromEmail":"jdl@freescale.com","sentAt":"2006-08-15T16:24:23Z","receivedAt":"2006-08-15T16:24:23Z","isPatch":false,"sender":{"key":"jdl@jdl.com","avatar":"https://gravatar.com/avatar/75ce9a10b151acd2c28ec4ab2136dba7b2ff1634530bd04b155981a749d08a64?d=mp&s=160"},"body":"On Tue, 2006-08-15 at 01:27, Aneesh Kumar K.V wrote:\n> http://gitweb.freedesktop.org/?p=PolicyKit.git;a=summary\n> \n> This shows it in the URL part of each project. \n\nOh yes. ++Vote.\n\njdl\n"},{"id":"25369","messageId":"ebsvuq$de5$1@sea.gmane.org","threadId":"5281","inReplyTo":"1155659063.10054.65.camel@cashmere.sps.mot.com","subject":"[PATCH] gitweb: Support multiple clone urls","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-08-15T17:23:37Z","receivedAt":"2006-08-15T17:23:37Z","isPatch":true,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"This one is on top of the last one \n\n\n\n>From 135f502d7f47f58be5035f2cdb4896dd24adb852 Mon Sep 17 00:00:00 2001\ngitweb: Support multiple clone urls\n\nThis shows multiple urls if available for git clone\n\nSigned-off-by: Aneesh Kumar K.V \n---\n gitweb/gitweb.perl | 20 +++++++++++++-------\n 1 files changed, 13 insertions(+), 7 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 869c53e..501537f 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -505,12 +505,13 @@ sub git_get_project_description {\n \n sub git_get_project_cloneurl {\n \tmy $path = shift;\n+\tmy @cloneurls;\n \n \topen my $fd, \"$projectroot/$path/cloneurl\" or return undef;\n-\tmy $descr = <$fd>;\n+\t@cloneurls = <$fd>;\n \tclose $fd;\n-\tchomp $descr;\n-\treturn $descr;\n+\n+\treturn \\@cloneurls;\n }\n \n sub git_get_projects_list {\n@@ -1665,7 +1666,7 @@ sub git_project_list {\n sub git_summary {\n \tmy $descr = git_get_project_description($project) || \"none\";\n \tmy $head = git_get_head_hash($project);\n-\tmy $cloneurl = git_get_project_cloneurl($project) || \"none\";\n+\tmy $cloneurls = git_get_project_cloneurl($project);\n \tmy %co = parse_commit($head);\n \tmy %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'});\n \n@@ -1679,9 +1680,14 @@ sub git_summary {\n \tprint \"\\n\" .\n \t \"\\n\" .\n \t \"\\n\" .\n-\t \"\\n\" .\n-\t \"\\n\" .\n-\t \"
description\" . esc_html($descr) . \"
owner$owner
last change$cd{'rfc2822'}
URL$cloneurl
\\n\";\n+\t \"last change$cd{'rfc2822'}\\n\";\n+\n+\tmy $url;\n+\tforeach $url (@$cloneurls) {\n+\t\tchomp $url;\n+\t\tprint \"URL$url\\n\";\n+\t}\n+\tprint \"\\n\";\n \n \topen my $fd, \"-|\", $GIT, \"rev-list\", \"--max-count=17\", git_get_head_hash($project)\n \t\tor die_error(undef, \"Open git-rev-list failed\");\n-- \n1.4.2.rc1.g83e1-dirty\n\n"}]}