{"thread":{"id":"52801","subject":"[PATCH] t5580: test cloning without file://, test fetching via UNC paths","startedAt":"2020-02-13T21:51:48Z","lastAt":"2020-02-13T21:51:48Z","messageCount":1,"participants":["Johannes Schindelin via GitGitGadget"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"391703","messageId":"pull.143.git.1581630704704.gitgitgadget@gmail.com","threadId":"52801","inReplyTo":null,"subject":"[PATCH] t5580: test cloning without file://, test fetching via UNC paths","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-02-13T21:51:44Z","receivedAt":"2020-02-13T21:51:48Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nOn Windows, it is quite common to work with network drives. The format\nof the paths to network drives (or \"network shares\", or UNC paths) is:\n\n\t\\\\<server>\\<share>\\...\n\nWe already have a couple regression tests revolving around those types\nof paths, but we missed cloning and fetching from UNC paths without\nleading `file://` (and with backslashes instead of forward slashes).\nThis lil' patch closes that gap.\n\nIt gets a bit silly to add the commands to the name of the test script,\nso let's just rename it while we're testing more UNC stuff.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    Add more regression tests around fetching/cloning from UNC paths\n    \n    On Windows, we want to make sure that we can fetch and clone from\n    network drives. Let's add regression tests to make sure about that.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-143%2Fdscho%2Ftest-unc-fetch-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-143/dscho/test-unc-fetch-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/143\n\n t/{t5580-clone-push-unc.sh => t5580-unc-paths.sh} | 12 ++++++++++++\n 1 file changed, 12 insertions(+)\n rename t/{t5580-clone-push-unc.sh => t5580-unc-paths.sh} (89%)\n\ndiff --git a/t/t5580-clone-push-unc.sh b/t/t5580-unc-paths.sh\nsimilarity index 89%\nrename from t/t5580-clone-push-unc.sh\nrename to t/t5580-unc-paths.sh\nindex 01b52c195a..cf768b3a27 100755\n--- a/t/t5580-clone-push-unc.sh\n+++ b/t/t5580-unc-paths.sh\n@@ -40,11 +40,23 @@ test_expect_success clone '\n \tgit clone \"file://$UNCPATH\" clone\n '\n \n+test_expect_success 'clone without file://' '\n+\tgit clone \"$UNCPATH\" clone-without-file\n+'\n+\n test_expect_success 'clone with backslashed path' '\n \tBACKSLASHED=\"$(echo \"$UNCPATH\" | tr / \\\\\\\\)\" &&\n \tgit clone \"$BACKSLASHED\" backslashed\n '\n \n+test_expect_success fetch '\n+\tgit init to-fetch &&\n+\t(\n+\t\tcd to-fetch &&\n+\t\tgit fetch \"$UNCPATH\" master\n+\t)\n+'\n+\n test_expect_success push '\n \t(\n \t\tcd clone &&\n\nbase-commit: d8437c57fa0752716dde2d3747e7c22bf7ce2e41\n-- \ngitgitgadget\n"}]}