{"thread":{"id":"52793","subject":"Fwd: Re: [PATCH 0/5] object.c: localize global the_repository variable into r","startedAt":"2020-02-12T22:26:02Z","lastAt":"2020-02-12T22:26:02Z","messageCount":1,"participants":["parth gala"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"391626","messageId":"dac7264e-969d-259f-3d43-ac69a628d624@gmail.com","threadId":"52793","inReplyTo":"4cb3c2cc-b73d-0ea6-1f56-4c7a18d05532@gmail.com","subject":"Fwd: Re: [PATCH 0/5] object.c: localize global the_repository variable into r","fromName":"parth gala","fromEmail":"parthpgala@gmail.com","sentAt":"2020-02-12T22:25:57Z","receivedAt":"2020-02-12T22:26:02Z","isPatch":true,"sender":{"key":"parthpgala@gmail.com","avatar":null},"body":"\n\n\n-------- Forwarded Message --------\nSubject: \tRe: [PATCH 0/5] object.c: localize global the_repository \nvariable into r\nDate: \tThu, 13 Feb 2020 03:26:30 +0530\nFrom: \tparth gala <parthpgala@gmail.com>\nTo: \tTaylor Blau <me@ttaylorr.com>\n\n\n\n\nOn 13/02/20 1:48 am, Taylor Blau wrote:\n> Hi Parth,\n>\n> On Wed, Feb 12, 2020 at 07:19:06PM +0000, Parth Gala via GitGitGadget wrote:\n>> I have created this commit in response to\n>> https://github.com/gitgitgadget/git/issues/379#issue-503866117.\n> Fantastic! Thank you for working on this.\n>\n>> All the functions in object.c which relied on 'the_repository' have\n>> been modified.  The functions calling these functions in object.c\n>> consisted calls to other functions using 'the_repository' as well, and\n>> although I intended to use 'r' at all those instances, I thought it\n>> would make more sense when we would deal with their callee functions\n>> in another similar patch. What do you think ?\n> That makes sense, and follows the conventions that other similar\n> refactorings have done in the past.\n>\n> Any reason why you decided to start with 'object.c'? Not that any such\n> reason is necessary, I'm just curious about how you came to this\n> decision.\n\nI am new to the git community and while searching for issues to solve I\nfound the issue linked above.\nI figured solving it would give me a good experience navigating\nand exploring the huge repository.\n\nInitially I grepped to find all functions using `the_repository` but\nrandomly chose object.c since the refactoring had to start somewhere.\nSpecial thanks to Johannes Schindelin for this.\n\n>> Signed-off-by: Parth Gala parthpgala@gmail.com [parthpgala@gmail.com]\n> Even though you *do* need a 'Signed-off-by' in each of your patches,\n> adding it in the cover letter is not necessary.\n\nI probably did not check the preview I sent to myself carefully for\nthis. Will make note of it.\n\n>> Parth Gala (5):\n>>     object.c: get_max_object_index and get_indexed_object accept 'r'\n>>       parameter\n>>     object.c: lookup_unknown_object() accept 'r' as parameter\n>>     object.c: parse_object_or_die() accept 'r' as parameter\n>>     object.c: clear_object_flags() accept 'r' as parameter\n>>     object.c: clear_commit_marks_all() accept 'r' as parameter\n>>\n>>    builtin/checkout.c               |  3 ++-\n>>    builtin/fsck.c                   |  8 +++++---\n>>    builtin/grep.c                   |  6 ++++--\n>>    builtin/index-pack.c             |  5 +++--\n>>    builtin/log.c                    |  3 ++-\n>>    builtin/name-rev.c               |  5 +++--\n>>    builtin/pack-objects.c           |  3 ++-\n>>    builtin/prune.c                  |  3 ++-\n>>    bundle.c                         |  8 +++++---\n>>    http-push.c                      |  3 ++-\n>>    object.c                         | 32 ++++++++++++++++----------------\n>>    object.h                         | 12 ++++++------\n>>    pack-bitmap.c                    |  5 +++--\n>>    reachable.c                      |  6 ++++--\n>>    refs.c                           |  3 ++-\n>>    revision.c                       |  3 ++-\n>>    shallow.c                        | 13 ++++++++-----\n>>    t/helper/test-example-decorate.c |  7 ++++---\n>>    upload-pack.c                    | 19 ++++++++++++-------\n>>    walker.c                         |  3 ++-\n>>    20 files changed, 89 insertions(+), 61 deletions(-)\n>>\n>>\n>> base-commit: 0ad714499976290d9a0229230cbe4efae930b8dc\n>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-545%2FParthGala2k%2Flocalize-the_repository-variable-v1\n>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-545/ParthGala2k/localize-the_repository-variable-v1\n>> Pull-Request: https://github.com/gitgitgadget/git/pull/545\n>> --\n>> gitgitgadget\n> Thanks,\n> Taylor\n"}]}