{"thread":{"id":"5275","subject":"[PATCH 26/28] makes show_entry void","startedAt":"2006-08-14T20:39:27Z","lastAt":"2006-08-14T20:39:27Z","messageCount":1,"participants":["David Rientjes"],"isPatch":true,"patchVersion":1,"patchTotal":28},"messages":[{"id":"25307","messageId":"Pine.LNX.4.63.0608141338500.19383@chino.corp.google.com","threadId":"5275","inReplyTo":null,"subject":"[PATCH 26/28] makes show_entry void","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-14T20:39:27Z","receivedAt":"2006-08-14T20:39:27Z","isPatch":true,"sender":{"key":"rientjes@google.com","avatar":null},"body":"Makes show_entry void.\n\n\t\tDavid\n\nSigned-off-by: David Rientjes <rientjes@google.com>\n---\n tree-diff.c |   12 ++++++------\n 1 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/tree-diff.c b/tree-diff.c\nindex 1cdf8aa..916f489 100644\n--- a/tree-diff.c\n+++ b/tree-diff.c\n@@ -15,7 +15,8 @@ static char *malloc_base(const char *bas\n \treturn newbase;\n }\n \n-static int show_entry(struct diff_options *opt, const char *prefix, struct tree_desc *desc, const char *base);\n+static void show_entry(struct diff_options *opt, const char *prefix, struct tree_desc *desc,\n+\t\t       const char *base);\n \n static int compare_tree_entry(struct tree_desc *t1, struct tree_desc *t2, const char *base, struct diff_options *opt)\n {\n@@ -131,7 +132,8 @@ static void show_tree(struct diff_option\n }\n \n /* A file entry went away or appeared */\n-static int show_entry(struct diff_options *opt, const char *prefix, struct tree_desc *desc, const char *base)\n+static void show_entry(struct diff_options *opt, const char *prefix, struct tree_desc *desc,\n+\t\t       const char *base)\n {\n \tunsigned mode;\n \tconst char *path;\n@@ -152,11 +154,9 @@ static int show_entry(struct diff_option\n \n \t\tfree(tree);\n \t\tfree(newbase);\n-\t\treturn 0;\n+\t} else {\n+\t\topt->add_remove(opt, prefix[0], mode, sha1, base, path);\n \t}\n-\n-\topt->add_remove(opt, prefix[0], mode, sha1, base, path);\n-\treturn 0;\n }\n \n int diff_tree(struct tree_desc *t1, struct tree_desc *t2, const char *base, struct diff_options *opt)\n-- \n1.4.2.g89bb-dirty\n"}]}