{"thread":{"id":"5273","subject":"[PATCH 24/28] read-cache.c cleanup","startedAt":"2006-08-14T20:38:14Z","lastAt":"2006-08-14T20:38:14Z","messageCount":1,"participants":["David Rientjes"],"isPatch":true,"patchVersion":1,"patchTotal":28},"messages":[{"id":"25305","messageId":"Pine.LNX.4.63.0608141337420.19383@chino.corp.google.com","threadId":"5273","inReplyTo":null,"subject":"[PATCH 24/28] read-cache.c cleanup","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-14T20:38:14Z","receivedAt":"2006-08-14T20:38:14Z","isPatch":true,"sender":{"key":"rientjes@google.com","avatar":null},"body":"Removes conditional returns.\n\n\t\tDavid\n\nSigned-off-by: David Rientjes <rientjes@google.com>\n---\n read-cache.c |   10 +++-------\n 1 files changed, 3 insertions(+), 7 deletions(-)\n\ndiff --git a/read-cache.c b/read-cache.c\nindex c923a32..b18f9f7 100644\n--- a/read-cache.c\n+++ b/read-cache.c\n@@ -880,10 +880,8 @@ static int write_index_ext_header(SHA_CT\n {\n \text = htonl(ext);\n \tsz = htonl(sz);\n-\tif ((ce_write(context, fd, &ext, 4) < 0) ||\n-\t    (ce_write(context, fd, &sz, 4) < 0))\n-\t\treturn -1;\n-\treturn 0;\n+\treturn ((ce_write(context, fd, &ext, 4) < 0) ||\n+\t\t(ce_write(context, fd, &sz, 4) < 0)) ? -1 : 0;\n }\n \n static int ce_flush(SHA_CTX *context, int fd)\n@@ -905,9 +903,7 @@ static int ce_flush(SHA_CTX *context, in\n \t/* Append the SHA1 signature at the end */\n \tSHA1_Final(write_buffer + left, context);\n \tleft += 20;\n-\tif (write(fd, write_buffer, left) != left)\n-\t\treturn -1;\n-\treturn 0;\n+\treturn (write(fd, write_buffer, left) != left) ? -1 : 0;\n }\n \n static void ce_smudge_racily_clean_entry(struct cache_entry *ce)\n-- \n1.4.2.g89bb-dirty\n"}]}