{"thread":{"id":"52727","subject":"[PATCH] submodule foreach: replace $path with $sm_path in example","startedAt":"2020-01-31T17:08:53Z","lastAt":"2020-01-31T20:57:48Z","messageCount":2,"participants":["Kyle Meyer","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"390915","messageId":"20200131170843.11130-1-kyle@kyleam.com","threadId":"52727","inReplyTo":null,"subject":"[PATCH] submodule foreach: replace $path with $sm_path in example","fromName":"Kyle Meyer","fromEmail":"kyle@kyleam.com","sentAt":"2020-01-31T17:08:43Z","receivedAt":"2020-01-31T17:08:53Z","isPatch":true,"sender":{"key":"kyle@kyleam.com","avatar":"https://avatars.githubusercontent.com/u/1297788?v=4"},"body":"f0fd0dc5c5 (submodule foreach: document '$sm_path' instead of '$path',\n2018-05-08) updated the documentation to advise callers to favor\n$sm_path over the deprecated synonym $path.  However, the example in\nthat section still uses $path.  Update it to use $sm_path.\n\nSigned-off-by: Kyle Meyer <kyle@kyleam.com>\n---\n Documentation/git-submodule.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\nindex 5232407f68..218942acd1 100644\n--- a/Documentation/git-submodule.txt\n+++ b/Documentation/git-submodule.txt\n@@ -229,7 +229,7 @@ As an example, the command below will show the path and currently\n checked out commit for each submodule:\n +\n --------------\n-git submodule foreach 'echo $path `git rev-parse HEAD`'\n+git submodule foreach 'echo $sm_path `git rev-parse HEAD`'\n --------------\n \n sync [--recursive] [--] [<path>...]::\n-- \n2.25.0\n\n"},{"id":"390961","messageId":"xmqqblqj9we4.fsf@gitster-ct.c.googlers.com","threadId":"52727","inReplyTo":"20200131170843.11130-1-kyle@kyleam.com","subject":"Re: [PATCH] submodule foreach: replace $path with $sm_path in example","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-01-31T20:57:39Z","receivedAt":"2020-01-31T20:57:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kyle Meyer <kyle@kyleam.com> writes:\n\n> f0fd0dc5c5 (submodule foreach: document '$sm_path' instead of '$path',\n> 2018-05-08) updated the documentation to advise callers to favor\n> $sm_path over the deprecated synonym $path.  However, the example in\n> that section still uses $path.  Update it to use $sm_path.\n>\n> Signed-off-by: Kyle Meyer <kyle@kyleam.com>\n\nMakes sense.  Thanks for a careful reading.  Will apply.\n\n> ---\n>  Documentation/git-submodule.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\n> index 5232407f68..218942acd1 100644\n> --- a/Documentation/git-submodule.txt\n> +++ b/Documentation/git-submodule.txt\n> @@ -229,7 +229,7 @@ As an example, the command below will show the path and currently\n>  checked out commit for each submodule:\n>  +\n>  --------------\n> -git submodule foreach 'echo $path `git rev-parse HEAD`'\n> +git submodule foreach 'echo $sm_path `git rev-parse HEAD`'\n>  --------------\n>  \n>  sync [--recursive] [--] [<path>...]::\n"}]}