{"thread":{"id":"5269","subject":"[PATCH 20/28] makes fetch_pack void","startedAt":"2006-08-14T20:35:42Z","lastAt":"2006-08-14T20:35:42Z","messageCount":1,"participants":["David Rientjes"],"isPatch":true,"patchVersion":1,"patchTotal":28},"messages":[{"id":"25301","messageId":"Pine.LNX.4.63.0608141335050.19383@chino.corp.google.com","threadId":"5269","inReplyTo":null,"subject":"[PATCH 20/28] makes fetch_pack void","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-14T20:35:42Z","receivedAt":"2006-08-14T20:35:42Z","isPatch":true,"sender":{"key":"rientjes@google.com","avatar":null},"body":"Makes fetch_pack void and cleans up function calls.\n\n\t\tDavid\n\nSigned-off-by: David Rientjes <rientjes@google.com>\n---\n fetch-pack.c |   13 ++++++-------\n 1 files changed, 6 insertions(+), 7 deletions(-)\n\ndiff --git a/fetch-pack.c b/fetch-pack.c\nindex b7824db..f187636 100644\n--- a/fetch-pack.c\n+++ b/fetch-pack.c\n@@ -414,7 +414,7 @@ static int everything_local(struct ref *\n \treturn retval;\n }\n \n-static int fetch_pack(int fd[2], int nr_match, char **match)\n+static void fetch_pack(int fd[2], int nr_match, char **match)\n {\n \tstruct ref *ref;\n \tunsigned char sha1[20];\n@@ -460,12 +460,11 @@ static int fetch_pack(int fd[2], int nr_\n \t\t       sha1_to_hex(ref->old_sha1), ref->name);\n \t\tref = ref->next;\n \t}\n-\treturn 0;\n }\n \n int main(int argc, char **argv)\n {\n-\tint i, ret, nr_heads;\n+\tint i, nr_heads;\n \tchar *dest = NULL, **heads;\n \tint fd[2];\n \tpid_t pid;\n@@ -516,12 +515,12 @@ int main(int argc, char **argv)\n \tpid = git_connect(fd, dest, exec);\n \tif (pid < 0)\n \t\treturn 1;\n-\tret = fetch_pack(fd, nr_heads, heads);\n+\tfetch_pack(fd, nr_heads, heads);\n \tclose(fd[0]);\n \tclose(fd[1]);\n \tfinish_connect(pid);\n \n-\tif (!ret && nr_heads) {\n+\tif (nr_heads) {\n \t\t/* If the heads to pull were given, we should have\n \t\t * consumed all of them by matching the remote.\n \t\t * Otherwise, 'git-fetch remote no-such-ref' would\n@@ -530,9 +529,9 @@ int main(int argc, char **argv)\n \t\tfor (i = 0; i < nr_heads; i++)\n \t\t\tif (heads[i] && heads[i][0]) {\n \t\t\t\terror(\"no such remote ref %s\", heads[i]);\n-\t\t\t\tret = 1;\n+\t\t\t\treturn 1;\n \t\t\t}\n \t}\n \n-\treturn ret;\n+\treturn 0;\n }\n-- \n1.4.2.g89bb-dirty\n"}]}