{"thread":{"id":"5268","subject":"[PATCH 19/28] makes finish_pack void","startedAt":"2006-08-14T20:35:05Z","lastAt":"2006-08-14T20:35:05Z","messageCount":1,"participants":["David Rientjes"],"isPatch":true,"patchVersion":1,"patchTotal":28},"messages":[{"id":"25300","messageId":"Pine.LNX.4.63.0608141334170.19383@chino.corp.google.com","threadId":"5268","inReplyTo":null,"subject":"[PATCH 19/28] makes finish_pack void","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-14T20:35:05Z","receivedAt":"2006-08-14T20:35:05Z","isPatch":true,"sender":{"key":"rientjes@google.com","avatar":null},"body":"Makes finish_pack void and cleans up function calls.\n\n\t\tDavid\n\nSigned-off-by: David Rientjes <rientjes@google.com>\n---\n fetch-clone.c |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/fetch-clone.c b/fetch-clone.c\nindex 5e84c46..72750c4 100644\n--- a/fetch-clone.c\n+++ b/fetch-clone.c\n@@ -4,7 +4,7 @@ #include \"pkt-line.h\"\n #include <sys/wait.h>\n #include <sys/time.h>\n \n-static int finish_pack(const char *pack_tmp_name, const char *me)\n+static void finish_pack(const char *pack_tmp_name, const char *me)\n {\n \tint pipe_fd[2];\n \tpid_t pid;\n@@ -87,7 +87,6 @@ static int finish_pack(const char *pack_\n \t\t \"%s/pack/pack-%s.idx\", get_object_directory(), hash);\n \tmove_temp_to_file(idx, final);\n \tchmod(final, 0444);\n-\treturn 0;\n \n  error_die:\n \tunlink(idx);\n@@ -297,5 +296,6 @@ int receive_keep_pack(int xd[2], const c\n \t\t}\n \t}\n \tclose(ofd);\n-\treturn finish_pack(tmpfile, me);\n+\tfinish_pack(tmpfile, me);\n+\treturn 0;\n }\n-- \n1.4.2.g89bb-dirty\n"}]}