{"thread":{"id":"52663","subject":"Patchwork instance \"Submitter\" attribution and GitGitGadget","startedAt":"2020-01-18T18:51:16Z","lastAt":"2021-01-08T15:08:42Z","messageCount":6,"participants":["Philippe Blain","Johannes Schindelin","Junio C Hamano","Konstantin Ryabitsev"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"390059","messageId":"75987318-A9A7-4235-8B1D-315B29B644E8@gmail.com","threadId":"52663","inReplyTo":null,"subject":"Patchwork instance \"Submitter\" attribution and GitGitGadget","fromName":"Philippe Blain","fromEmail":"levraiphilippeblain@gmail.com","sentAt":"2020-01-18T18:51:10Z","receivedAt":"2020-01-18T18:51:16Z","isPatch":false,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"Hi Jonathan,\n\nI’ve noticed that all (I think) patch series sent to the list using Gitgitgadget are attributed to Dscho (Submitter is \"Johannes Schindelin via GitGitGadget\") on the patchwork instance [1]. I don’t know if you are aware of that or if there’s a way to fix it in patchwork…\n\nCheers,\nPhilippe.\n\n[1] https://patchwork.kernel.org/project/git/list/?submitter=182351"},{"id":"390073","messageId":"nycvar.QRO.7.76.6.2001201314580.46@tvgsbejvaqbjf.bet","threadId":"52663","inReplyTo":"75987318-A9A7-4235-8B1D-315B29B644E8@gmail.com","subject":"Re: Patchwork instance \"Submitter\" attribution and GitGitGadget","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2020-01-20T12:16:02Z","receivedAt":"2020-01-20T12:16:05Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Phillippe,\n\nOn Sat, 18 Jan 2020, Philippe Blain wrote:\n\n> I’ve noticed that all (I think) patch series sent to the list using\n> Gitgitgadget are attributed to Dscho (Submitter is \"Johannes Schindelin\n> via GitGitGadget\") on the patchwork instance [1]. I don’t know if you\n> are aware of that or if there’s a way to fix it in patchwork…\n\nRight now, it shows \"Lucius Hu via GitGitGadget\". Clearly, patchwork uses\nonly the email address as identifier, being unprepared to accept that the\nsame email address might be used by multiple contributors.\n\nCiao,\nDscho\n\n>\n> Cheers,\n> Philippe.\n>\n> [1] https://patchwork.kernel.org/project/git/list/?submitter=182351\n"},{"id":"390182","messageId":"xmqqiml4bsra.fsf@gitster-ct.c.googlers.com","threadId":"52663","inReplyTo":"nycvar.QRO.7.76.6.2001201314580.46@tvgsbejvaqbjf.bet","subject":"Re: Patchwork instance \"Submitter\" attribution and GitGitGadget","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-01-21T17:53:45Z","receivedAt":"2020-01-21T17:53:51Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> On Sat, 18 Jan 2020, Philippe Blain wrote:\n>\n>> I’ve noticed that all (I think) patch series sent to the list using\n>> Gitgitgadget are attributed to Dscho (Submitter is \"Johannes Schindelin\n>> via GitGitGadget\") on the patchwork instance [1]. I don’t know if you\n>> are aware of that or if there’s a way to fix it in patchwork…\n>\n> Right now, it shows \"Lucius Hu via GitGitGadget\". Clearly, patchwork uses\n> only the email address as identifier, being unprepared to accept that the\n> same email address might be used by multiple contributors.\n\nWould it help to use the \"Sender:\" header?  IIUC right now GGG\nrecords its name on \"From:\" with its e-mail and a human-readable\nname derived from the author of the ptach, but if it can record the\ntrue author on \"From:\" and leave GGG's name on the \"Sender:\", would\npatchwork use the \"From:\" side of the identity instead?\n\nIf that works, it would have an additional benefit of not having to\nadd the in-body \"From:\" to override the mail-header \"From:\", to avoid\nattributing the authorship to GGG.\n\n\n"},{"id":"413696","messageId":"nycvar.QRO.7.76.6.2101071534440.2213@tvgsbejvaqbjf.bet","threadId":"52663","inReplyTo":"xmqqiml4bsra.fsf@gitster-ct.c.googlers.com","subject":"Re: Patchwork instance \"Submitter\" attribution and GitGitGadget","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-01-07T14:35:54Z","receivedAt":"2021-01-07T14:37:56Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Tue, 21 Jan 2020, Junio C Hamano wrote:\n\n> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n>\n> > On Sat, 18 Jan 2020, Philippe Blain wrote:\n> >\n> >> I’ve noticed that all (I think) patch series sent to the list using\n> >> Gitgitgadget are attributed to Dscho (Submitter is \"Johannes Schindelin\n> >> via GitGitGadget\") on the patchwork instance [1]. I don’t know if you\n> >> are aware of that or if there’s a way to fix it in patchwork…\n> >\n> > Right now, it shows \"Lucius Hu via GitGitGadget\". Clearly, patchwork uses\n> > only the email address as identifier, being unprepared to accept that the\n> > same email address might be used by multiple contributors.\n>\n> Would it help to use the \"Sender:\" header?  IIUC right now GGG\n> records its name on \"From:\" with its e-mail and a human-readable\n> name derived from the author of the ptach, but if it can record the\n> true author on \"From:\" and leave GGG's name on the \"Sender:\", would\n> patchwork use the \"From:\" side of the identity instead?\n\nTo tie up that loose end: GMail seemed to insist in my tests on replacing\nthe `From:` header, therefore we cannot implement this `Sender:` idea, not\nusing GMail to deliver the GitGitGadget patch series at least.\n\nCiao,\nDscho\n\n> If that works, it would have an additional benefit of not having to\n> add the in-body \"From:\" to override the mail-header \"From:\", to avoid\n> attributing the authorship to GGG.\n>\n>\n>\n"},{"id":"413767","messageId":"20210107223755.6fg77xjdbqiscwb2@chatter.i7.local","threadId":"52663","inReplyTo":"nycvar.QRO.7.76.6.2101071534440.2213@tvgsbejvaqbjf.bet","subject":"Re: Patchwork instance \"Submitter\" attribution and GitGitGadget","fromName":"Konstantin Ryabitsev","fromEmail":"konstantin@linuxfoundation.org","sentAt":"2021-01-07T22:37:55Z","receivedAt":"2021-01-07T22:38:54Z","isPatch":false,"sender":{"key":"konstantin@linuxfoundation.org","avatar":"https://gravatar.com/avatar/7cb8827c6de56e1bd2dea16508c6708aa43feed3bf3813bcdacecdf96ceadd79?d=mp&s=160"},"body":"On Thu, Jan 07, 2021 at 03:35:54PM +0100, Johannes Schindelin wrote:\n> > Would it help to use the \"Sender:\" header?  IIUC right now GGG\n> > records its name on \"From:\" with its e-mail and a human-readable\n> > name derived from the author of the ptach, but if it can record the\n> > true author on \"From:\" and leave GGG's name on the \"Sender:\", would\n> > patchwork use the \"From:\" side of the identity instead?\n> \n> To tie up that loose end: GMail seemed to insist in my tests on replacing\n> the `From:` header, therefore we cannot implement this `Sender:` idea, not\n> using GMail to deliver the GitGitGadget patch series at least.\n\nCan you possibly set X-Original-From: in the header? Patchwork almost does the\nright thing with it, though right now it expects that the From: will be set to\nthe list's email address (which is only correct for google groups).\n\nWe have a workaround for the current situation on patchwork.kernel.org [1],\nbut it requires parsing the body of the message instead of just relying on the\nheaders.\n\n> > If that works, it would have an additional benefit of not having to\n> > add the in-body \"From:\" to override the mail-header \"From:\", to avoid\n> > attributing the authorship to GGG.\n\nUsing the in-body From: is both good and proper for such service. Trying to\nput the author's email into the actual From will run afoul of SPF.\n\n-K\n\n[1] https://git.kernel.org/pub/scm/infra/patchwork/procmail.git/tree/git.rc\n"},{"id":"413824","messageId":"nycvar.QRO.7.76.6.2101081604470.2213@tvgsbejvaqbjf.bet","threadId":"52663","inReplyTo":"20210107223755.6fg77xjdbqiscwb2@chatter.i7.local","subject":"Re: Patchwork instance \"Submitter\" attribution and GitGitGadget","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-01-08T15:07:03Z","receivedAt":"2021-01-08T15:08:42Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Konst,\n\nOn Thu, 7 Jan 2021, Konstantin Ryabitsev wrote:\n\n> On Thu, Jan 07, 2021 at 03:35:54PM +0100, Johannes Schindelin wrote:\n> > > Would it help to use the \"Sender:\" header?  IIUC right now GGG\n> > > records its name on \"From:\" with its e-mail and a human-readable\n> > > name derived from the author of the ptach, but if it can record the\n> > > true author on \"From:\" and leave GGG's name on the \"Sender:\", would\n> > > patchwork use the \"From:\" side of the identity instead?\n> >\n> > To tie up that loose end: GMail seemed to insist in my tests on replacing\n> > the `From:` header, therefore we cannot implement this `Sender:` idea, not\n> > using GMail to deliver the GitGitGadget patch series at least.\n>\n> Can you possibly set X-Original-From: in the header?\n\nPotentially. But unfortunately, I am too short on time to perform such\nexperiments right now. And it is always subject to the question what GMail\ndoes with this header in the future. `Sender:` used to work IIRC, but now\nit doesn't.\n\n> Patchwork almost does the right thing with it, though right now it\n> expects that the From: will be set to the list's email address (which is\n> only correct for google groups).\n>\n> We have a workaround for the current situation on patchwork.kernel.org [1],\n> but it requires parsing the body of the message instead of just relying on the\n> headers.\n>\n> > > If that works, it would have an additional benefit of not having to\n> > > add the in-body \"From:\" to override the mail-header \"From:\", to avoid\n> > > attributing the authorship to GGG.\n>\n> Using the in-body From: is both good and proper for such service. Trying to\n> put the author's email into the actual From will run afoul of SPF.\n\nIndeed.\n\nTherefore, I would prefer to keep doing that in GitGitGadget: send from\nits regular email address, and add the contributor's info in-body.\n\nCiao,\nJohannes\n\n>\n> -K\n>\n> [1] https://git.kernel.org/pub/scm/infra/patchwork/procmail.git/tree/git.rc\n>\n"}]}