{"thread":{"id":"5264","subject":"[PATCH 15/28] makes sha1flush void","startedAt":"2006-08-14T20:32:01Z","lastAt":"2006-08-14T20:32:01Z","messageCount":1,"participants":["David Rientjes"],"isPatch":true,"patchVersion":1,"patchTotal":28},"messages":[{"id":"25295","messageId":"Pine.LNX.4.63.0608141331160.19383@chino.corp.google.com","threadId":"5264","inReplyTo":null,"subject":"[PATCH 15/28] makes sha1flush void","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-14T20:32:01Z","receivedAt":"2006-08-14T20:32:01Z","isPatch":true,"sender":{"key":"rientjes@google.com","avatar":null},"body":"Makes sha1flush void and removes conditional return.\n\n\t\tDavid\n\nSigned-off-by: David Rientjes <rientjes@google.com>\n---\n combine-diff.c |    4 +---\n csum-file.c    |    4 ++--\n 2 files changed, 3 insertions(+), 5 deletions(-)\n\ndiff --git a/combine-diff.c b/combine-diff.c\nindex f2f3806..312035a 100644\n--- a/combine-diff.c\n+++ b/combine-diff.c\n@@ -9,9 +9,7 @@ #include \"log-tree.h\"\n \n static int uninteresting(struct diff_filepair *p)\n {\n-\tif (diff_unmodified_pair(p))\n-\t\treturn 1;\n-\treturn 0;\n+\treturn !!diff_unmodified_pair(p);\n }\n \n static struct combine_diff_path *intersect_paths(struct combine_diff_path *curr, int n, int num_parent)\ndiff --git a/csum-file.c b/csum-file.c\nindex 6a7b40f..e227889 100644\n--- a/csum-file.c\n+++ b/csum-file.c\n@@ -10,7 +10,7 @@\n #include \"cache.h\"\n #include \"csum-file.h\"\n \n-static int sha1flush(struct sha1file *f, unsigned int count)\n+static void sha1flush(struct sha1file *f, unsigned int count)\n {\n \tvoid *buf = f->buffer;\n \n@@ -21,7 +21,7 @@ static int sha1flush(struct sha1file *f,\n \t\t\tcount -= ret;\n \t\t\tif (count)\n \t\t\t\tcontinue;\n-\t\t\treturn 0;\n+\t\t\treturn;\n \t\t}\n \t\tif (!ret)\n \t\t\tdie(\"sha1 file '%s' write error. Out of diskspace\", f->name);\n-- \n1.4.2.g89bb-dirty\n"}]}