{"thread":{"id":"5261","subject":"PATCH [12/28] makes generate_tar void","startedAt":"2006-08-14T20:29:06Z","lastAt":"2006-08-14T20:29:06Z","messageCount":1,"participants":["David Rientjes"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"25292","messageId":"Pine.LNX.4.63.0608141328190.19383@chino.corp.google.com","threadId":"5261","inReplyTo":null,"subject":"PATCH [12/28] makes generate_tar void","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-14T20:29:06Z","receivedAt":"2006-08-14T20:29:06Z","isPatch":false,"sender":{"key":"rientjes@google.com","avatar":null},"body":"Makes generate_tar void and removes conditional return.\n\n\t\tDavid\n\nSigned-off-by: David Rientjes <rientjes@google.com>\n---\n builtin-tar-tree.c |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin-tar-tree.c b/builtin-tar-tree.c\nindex 215892b..42230f6 100644\n--- a/builtin-tar-tree.c\n+++ b/builtin-tar-tree.c\n@@ -308,7 +308,7 @@ int git_tar_config(const char *var, cons\n \treturn git_default_config(var, value);\n }\n \n-static int generate_tar(int argc, const char **argv, const char *prefix)\n+static void generate_tar(int argc, const char **argv, const char *prefix)\n {\n \tunsigned char sha1[20], tree_sha1[20];\n \tstruct commit *commit;\n@@ -354,7 +354,6 @@ static int generate_tar(int argc, const \n \twrite_trailer();\n \tfree(buffer);\n \tfree(current_path.buf);\n-\treturn 0;\n }\n \n static const char *exec = \"git-upload-tar\";\n@@ -409,7 +408,8 @@ int cmd_tar_tree(int argc, const char **\n \t\tusage(tar_tree_usage);\n \tif (!strncmp(\"--remote=\", argv[1], 9))\n \t\treturn remote_tar(argc, argv);\n-\treturn generate_tar(argc, argv, prefix);\n+\tgenerate_tar(argc, argv, prefix);\n+\treturn 0;\n }\n \n /* ustar header + extended global header content */\n-- \n1.4.2.g89bb-dirty\n"}]}