{"thread":{"id":"52595","subject":"[PATCH] config/advice.txt: fix description list separator","startedAt":"2020-01-08T20:10:00Z","lastAt":"2020-01-08T21:17:00Z","messageCount":2,"participants":["Martin Ågren","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"389502","messageId":"20200108200844.30803-1-martin.agren@gmail.com","threadId":"52595","inReplyTo":null,"subject":"[PATCH] config/advice.txt: fix description list separator","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2020-01-08T20:08:44Z","receivedAt":"2020-01-08T20:10:00Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"The whole submoduleAlternateErrorStrategyDie item is interpreted as\nbeing part of the supporting content of the preceding item. This is\nbecause we don't give a double-colon \"::\" for the separator, but just a\nsingle colon, \":\". Let's fix that.\n\nThere are a few other matches for [^:]:\\s*$ in Documentation/config, but\nI didn't spot any similar bugs among them.\n\nSigned-off-by: Martin Ågren <martin.agren@gmail.com>\n---\n This was the only thing that stood out at me while going through\n `./doc-diff v2.24.0 origin/master`. This is obviously a non-critical,\n purely cosmetic issue.\n\n Documentation/config/advice.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/config/advice.txt b/Documentation/config/advice.txt\nindex d4e698cd3f..4be93f8ad9 100644\n--- a/Documentation/config/advice.txt\n+++ b/Documentation/config/advice.txt\n@@ -107,7 +107,7 @@ advice.*::\n \t\teditor input from the user.\n \tnestedTag::\n \t\tAdvice shown if a user attempts to recursively tag a tag object.\n-\tsubmoduleAlternateErrorStrategyDie:\n+\tsubmoduleAlternateErrorStrategyDie::\n \t\tAdvice shown when a submodule.alternateErrorStrategy option\n \t\tconfigured to \"die\" causes a fatal error.\n --\n-- \n2.25.0.rc1.19.g042ed3e048\n\n"},{"id":"389505","messageId":"xmqqftgp1we0.fsf@gitster-ct.c.googlers.com","threadId":"52595","inReplyTo":"20200108200844.30803-1-martin.agren@gmail.com","subject":"Re: [PATCH] config/advice.txt: fix description list separator","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-01-08T21:16:55Z","receivedAt":"2020-01-08T21:17:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Ågren <martin.agren@gmail.com> writes:\n\n> The whole submoduleAlternateErrorStrategyDie item is interpreted as\n> being part of the supporting content of the preceding item. This is\n> because we don't give a double-colon \"::\" for the separator, but just a\n> single colon, \":\". Let's fix that.\n>\n> There are a few other matches for [^:]:\\s*$ in Documentation/config, but\n> I didn't spot any similar bugs among them.\n>\n> Signed-off-by: Martin Ågren <martin.agren@gmail.com>\n> ---\n>  This was the only thing that stood out at me while going through\n>  `./doc-diff v2.24.0 origin/master`. This is obviously a non-critical,\n>  purely cosmetic issue.\n\nThanks.  It still is a new bug introduced by a recent change, so I\nam tempted to include it in the final but it is a bit too late for\nthe -rc2 I planned to tag today.\n\n\n>\n>  Documentation/config/advice.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/config/advice.txt b/Documentation/config/advice.txt\n> index d4e698cd3f..4be93f8ad9 100644\n> --- a/Documentation/config/advice.txt\n> +++ b/Documentation/config/advice.txt\n> @@ -107,7 +107,7 @@ advice.*::\n>  \t\teditor input from the user.\n>  \tnestedTag::\n>  \t\tAdvice shown if a user attempts to recursively tag a tag object.\n> -\tsubmoduleAlternateErrorStrategyDie:\n> +\tsubmoduleAlternateErrorStrategyDie::\n>  \t\tAdvice shown when a submodule.alternateErrorStrategy option\n>  \t\tconfigured to \"die\" causes a fatal error.\n>  --\n"}]}