{"thread":{"id":"52578","subject":"[PATCH 0/1] [Outreachy] doc: fix a typo in gitcore-tutorial.txt","startedAt":"2020-01-07T10:05:57Z","lastAt":"2020-01-08T16:58:02Z","messageCount":8,"participants":["Heba Waly via GitGitGadget","Eric Sunshine","Junio C Hamano","Heba Waly"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"389344","messageId":"pull.515.git.1578391553.gitgitgadget@gmail.com","threadId":"52578","inReplyTo":null,"subject":"[PATCH 0/1] [Outreachy] doc: fix a typo in gitcore-tutorial.txt","fromName":"Heba Waly via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-01-07T10:05:52Z","receivedAt":"2020-01-07T10:05:57Z","isPatch":true,"sender":{"key":"heba.waly@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1539076?v=4"},"body":"Fix a typo.\n\nHeba Waly (1):\n doc: fix a typo in gitcore-tutorial.txt\n\n Documentation/gitcore-tutorial.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 8679ef24ed64018bb62170c43ce73e0261c0600a\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-515%2FHebaWaly%2Fgitcore_tutorial_typo-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-515/HebaWaly/gitcore_tutorial_typo-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/515\n-- \ngitgitgadget\n"},{"id":"389345","messageId":"ee8636e0ed40888b2a132cff2dacc97754550ba1.1578391553.git.gitgitgadget@gmail.com","threadId":"52578","inReplyTo":"pull.515.git.1578391553.gitgitgadget@gmail.com","subject":"[PATCH 1/1] doc: fix a typo in gitcore-tutorial.txt","fromName":"Heba Waly via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-01-07T10:05:53Z","receivedAt":"2020-01-07T10:05:58Z","isPatch":true,"sender":{"key":"heba.waly@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1539076?v=4"},"body":"From: Heba Waly \n\nSigned-off-by: Heba Waly \n---\n Documentation/gitcore-tutorial.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitcore-tutorial.txt b/Documentation/gitcore-tutorial.txt\nindex f880d21dfb..c0b95256cc 100644\n--- a/Documentation/gitcore-tutorial.txt\n+++ b/Documentation/gitcore-tutorial.txt\n@@ -751,7 +751,7 @@ to it.\n ================================================\n If you make the decision to start your new branch at some\n other point in the history than the current `HEAD`, you can do so by\n-just telling 'git checkout' what the base of the checkout would be.\n+just telling 'git switch' what the base of the checkout would be.\n In other words, if you have an earlier tag or branch, you'd just do\n \n ------------\n-- \ngitgitgadget\n"},{"id":"389355","messageId":"CAPig+cTv5SOxEjjVQ7QvqJ1WbZGbcXegcCP4d5CK+nSdJvkNdQ@mail.gmail.com","threadId":"52578","inReplyTo":"ee8636e0ed40888b2a132cff2dacc97754550ba1.1578391553.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] doc: fix a typo in gitcore-tutorial.txt","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2020-01-07T11:35:23Z","receivedAt":"2020-01-07T11:35:38Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Tue, Jan 7, 2020 at 5:06 AM Heba Waly via GitGitGadget\n wrote:\n> doc: fix a typo in gitcore-tutorial.txt\n>\n> Signed-off-by: Heba Waly \n> ---\n> diff --git a/Documentation/gitcore-tutorial.txt b/Documentation/gitcore-tutorial.txt\n> @@ -751,7 +751,7 @@ to it.\n> ================================================\n> If you make the decision to start your new branch at some\n> other point in the history than the current `HEAD`, you can do so by\n> -just telling 'git checkout' what the base of the checkout would be.\n> +just telling 'git switch' what the base of the checkout would be.\n\nCalling this change a \"typo fix\" confuses reviewers since it's clearly\nnot a mere typographical error. It looks instead as if you are\nrecommending git-switch over git-checkout, so a reader would expect\nthe commit message to justify that change rather than merely calling\nit a \"typo fix\". However, digging deeper, one finds that this is\nactually fixing an oversight from an earlier change which already\nupdated this file to prefer git-switch over git-checkout.\n\nTo save reviewers the time and effort of having to figure all this\nout, use the commit message to explain the situation. For example, you\nmight say:\n\n doc/gitcore-tutorial: fix prose to match example command\n\n In 328c6cb853 (doc: promote \"git switch\", 2019-03-29), an example\n was changed to use \"git switch\" rather than \"git checkout\" but an\n instance of \"git checkout\" in the explanatory text preceding the\n example was overlooked. Fix this oversight.\n"},{"id":"389419","messageId":"xmqq36cr599r.fsf@gitster-ct.c.googlers.com","threadId":"52578","inReplyTo":"CAPig+cTv5SOxEjjVQ7QvqJ1WbZGbcXegcCP4d5CK+nSdJvkNdQ@mail.gmail.com","subject":"Re: [PATCH 1/1] doc: fix a typo in gitcore-tutorial.txt","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-01-07T19:58:08Z","receivedAt":"2020-01-07T19:58:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Sunshine writes:\n\n> To save reviewers the time and effort of having to figure all this\n> out, use the commit message to explain the situation. For example, you\n> might say:\n>\n> doc/gitcore-tutorial: fix prose to match example command\n>\n> In 328c6cb853 (doc: promote \"git switch\", 2019-03-29), an example\n> was changed to use \"git switch\" rather than \"git checkout\" but an\n> instance of \"git checkout\" in the explanatory text preceding the\n> example was overlooked. Fix this oversight.\n\nThanks for a ncie educational session ;-)\n"},{"id":"389436","messageId":"CACg5j24A+g3_MFQvurd1Esy1s6A8W4VkLEWZjiP5WXxcTvqr-A@mail.gmail.com","threadId":"52578","inReplyTo":"CAPig+cTv5SOxEjjVQ7QvqJ1WbZGbcXegcCP4d5CK+nSdJvkNdQ@mail.gmail.com","subject":"Re: [PATCH 1/1] doc: fix a typo in gitcore-tutorial.txt","fromName":"Heba Waly","fromEmail":"heba.waly@gmail.com","sentAt":"2020-01-08T00:09:47Z","receivedAt":"2020-01-08T00:10:01Z","isPatch":true,"sender":{"key":"heba.waly@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1539076?v=4"},"body":"On Wed, Jan 8, 2020 at 12:35 AM Eric Sunshine wrote:\n>\n>\n> Calling this change a \"typo fix\" confuses reviewers since it's clearly\n> not a mere typographical error. It looks instead as if you are\n> recommending git-switch over git-checkout, so a reader would expect\n> the commit message to justify that change rather than merely calling\n> it a \"typo fix\". However, digging deeper, one finds that this is\n> actually fixing an oversight from an earlier change which already\n> updated this file to prefer git-switch over git-checkout.\n>\n> To save reviewers the time and effort of having to figure all this\n> out, use the commit message to explain the situation. For example, you\n> might say:\n>\n> doc/gitcore-tutorial: fix prose to match example command\n>\n> In 328c6cb853 (doc: promote \"git switch\", 2019-03-29), an example\n> was changed to use \"git switch\" rather than \"git checkout\" but an\n> instance of \"git checkout\" in the explanatory text preceding the\n> example was overlooked. Fix this oversight.\n\nLooks like I overlooked this commit for its simplicity, I thought it\nwas too simple and self explanatory. I agree with you though.\n\nThanks,\nHeba\n"},{"id":"389438","messageId":"pull.515.v2.git.1578443496.gitgitgadget@gmail.com","threadId":"52578","inReplyTo":"pull.515.git.1578391553.gitgitgadget@gmail.com","subject":"[PATCH v2 0/1] [Outreachy] doc/gitcore-tutorial: fix prose to match example command","fromName":"Heba Waly via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-01-08T00:31:35Z","receivedAt":"2020-01-08T00:31:41Z","isPatch":true,"sender":{"key":"heba.waly@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1539076?v=4"},"body":"In 328c6cb853 (doc: promote \"git switch\", 2019-03-29), an example was\nchanged to use \"git switch\" rather than \"git checkout\" but an instance of\n\"git checkout\" in the explanatory text preceding the example was overlooked.\nFix this oversight.\n\nHeba Waly (1):\n doc/gitcore-tutorial: fix prose to match example command\n\n Documentation/gitcore-tutorial.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 8679ef24ed64018bb62170c43ce73e0261c0600a\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-515%2FHebaWaly%2Fgitcore_tutorial_typo-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-515/HebaWaly/gitcore_tutorial_typo-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/515\n\nRange-diff vs v1:\n\n 1: ee8636e0ed ! 1: 0c75cd8f97 doc: fix a typo in gitcore-tutorial.txt\n @@ -1,6 +1,11 @@\n Author: Heba Waly \n \n - doc: fix a typo in gitcore-tutorial.txt\n + doc/gitcore-tutorial: fix prose to match example command\n +\n + In 328c6cb853 (doc: promote \"git switch\", 2019-03-29), an example\n + was changed to use \"git switch\" rather than \"git checkout\" but an\n + instance of \"git checkout\" in the explanatory text preceding the\n + example was overlooked. Fix this oversight.\n \n Signed-off-by: Heba Waly \n \n\n-- \ngitgitgadget\n"},{"id":"389439","messageId":"0c75cd8f9727b10af6f6a804177e551ba0217abf.1578443496.git.gitgitgadget@gmail.com","threadId":"52578","inReplyTo":"pull.515.v2.git.1578443496.gitgitgadget@gmail.com","subject":"[PATCH v2 1/1] doc/gitcore-tutorial: fix prose to match example command","fromName":"Heba Waly via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-01-08T00:31:36Z","receivedAt":"2020-01-08T00:31:43Z","isPatch":true,"sender":{"key":"heba.waly@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1539076?v=4"},"body":"From: Heba Waly \n\nIn 328c6cb853 (doc: promote \"git switch\", 2019-03-29), an example\nwas changed to use \"git switch\" rather than \"git checkout\" but an\ninstance of \"git checkout\" in the explanatory text preceding the\nexample was overlooked. Fix this oversight.\n\nSigned-off-by: Heba Waly \n---\n Documentation/gitcore-tutorial.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitcore-tutorial.txt b/Documentation/gitcore-tutorial.txt\nindex f880d21dfb..c0b95256cc 100644\n--- a/Documentation/gitcore-tutorial.txt\n+++ b/Documentation/gitcore-tutorial.txt\n@@ -751,7 +751,7 @@ to it.\n ================================================\n If you make the decision to start your new branch at some\n other point in the history than the current `HEAD`, you can do so by\n-just telling 'git checkout' what the base of the checkout would be.\n+just telling 'git switch' what the base of the checkout would be.\n In other words, if you have an earlier tag or branch, you'd just do\n \n ------------\n-- \ngitgitgadget\n"},{"id":"389484","messageId":"xmqqr2093my6.fsf@gitster-ct.c.googlers.com","threadId":"52578","inReplyTo":"0c75cd8f9727b10af6f6a804177e551ba0217abf.1578443496.git.gitgitgadget@gmail.com","subject":"Re: [PATCH v2 1/1] doc/gitcore-tutorial: fix prose to match example command","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-01-08T16:57:53Z","receivedAt":"2020-01-08T16:58:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Heba Waly via GitGitGadget\" writes:\n\n> From: Heba Waly \n>\n> In 328c6cb853 (doc: promote \"git switch\", 2019-03-29), an example\n> was changed to use \"git switch\" rather than \"git checkout\" but an\n> instance of \"git checkout\" in the explanatory text preceding the\n> example was overlooked. Fix this oversight.\n>\n> Signed-off-by: Heba Waly \n> ---\n> Documentation/gitcore-tutorial.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/gitcore-tutorial.txt b/Documentation/gitcore-tutorial.txt\n> index f880d21dfb..c0b95256cc 100644\n> --- a/Documentation/gitcore-tutorial.txt\n> +++ b/Documentation/gitcore-tutorial.txt\n> @@ -751,7 +751,7 @@ to it.\n> ================================================\n> If you make the decision to start your new branch at some\n> other point in the history than the current `HEAD`, you can do so by\n> -just telling 'git checkout' what the base of the checkout would be.\n> +just telling 'git switch' what the base of the checkout would be.\n> In other words, if you have an earlier tag or branch, you'd just do\n> \n> ------------\n\nThanks. The part before this paragraph does illustrate the use of\n\"switch\", and we should talk about that command here, too.\n\n"}]}