{"thread":{"id":"52573","subject":"[PATCH 0/1] doc: fixed a typo in git-submodule.txt","startedAt":"2020-01-06T14:50:18Z","lastAt":"2020-01-06T22:52:56Z","messageCount":5,"participants":["thomas menzel via GitGitGadget","elonderin via GitGitGadget","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"389262","messageId":"pull.688.git.git.1578322213.gitgitgadget@gmail.com","threadId":"52573","inReplyTo":null,"subject":"[PATCH 0/1] doc: fixed a typo in git-submodule.txt","fromName":"thomas menzel via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-01-06T14:50:12Z","receivedAt":"2020-01-06T14:50:18Z","isPatch":true,"sender":{"key":"dev@tomsit.de","avatar":null},"body":"fixed a typo in the doc of submodule\n\nelonderin (1):\n doc: submodule: fix typo for command absorbgitdirs\n\n Documentation/git-submodule.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 8679ef24ed64018bb62170c43ce73e0261c0600a\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-688%2Felonderin%2Fpatch-1-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-688/elonderin/patch-1-v1\nPull-Request: https://github.com/git/git/pull/688\n-- \ngitgitgadget\n"},{"id":"389263","messageId":"b032358ca97df3bd5605ff356196f82a1f16a320.1578322213.git.gitgitgadget@gmail.com","threadId":"52573","inReplyTo":"pull.688.git.git.1578322213.gitgitgadget@gmail.com","subject":"[PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs","fromName":"elonderin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-01-06T14:50:13Z","receivedAt":"2020-01-06T14:50:18Z","isPatch":true,"sender":{"key":"name:elonderin","avatar":null},"body":"From: elonderin <8225602+elonderin@users.noreply.github.com>\n\nThe sentence wants to talk about the superproject's possesive, not plural form.\n\nSigned-off-by: thomas menzel dev@tomsit.de\n---\n Documentation/git-submodule.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\nindex 22425cbc76..5232407f68 100644\n--- a/Documentation/git-submodule.txt\n+++ b/Documentation/git-submodule.txt\n@@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.\n \n absorbgitdirs::\n \tIf a git directory of a submodule is inside the submodule,\n-\tmove the git directory of the submodule into its superprojects\n+\tmove the git directory of the submodule into its superproject's\n \t`$GIT_DIR/modules` path and then connect the git directory and\n \tits working directory by setting the `core.worktree` and adding\n \ta .git file pointing to the git directory embedded in the\n-- \ngitgitgadget\n"},{"id":"389269","messageId":"xmqqlfqka4oe.fsf@gitster-ct.c.googlers.com","threadId":"52573","inReplyTo":"b032358ca97df3bd5605ff356196f82a1f16a320.1578322213.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-01-06T17:13:53Z","receivedAt":"2020-01-06T17:13:58Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"elonderin via GitGitGadget\" writes:\n\n> From: elonderin <8225602+elonderin@users.noreply.github.com>\n>\n> The sentence wants to talk about the superproject's possesive, not plural form.\n>\n> Signed-off-by: thomas menzel dev@tomsit.de\n\nThe author of the patch must sign-off, so the above three lines\nshould look more like so:\n\n\tFrom: Thomas Menzel \n\n\tThe sentence wants to talk about the superproject's\n\tpossesive, not plural form.\n\n\tFrom: Thomas Menzel \n\nThe content of the patch obviously is correct.\n\nThanks.\n\n> ---\n> Documentation/git-submodule.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\n> index 22425cbc76..5232407f68 100644\n> --- a/Documentation/git-submodule.txt\n> +++ b/Documentation/git-submodule.txt\n> @@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.\n> \n> absorbgitdirs::\n> \tIf a git directory of a submodule is inside the submodule,\n> -\tmove the git directory of the submodule into its superprojects\n> +\tmove the git directory of the submodule into its superproject's\n> \t`$GIT_DIR/modules` path and then connect the git directory and\n> \tits working directory by setting the `core.worktree` and adding\n> \ta .git file pointing to the git directory embedded in the\n"},{"id":"389270","messageId":"xmqqblrga4h1.fsf@gitster-ct.c.googlers.com","threadId":"52573","inReplyTo":"b032358ca97df3bd5605ff356196f82a1f16a320.1578322213.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-01-06T17:18:18Z","receivedAt":"2020-01-06T17:18:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"When anybody tries to respond to the quoted message [*1*] that came\nfrom GGG in the way recommended for the list, the\n*.noreply.github.com address gets placed on the Cc:, which is\nprobably not wanted.\n\nCan GGG do something about it? As GitHub specific service, it is\nnot wrong for it to know what noreply.github.com means so dropping\nsuch an address from its Cc: line shouldn't be too difficult.\n\nThanks.\n\n\nReference *1* \n\n\n\n\n\"elonderin via GitGitGadget\" writes:\n\n> From: elonderin <8225602+elonderin@users.noreply.github.com>\n>\n> The sentence wants to talk about the superproject's possesive, not plural form.\n>\n> Signed-off-by: thomas menzel dev@tomsit.de\n> ---\n> Documentation/git-submodule.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\n> index 22425cbc76..5232407f68 100644\n> --- a/Documentation/git-submodule.txt\n> +++ b/Documentation/git-submodule.txt\n> @@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.\n> \n> absorbgitdirs::\n> \tIf a git directory of a submodule is inside the submodule,\n> -\tmove the git directory of the submodule into its superprojects\n> +\tmove the git directory of the submodule into its superproject's\n> \t`$GIT_DIR/modules` path and then connect the git directory and\n> \tits working directory by setting the `core.worktree` and adding\n> \ta .git file pointing to the git directory embedded in the\n"},{"id":"389293","messageId":"nycvar.QRO.7.76.6.2001062352010.46@tvgsbejvaqbjf.bet","threadId":"52573","inReplyTo":"xmqqblrga4h1.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2020-01-06T22:52:46Z","receivedAt":"2020-01-06T22:52:56Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Mon, 6 Jan 2020, Junio C Hamano wrote:\n\n> When anybody tries to respond to the quoted message [*1*] that came\n> from GGG in the way recommended for the list, the\n> *.noreply.github.com address gets placed on the Cc:, which is\n> probably not wanted.\n>\n> Can GGG do something about it? As GitHub specific service, it is\n> not wrong for it to know what noreply.github.com means so dropping\n> such an address from its Cc: line shouldn't be too difficult.\n>\n> Thanks.\n>\n>\n> Reference *1*\n>\n> \n\nRight. I added it to the bug tracker:\nhttps://github.com/gitgitgadget/gitgitgadget/issues/182\n\nCiao,\nDscho\n"}]}