{"thread":{"id":"5256","subject":"[PATCH 07/28] builtin-mailinfo.c cleanup","startedAt":"2006-08-14T20:24:48Z","lastAt":"2006-08-14T20:24:48Z","messageCount":1,"participants":["David Rientjes"],"isPatch":true,"patchVersion":1,"patchTotal":28},"messages":[{"id":"25287","messageId":"Pine.LNX.4.63.0608141323530.19383@chino.corp.google.com","threadId":"5256","inReplyTo":null,"subject":"[PATCH 07/28] builtin-mailinfo.c cleanup","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-14T20:24:48Z","receivedAt":"2006-08-14T20:24:48Z","isPatch":true,"sender":{"key":"rientjes@google.com","avatar":null},"body":"Makes decode_q_segment and decode_b_segment void and cleans up function calls.\n\n\t\tDavid\n\nSigned-off-by: David Rientjes <rientjes@google.com>\n---\n builtin-mailinfo.c |   16 +++++++---------\n 1 files changed, 7 insertions(+), 9 deletions(-)\n\ndiff --git a/builtin-mailinfo.c b/builtin-mailinfo.c\nindex 24a4fc6..bac3048 100644\n--- a/builtin-mailinfo.c\n+++ b/builtin-mailinfo.c\n@@ -462,7 +462,7 @@ static unsigned hexval(int c)\n \treturn ~0;\n }\n \n-static int decode_q_segment(char *in, char *ot, char *ep, int rfc2047)\n+static void decode_q_segment(char *in, char *ot, char *ep, int rfc2047)\n {\n \tint c;\n \twhile ((c = *in++) != 0 && (in <= ep)) {\n@@ -478,10 +478,9 @@ static int decode_q_segment(char *in, ch\n \t\t*ot++ = c;\n \t}\n \t*ot = 0;\n-\treturn 0;\n }\n \n-static int decode_b_segment(char *in, char *ot, char *ep)\n+static void decode_b_segment(char *in, char *ot, char *ep)\n {\n \t/* Decode in..ep, possibly in-place to ot */\n \tint c, pos = 0, acc = 0;\n@@ -525,7 +524,6 @@ static int decode_b_segment(char *in, ch\n \t\t}\n \t}\n \t*ot = 0;\n-\treturn 0;\n }\n \n static void convert_to_utf8(char *line, char *charset)\n@@ -606,10 +604,12 @@ static int decode_header_bq(char *it)\n \t\tdefault:\n \t\t\treturn rfc2047; /* no munging */\n \t\tcase 'b':\n-\t\t\tsz = decode_b_segment(cp + 3, piecebuf, ep);\n+\t\t\tdecode_b_segment(cp + 3, piecebuf, ep);\n+\t\t\tsz = 0;\n \t\t\tbreak;\n \t\tcase 'q':\n-\t\t\tsz = decode_q_segment(cp + 3, piecebuf, ep, 1);\n+\t\t\tdecode_q_segment(cp + 3, piecebuf, ep, 1);\n+\t\t\tsz = 0;\n \t\t\tbreak;\n \t\t}\n \t\tif (sz < 0)\n@@ -746,9 +746,7 @@ static int handle_multipart_one_part(int\n \t\thandle_patch();\n \t\tbreak;\n \t}\n-\tif (n == 0)\n-\t\treturn -1;\n-\treturn 0;\n+\treturn n ? 0 : -1;\n }\n \n static void handle_multipart_body(void)\n-- \n1.4.2.g89bb-dirty\n"}]}