{"thread":{"id":"5255","subject":"[PATCH 06/28] make cmd_log_walk void","startedAt":"2006-08-14T20:23:52Z","lastAt":"2006-08-14T20:23:52Z","messageCount":1,"participants":["David Rientjes"],"isPatch":true,"patchVersion":1,"patchTotal":28},"messages":[{"id":"25286","messageId":"Pine.LNX.4.63.0608141322440.19383@chino.corp.google.com","threadId":"5255","inReplyTo":null,"subject":"[PATCH 06/28] make cmd_log_walk void","fromName":"David Rientjes","fromEmail":"rientjes@google.com","sentAt":"2006-08-14T20:23:52Z","receivedAt":"2006-08-14T20:23:52Z","isPatch":true,"sender":{"key":"rientjes@google.com","avatar":null},"body":"Makes cmd_log_walk void.\n\n\t\tDavid\n\nSigned-off-by: David Rientjes <rientjes@google.com>\n---\n builtin-log.c |   12 +++++++-----\n 1 files changed, 7 insertions(+), 5 deletions(-)\n\ndiff --git a/builtin-log.c b/builtin-log.c\nindex 691cf3a..cf103ea 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -29,7 +29,7 @@ static void cmd_log_init(int argc, const\n \t\tdie(\"unrecognized argument: %s\", argv[1]);\n }\n \n-static int cmd_log_walk(struct rev_info *rev)\n+static void cmd_log_walk(struct rev_info *rev)\n {\n \tstruct commit *commit;\n \n@@ -41,7 +41,6 @@ static int cmd_log_walk(struct rev_info \n \t\tfree_commit_list(commit->parents);\n \t\tcommit->parents = NULL;\n \t}\n-\treturn 0;\n }\n \n int cmd_whatchanged(int argc, const char **argv, const char *prefix)\n@@ -56,7 +55,8 @@ int cmd_whatchanged(int argc, const char\n \tcmd_log_init(argc, argv, prefix, &rev);\n \tif (!rev.diffopt.output_format)\n \t\trev.diffopt.output_format = DIFF_FORMAT_RAW;\n-\treturn cmd_log_walk(&rev);\n+\tcmd_log_walk(&rev);\n+\treturn 0;\n }\n \n int cmd_show(int argc, const char **argv, const char *prefix)\n@@ -73,7 +73,8 @@ int cmd_show(int argc, const char **argv\n \trev.ignore_merges = 0;\n \trev.no_walk = 1;\n \tcmd_log_init(argc, argv, prefix, &rev);\n-\treturn cmd_log_walk(&rev);\n+\tcmd_log_walk(&rev);\n+\treturn 0;\n }\n \n int cmd_log(int argc, const char **argv, const char *prefix)\n@@ -84,7 +85,8 @@ int cmd_log(int argc, const char **argv,\n \tinit_revisions(&rev, prefix);\n \trev.always_show_header = 1;\n \tcmd_log_init(argc, argv, prefix, &rev);\n-\treturn cmd_log_walk(&rev);\n+\tcmd_log_walk(&rev);\n+\treturn 0;\n }\n \n static int istitlechar(char c)\n-- \n1.4.2.g89bb-dirty\n"}]}