{"thread":{"id":"52508","subject":"[PATCH] t3008: find test-tool through path lookup","startedAt":"2019-12-22T15:03:58Z","lastAt":"2020-01-01T22:20:39Z","messageCount":2,"participants":["Johannes Sixt","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"388797","messageId":"2dc0b0f3-19ce-62ab-5af9-fdb2d05b00bd@kdbg.org","threadId":"52508","inReplyTo":null,"subject":"[PATCH] t3008: find test-tool through path lookup","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2019-12-22T15:03:53Z","receivedAt":"2019-12-22T15:03:58Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Do not use $GIT_BUILD_DIR without quotes; it may contain spaces and be\nsplit into fields. But it is not necessary to access test-tool with an\nabsolute path in the first place as it can be found via path lookup.\nRemove the explicit path.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n Found this today coincidentally when I happened to look at the terminal\n with test output at the right time and saw a suspicous error message\n that included just one half of the build directory path.\n\n -- Hannes\n\n t/t3008-ls-files-lazy-init-name-hash.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3008-ls-files-lazy-init-name-hash.sh b/t/t3008-ls-files-lazy-init-name-hash.sh\nindex 64f047332b..85f3704958 100755\n--- a/t/t3008-ls-files-lazy-init-name-hash.sh\n+++ b/t/t3008-ls-files-lazy-init-name-hash.sh\n@@ -4,7 +4,7 @@ test_description='Test the lazy init name hash with various folder structures'\n \n . ./test-lib.sh\n \n-if test 1 -eq $($GIT_BUILD_DIR/t/helper/test-tool online-cpus)\n+if test 1 -eq $(test-tool online-cpus)\n then\n \tskip_all='skipping lazy-init tests, single cpu'\n \ttest_done\n-- \n2.24.1.524.gae569673ff\n\n"},{"id":"389156","messageId":"nycvar.QRO.7.76.6.2001012319200.46@tvgsbejvaqbjf.bet","threadId":"52508","inReplyTo":"2dc0b0f3-19ce-62ab-5af9-fdb2d05b00bd@kdbg.org","subject":"Re: [PATCH] t3008: find test-tool through path lookup","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2020-01-01T22:19:39Z","receivedAt":"2020-01-01T22:20:39Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Hannes,\n\nOn Sun, 22 Dec 2019, Johannes Sixt wrote:\n\n> Do not use $GIT_BUILD_DIR without quotes; it may contain spaces and be\n> split into fields. But it is not necessary to access test-tool with an\n> absolute path in the first place as it can be found via path lookup.\n> Remove the explicit path.\n>\n> Signed-off-by: Johannes Sixt <j6t@kdbg.org>\n> ---\n>  Found this today coincidentally when I happened to look at the terminal\n>  with test output at the right time and saw a suspicous error message\n>  that included just one half of the build directory path.\n\nThis patch looks good to me.\n\nThanks,\nDscho\n\n>\n>  -- Hannes\n>\n>  t/t3008-ls-files-lazy-init-name-hash.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t3008-ls-files-lazy-init-name-hash.sh b/t/t3008-ls-files-lazy-init-name-hash.sh\n> index 64f047332b..85f3704958 100755\n> --- a/t/t3008-ls-files-lazy-init-name-hash.sh\n> +++ b/t/t3008-ls-files-lazy-init-name-hash.sh\n> @@ -4,7 +4,7 @@ test_description='Test the lazy init name hash with various folder structures'\n>\n>  . ./test-lib.sh\n>\n> -if test 1 -eq $($GIT_BUILD_DIR/t/helper/test-tool online-cpus)\n> +if test 1 -eq $(test-tool online-cpus)\n>  then\n>  \tskip_all='skipping lazy-init tests, single cpu'\n>  \ttest_done\n> --\n> 2.24.1.524.gae569673ff\n>\n>\n"}]}