{"thread":{"id":"52495","subject":"Low prio: feature requests for git-gui","startedAt":"2019-12-20T09:43:08Z","lastAt":"2019-12-23T12:19:06Z","messageCount":3,"participants":["H.Merijn Brand","Pratyush Yadav"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"388610","messageId":"20191220104258.1110d00e@pc09.procura.nl","threadId":"52495","inReplyTo":null,"subject":"Low prio: feature requests for git-gui","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2019-12-20T09:42:58Z","receivedAt":"2019-12-20T09:43:08Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"• Right click context menu on file-entry in Unstaged Changes list\n\n  - Reset changes → git checkout this file\n    I see the current changes need to be reversed, are bogus or\n    invalid\n  - Restore this file → git checkout this file\n    it was accidentally removed. Like the first option\n  - Remove this file from disk\n    Somehow an invalid restore, a misplaced output or other reason\n    (core dump, debug output from other tools) made this file appear\n    and I don't want to add it to .gitignore\n  - Add to .gitignore\n    Like above, but this file will re-appear more often\n\nDoes this sound reasonable enough to make it a ticket/issue?\n\n-- \nH.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/\nusing perl5.00307 .. 5.31      porting perl5 on HP-UX, AIX, and Linux\nhttps://useplaintext.email  https://tux.nl  http://www.test-smoke.org\nhttp://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"388798","messageId":"20191222174718.nb3noztxo64g7jl3@yadavpratyush.com","threadId":"52495","inReplyTo":"20191220104258.1110d00e@pc09.procura.nl","subject":"Re: Low prio: feature requests for git-gui","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2019-12-22T17:47:18Z","receivedAt":"2019-12-22T17:47:30Z","isPatch":false,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"Hi Merijn,\n\nOn 20/12/19 10:42AM, H.Merijn Brand wrote:\n> • Right click context menu on file-entry in Unstaged Changes list\n\nIt is something on my TODO list.\n\n>   - Reset changes → git checkout this file\n>     I see the current changes need to be reversed, are bogus or\n>     invalid\n\nI'm not sure what this means. When you hit Ctrl-J or choose it from the \nmenu bar, current changes can be reverted by checking the file out from \nthe index.\n\n>   - Restore this file → git checkout this file\n>     it was accidentally removed. Like the first option\n\nWhat constitutes as \"accidentally removed\", and where do we restore the \nfile from? If it needs to be restored from the index, then Ctrl-J should \ndo the trick. If it needs to be restored from an older revision, well as \nof now git-gui doesn't have many features that deal with things like \nthis. But maybe something like this can be added.\n\n>   - Remove this file from disk\n>     Somehow an invalid restore, a misplaced output or other reason\n>     (core dump, debug output from other tools) made this file appear\n>     and I don't want to add it to .gitignore\n\nThis feature was recently added in fa38ab6 (git-gui: revert untracked \nfiles by deleting them, 2019-12-01). You can hit Ctrl-J on the untracked \nfile to delete it.\n\n>   - Add to .gitignore\n>     Like above, but this file will re-appear more often\n\nA naive implementation of this shouldn't be too difficult. I'll see if I \ncan find some time to do it.\n \n> Does this sound reasonable enough to make it a ticket/issue?\n\n-- \nRegards,\nPratyush Yadav\n"},{"id":"388803","messageId":"20191223131849.13fc572e@pc09.procura.nl","threadId":"52495","inReplyTo":"20191222174718.nb3noztxo64g7jl3@yadavpratyush.com","subject":"Re: Low prio: feature requests for git-gui","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2019-12-23T12:18:49Z","receivedAt":"2019-12-23T12:19:06Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Sun, 22 Dec 2019 23:17:18 +0530, Pratyush Yadav\n<me@yadavpratyush.com> wrote:\n\n> Hi Merijn,\n> \n> On 20/12/19 10:42AM, H.Merijn Brand wrote:\n> > • Right click context menu on file-entry in Unstaged Changes list  \n> \n> It is something on my TODO list.\n\n\\o/\n\n> >   - Reset changes → git checkout this file\n> >     I see the current changes need to be reversed, are bogus or\n> >     invalid  \n> \n> I'm not sure what this means. When you hit Ctrl-J or choose it from\n> the menu bar, current changes can be reverted by checking the file\n> out from the index.\n\nI always interpreted Ctrl-J as to mean revert *all* changes. Now I know\nbetter. Thanks.\n\nIf you add it to a context menu, I'd like to have an option in setting\nnot to get a dialog, as choosing it for a single file is (at least to\nme) obvious enough not to need a dialog to confirm my choice.\n\n> >   - Restore this file → git checkout this file\n> >     it was accidentally removed. Like the first option  \n> \n> What constitutes as \"accidentally removed\", and where do we restore\n> the file from? If it needs to be restored from the index, then Ctrl-J\n> should do the trick. If it needs to be restored from an older\n> revision, well as of now git-gui doesn't have many features that deal\n> with things like this. But maybe something like this can be added.\n\nIn my mind there is a difference between a changed file and a deleted\nfile. Ctrl-J restores the previous state, which in effect is the same\nfor both options.\n\n> >   - Remove this file from disk\n> >     Somehow an invalid restore, a misplaced output or other reason\n> >     (core dump, debug output from other tools) made this file appear\n> >     and I don't want to add it to .gitignore  \n> \n> This feature was recently added in fa38ab6 (git-gui: revert untracked \n> files by deleting them, 2019-12-01). You can hit Ctrl-J on the\n> untracked file to delete it.\n\nYeah!\n\n> >   - Add to .gitignore\n> >     Like above, but this file will re-appear more often  \n> \n> A naive implementation of this shouldn't be too difficult. I'll see\n> if I can find some time to do it.\n\nYeah! (again :)\n\n> > Does this sound reasonable enough to make it a ticket/issue?  \n\nThanks for the feedback\n\n-- \nH.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/\nusing perl5.00307 .. 5.31      porting perl5 on HP-UX, AIX, and Linux\nhttps://useplaintext.email  https://tux.nl  http://www.test-smoke.org\nhttp://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/\n"}]}