{"thread":{"id":"52455","subject":"[Outreachy] [PATCH v2] bisect--helper: convert `*_warning` char pointers to char arrays.","startedAt":"2019-12-14T08:12:36Z","lastAt":"2019-12-14T08:12:36Z","messageCount":1,"participants":["Miriam Rubio"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"388203","messageId":"20191214081124.28851-1-mirucam@gmail.com","threadId":"52455","inReplyTo":null,"subject":"[Outreachy] [PATCH v2] bisect--helper: convert `*_warning` char pointers to char arrays.","fromName":"Miriam Rubio","fromEmail":"mirucam@gmail.com","sentAt":"2019-12-14T08:11:24Z","receivedAt":"2019-12-14T08:12:36Z","isPatch":true,"sender":{"key":"mirucam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/56339109?v=4"},"body":"From: Tanushree Tumane <tanushreetumane@gmail.com>\n\nInstead of using a pointer that points at a constant string,\njust give name directly to the constant string; this way, we\ndo not have to allocate a pointer variable in addition to\nthe string we want to use.\n\nLet's convert `need_bad_and_good_revision_warning` and\n`need_bisect_start_warning` char pointers to char arrays.\n\nMentored-by: Christian Couder <chriscool@tuxfamily.org>\nSigned-off-by: Tanushree Tumane <tanushreetumane@gmail.com>\nSigned-off-by: Miriam Rubio <mirucam@gmail.com>\nHelped-by: Junio C Hamano <gitster@pobox.com>\n---\nThis patch is a new version of:\nhttps://public-inbox.org/git/cadc46442d5c960caa58227092289fa2f44fb96f.1551003074.git.gitgitgadget@gmail.com/\nsent previously by Tanushree Tumane.\n\n builtin/bisect--helper.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c\nindex 3055b2bb50..1718df7f09 100644\n--- a/builtin/bisect--helper.c\n+++ b/builtin/bisect--helper.c\n@@ -282,11 +282,11 @@ static int mark_good(const char *refname, const struct object_id *oid,\n \treturn 1;\n }\n \n-static const char *need_bad_and_good_revision_warning =\n+static const char need_bad_and_good_revision_warning[] =\n \tN_(\"You need to give me at least one %s and %s revision.\\n\"\n \t   \"You can use \\\"git bisect %s\\\" and \\\"git bisect %s\\\" for that.\");\n \n-static const char *need_bisect_start_warning =\n+static const char need_bisect_start_warning[] =\n \tN_(\"You need to start by \\\"git bisect start\\\".\\n\"\n \t   \"You then need to give me at least one %s and %s revision.\\n\"\n \t   \"You can use \\\"git bisect %s\\\" and \\\"git bisect %s\\\" for that.\");\n-- \n2.21.0 (Apple Git-122.2)\n\n"}]}