{"thread":{"id":"52452","subject":"[PATCH 0/1] t3434: mark successful test as such","startedAt":"2019-12-13T21:03:50Z","lastAt":"2019-12-13T21:03:51Z","messageCount":2,"participants":["Elijah Newren via GitGitGadget"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"388164","messageId":"pull.678.git.git.1576271025.gitgitgadget@gmail.com","threadId":"52452","inReplyTo":null,"subject":"[PATCH 0/1] t3434: mark successful test as such","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-12-13T21:03:44Z","receivedAt":"2019-12-13T21:03:50Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"t3434.3 was fixed a week ago, but no-one noticed. Mark it as such.\n\nElijah Newren (1):\n  t3434: mark successful test as such\n\n t/t3434-rebase-i18n.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: ad05a3d8e5a6a06443836b5e40434262d992889a\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-678%2Fnewren%2Ft3434-successful-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-678/newren/t3434-successful-v1\nPull-Request: https://github.com/git/git/pull/678\n-- \ngitgitgadget\n"},{"id":"388165","messageId":"2d1f9a8485e744e23b1f02826877afe829a639cf.1576271025.git.gitgitgadget@gmail.com","threadId":"52452","inReplyTo":"pull.678.git.git.1576271025.gitgitgadget@gmail.com","subject":"[PATCH 1/1] t3434: mark successful test as such","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-12-13T21:03:45Z","receivedAt":"2019-12-13T21:03:51Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"From: Elijah Newren <newren@gmail.com>\n\nt3434.3 was fixed by commit 917d0d6234be (\"Merge branch\n'js/rebase-r-safer-label'\", 2019-12-05).  t3434 did not exist in\njs/rebase-r-safer-label, so could not have marked the test as fixed, and\nit was probably not noticed that the merge fixed this test.  Mark it as\nfixed now.\n\nSigned-off-by: Elijah Newren <newren@gmail.com>\n---\n t/t3434-rebase-i18n.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3434-rebase-i18n.sh b/t/t3434-rebase-i18n.sh\nindex 4b5b128cd6..c7c835cde9 100755\n--- a/t/t3434-rebase-i18n.sh\n+++ b/t/t3434-rebase-i18n.sh\n@@ -45,7 +45,7 @@ test_expect_success 'rebase --rebase-merges update encoding eucJP to UTF-8' '\n \tcompare_msg eucJP.txt eucJP UTF-8\n '\n \n-test_expect_failure 'rebase --rebase-merges update encoding eucJP to ISO-2022-JP' '\n+test_expect_success 'rebase --rebase-merges update encoding eucJP to ISO-2022-JP' '\n \tgit switch -c merge-eucJP-ISO-2022-JP first &&\n \tgit config i18n.commitencoding eucJP &&\n \tgit merge -F \"$TEST_DIRECTORY/t3434/eucJP.txt\" second &&\n-- \ngitgitgadget\n"}]}