{"thread":{"id":"52396","subject":"[PATCH] git-gui: allow closing console window with Escape","startedAt":"2019-12-06T22:20:48Z","lastAt":"2019-12-13T20:37:19Z","messageCount":9,"participants":["Pratyush Yadav","Johannes Schindelin","Vasili Novikov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"387650","messageId":"20191206222040.toj4enbbbbamnrww@yadavpratyush.com","threadId":"52396","inReplyTo":null,"subject":"[PATCH] git-gui: allow closing console window with Escape","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2019-12-06T22:20:40Z","receivedAt":"2019-12-06T22:20:48Z","isPatch":true,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"It is often expected that popup windows like the console window be\nclose-able with Esc.\n\nSigned-off-by: Pratyush Yadav \n---\nThis was requested by https://github.com/prati0100/git-gui/issues/17\n\n lib/console.tcl | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/lib/console.tcl b/lib/console.tcl\nindex 1f3248f..8828f6f 100644\n--- a/lib/console.tcl\n+++ b/lib/console.tcl\n@@ -88,6 +88,7 @@ method _init {} {\n \tbind_button3 $w_t \"tk_popup $w.ctxm %X %Y\"\n \tbind $w_t <$M1B-Key-a> \"$w_t tag add sel 0.0 end;break\"\n \tbind $w_t <$M1B-Key-A> \"$w_t tag add sel 0.0 end;break\"\n+\tbind $w [list destroy $w]\n }\n\n method exec {cmd {after {}}} {\n--\n2.24.0\n\n"},{"id":"387677","messageId":"nycvar.QRO.7.76.6.1912071723010.31080@tvgsbejvaqbjf.bet","threadId":"52396","inReplyTo":"20191206222040.toj4enbbbbamnrww@yadavpratyush.com","subject":"Re: [PATCH] git-gui: allow closing console window with Escape","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-12-07T16:24:30Z","receivedAt":"2019-12-07T16:24:49Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 7 Dec 2019, Pratyush Yadav wrote:\n\n> It is often expected that popup windows like the console window be\n> close-able with Esc.\n\nSeeing as the console windows is not your regular popup window with an\n\"OK\" button, I could see how it would be all too easy to close the window\nvia the Esc button all too easily, annoying users.\n\nFor windows like the console one, I would expect Ctrl+W a much more\nnatural keyboard shortcut to close it.\n\nCiao,\nDscho\n\n>\n> Signed-off-by: Pratyush Yadav \n> ---\n> This was requested by https://github.com/prati0100/git-gui/issues/17\n>\n> lib/console.tcl | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/lib/console.tcl b/lib/console.tcl\n> index 1f3248f..8828f6f 100644\n> --- a/lib/console.tcl\n> +++ b/lib/console.tcl\n> @@ -88,6 +88,7 @@ method _init {} {\n> \tbind_button3 $w_t \"tk_popup $w.ctxm %X %Y\"\n> \tbind $w_t <$M1B-Key-a> \"$w_t tag add sel 0.0 end;break\"\n> \tbind $w_t <$M1B-Key-A> \"$w_t tag add sel 0.0 end;break\"\n> +\tbind $w [list destroy $w]\n> }\n>\n> method exec {cmd {after {}}} {\n> --\n> 2.24.0\n>\n>\n"},{"id":"387722","messageId":"20191208194046.csf35b7rgycst2vc@yadavpratyush.com","threadId":"52396","inReplyTo":"nycvar.QRO.7.76.6.1912071723010.31080@tvgsbejvaqbjf.bet","subject":"Re: [PATCH] git-gui: allow closing console window with Escape","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2019-12-08T19:40:46Z","receivedAt":"2019-12-08T19:40:58Z","isPatch":true,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"On 07/12/19 05:24PM, Johannes Schindelin wrote:\n> Hi,\n> \n> On Sat, 7 Dec 2019, Pratyush Yadav wrote:\n> \n> > It is often expected that popup windows like the console window be\n> > close-able with Esc.\n> \n> Seeing as the console windows is not your regular popup window with an\n> \"OK\" button, I could see how it would be all too easy to close the window\n> via the Esc button all too easily, annoying users.\n\nI'm not sure why it is \"too easy\" to hit Escape. If you're hitting Esc \n(which for most people is pretty far from other more frequently used \nkeys) you expect _something_ to happen. People don't just spam Esc for \nno reason, do they?\n \n> For windows like the console one, I would expect Ctrl+W a much more\n> natural keyboard shortcut to close it.\n\nBut, that \"something\" the user expects to happen could also be \"stop the \ncommand\". AFAIK, Esc is often expected to stop commands. But closing the \nconsole window won't actually stop the command. It will keep running in \nthe background, and when the command is done, the window will open again \nshowing the final output.\n\nSo all in all, I do think Ctrl-W would be a better idea. Will re-roll.\n \n> Ciao,\n> Dscho\n\n-- \nRegards,\nPratyush Yadav\n"},{"id":"387739","messageId":"nycvar.QRO.7.76.6.1912091014220.31080@tvgsbejvaqbjf.bet","threadId":"52396","inReplyTo":"20191208194046.csf35b7rgycst2vc@yadavpratyush.com","subject":"Re: [PATCH] git-gui: allow closing console window with Escape","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-12-09T09:18:48Z","receivedAt":"2019-12-09T09:19:12Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Pratyush,\n\nOn Mon, 9 Dec 2019, Pratyush Yadav wrote:\n\n> On 07/12/19 05:24PM, Johannes Schindelin wrote:\n> >\n> > On Sat, 7 Dec 2019, Pratyush Yadav wrote:\n> >\n> > > It is often expected that popup windows like the console window be\n> > > close-able with Esc.\n> >\n> > Seeing as the console windows is not your regular popup window with an\n> > \"OK\" button, I could see how it would be all too easy to close the window\n> > via the Esc button all too easily, annoying users.\n>\n> I'm not sure why it is \"too easy\" to hit Escape. If you're hitting Esc\n> (which for most people is pretty far from other more frequently used\n> keys) you expect _something_ to happen. People don't just spam Esc for\n> no reason, do they?\n\nIs it possible to issue a command in that console window? If yes, Esc D is\nwhat people like me would possibly use to delete entire words.\n\nEven if not, if there is no \"OK\" button, it would annoy me no end if the\nEscape key closes the window (it is not a dialog box, after all).\n\n> > For windows like the console one, I would expect Ctrl+W a much more\n> > natural keyboard shortcut to close it.\n>\n> But, that \"something\" the user expects to happen could also be \"stop the\n> command\". AFAIK, Esc is often expected to stop commands. But closing the\n> console window won't actually stop the command. It will keep running in\n> the background, and when the command is done, the window will open again\n> showing the final output.\n>\n> So all in all, I do think Ctrl-W would be a better idea. Will re-roll.\n\nThank you,\nDscho\n"},{"id":"387792","messageId":"1313cb5b-9d6a-f038-bda3-757b4e55bf33@zivver.com","threadId":"52396","inReplyTo":"nycvar.QRO.7.76.6.1912091014220.31080@tvgsbejvaqbjf.bet","subject":"Re: Re: [PATCH] git-gui: allow closing console window with Escape","fromName":"Vasili Novikov","fromEmail":"vasilii.novikov@zivver.com","sentAt":"2019-12-09T15:53:22Z","receivedAt":"2019-12-09T15:53:27Z","isPatch":true,"sender":{"key":"vasilii.novikov@zivver.com","avatar":null},"body":"What have console windows to do with git gui though? I'd work under the \nfollowing assumptions:\n* we're talking about a GUI window, not a TUI one\n* the window has no useful information at all except the fact that \nsomething has \"finished\", is \"done\". There are no actions that you can \ntake except to dismiss the window.\n\nIf we agree on the following assumptions, then I see these real-world \nexamples:\n* Mousepad > About > Esc = closes the popup\n* Firefox > About > Esc = closes the popup\n* Thunar > select any file and ask its properties > Esc = closes the window\n* file-roller (GNOME compressed archive manager) > Extract archive > \nObserve success window upon completion > Esc = closes the window.\n\nAre there any real-world examples where `Ctrl W` or `Esc D` work but \n`Esc` doesn't, to consider these alternatives as more intuitive to users?\n\n\nOn 09/12/2019 10.18, Johannes Schindelin wrote:\n> Hi Pratyush,\n> \n> On Mon, 9 Dec 2019, Pratyush Yadav wrote:\n> \n>> On 07/12/19 05:24PM, Johannes Schindelin wrote:\n>>>\n>>> On Sat, 7 Dec 2019, Pratyush Yadav wrote:\n>>>\n>>>> It is often expected that popup windows like the console window be\n>>>> close-able with Esc.\n>>>\n>>> Seeing as the console windows is not your regular popup window with an\n>>> \"OK\" button, I could see how it would be all too easy to close the window\n>>> via the Esc button all too easily, annoying users.\n>>\n>> I'm not sure why it is \"too easy\" to hit Escape. If you're hitting Esc\n>> (which for most people is pretty far from other more frequently used\n>> keys) you expect _something_ to happen. People don't just spam Esc for\n>> no reason, do they?\n> \n> Is it possible to issue a command in that console window? If yes, Esc D is\n> what people like me would possibly use to delete entire words.\n> \n> Even if not, if there is no \"OK\" button, it would annoy me no end if the\n> Escape key closes the window (it is not a dialog box, after all).\n> \n>>> For windows like the console one, I would expect Ctrl+W a much more\n>>> natural keyboard shortcut to close it.\n>>\n>> But, that \"something\" the user expects to happen could also be \"stop the\n>> command\". AFAIK, Esc is often expected to stop commands. But closing the\n>> console window won't actually stop the command. It will keep running in\n>> the background, and when the command is done, the window will open again\n>> showing the final output.\n>>\n>> So all in all, I do think Ctrl-W would be a better idea. Will re-roll.\n> \n> Thank you,\n> Dscho\n> \n\n-- \nVasilii Novikov\nSoftware Developer\nvasilii.novikov@zivver.com\n\nZIVVER B.V. • Koningin Wilhelminaplein 30 • 1062 KR Amsterdam\nwww.zivver.com • +31 85 01 60 555 <+31-85-0160555>\nFollow us on: twitter , facebook\n and linkedin\n\n\n✓ Voldoe jij al aan de GDPR-wetgeving?\n\n"},{"id":"387882","messageId":"20191210120219.zc4k5dih25ae3da6@yadavpratyush.com","threadId":"52396","inReplyTo":"1313cb5b-9d6a-f038-bda3-757b4e55bf33@zivver.com","subject":"Re: [PATCH] git-gui: allow closing console window with Escape","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2019-12-10T12:02:19Z","receivedAt":"2019-12-10T12:02:28Z","isPatch":true,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"Hi Vasili,\n\nPlease try to not top-post on the list.\n\nOn 09/12/19 04:53PM, Vasili Novikov wrote:\n> What have console windows to do with git gui though? I'd work under the\n\nWell, the window/popup in question is internally named \"console\" and is \ndefined in lib/console.tcl. It is used by many parts of git-gui that \nneed to execute a command and show the output to the user.\n\n> following assumptions:\n> * we're talking about a GUI window, not a TUI one\n> * the window has no useful information at all except the fact that something\n> has \"finished\", is \"done\". There are no actions that you can take except to\n> dismiss the window.\n \nIt also shows you the output of a command currently in progress (like \ngit-push). My main argument with avoiding Escape is that people often \nexpect Escape to stop an ongoing command. In this case though, closing \nthe window does not actually stop the command. It keeps going on in the \nbackground.\n\nBut since the window is gone, people might think the command they were \nrunning has stopped, which might lead to some unexpected results.\n\n> If we agree on the following assumptions, then I see these real-world\n> examples:\n> * Mousepad > About > Esc = closes the popup\n> * Firefox > About > Esc = closes the popup\n> * Thunar > select any file and ask its properties > Esc = closes the window\n> * file-roller (GNOME compressed archive manager) > Extract archive > Observe\n> success window upon completion > Esc = closes the window.\n\nIn this case, the thing is done. There is no ongoing task. Not quite the \ncase with the console window in git-gui, which can also show ongoing \ntasks.\n \n> Are there any real-world examples where `Ctrl W` or `Esc D` work but `Esc`\n> doesn't, to consider these alternatives as more intuitive to users?\n> \n> \n> On 09/12/2019 10.18, Johannes Schindelin wrote:\n> > Hi Pratyush,\n> > \n> > On Mon, 9 Dec 2019, Pratyush Yadav wrote:\n> > \n> > > On 07/12/19 05:24PM, Johannes Schindelin wrote:\n> > > > \n> > > > On Sat, 7 Dec 2019, Pratyush Yadav wrote:\n> > > > \n> > > > > It is often expected that popup windows like the console window be\n> > > > > close-able with Esc.\n> > > > \n> > > > Seeing as the console windows is not your regular popup window with an\n> > > > \"OK\" button, I could see how it would be all too easy to close the window\n> > > > via the Esc button all too easily, annoying users.\n> > > \n> > > I'm not sure why it is \"too easy\" to hit Escape. If you're hitting Esc\n> > > (which for most people is pretty far from other more frequently used\n> > > keys) you expect _something_ to happen. People don't just spam Esc for\n> > > no reason, do they?\n> > \n> > Is it possible to issue a command in that console window? If yes, Esc D is\n> > what people like me would possibly use to delete entire words.\n> > \n> > Even if not, if there is no \"OK\" button, it would annoy me no end if the\n> > Escape key closes the window (it is not a dialog box, after all).\n> > \n> > > > For windows like the console one, I would expect Ctrl+W a much more\n> > > > natural keyboard shortcut to close it.\n> > > \n> > > But, that \"something\" the user expects to happen could also be \"stop the\n> > > command\". AFAIK, Esc is often expected to stop commands. But closing the\n> > > console window won't actually stop the command. It will keep running in\n> > > the background, and when the command is done, the window will open again\n> > > showing the final output.\n> > > \n> > > So all in all, I do think Ctrl-W would be a better idea. Will re-roll.\n> > \n> > Thank you,\n> > Dscho\n> > \n> \n> -- \n> Vasilii Novikov\n> Software Developer\n> vasilii.novikov@zivver.com\n> \n> ZIVVER B.V. • Koningin Wilhelminaplein 30 • 1062 KR Amsterdam\n> www.zivver.com • +31 85 01 60 555 <+31-85-0160555>\n> Follow us on: twitter , facebook\n> and linkedin\n> \n> \n> ✓ Voldoe jij al aan de GDPR-wetgeving?\n> \n\n-- \nRegards,\nPratyush Yadav\n"},{"id":"387883","messageId":"949c8fca-bf7d-ebde-4f28-10cf193c0411@zivver.com","threadId":"52396","inReplyTo":"20191210120219.zc4k5dih25ae3da6@yadavpratyush.com","subject":"Re: [PATCH] git-gui: allow closing console window with Escape","fromName":"Vasili Novikov","fromEmail":"vasilii.novikov@zivver.com","sentAt":"2019-12-10T12:11:21Z","receivedAt":"2019-12-10T12:11:26Z","isPatch":true,"sender":{"key":"vasilii.novikov@zivver.com","avatar":null},"body":"Hi all,\nSorry if threading was broken: Thunderbird possibly doesn't fully \nsupport mbox import that I used. Or I did it unproperly. Either way, \nhope it's correct now.\n\nThanks for explaining. I misunderstood the purpose of the window. If \nit's a slow ongoing task, then indeed it should not be closeable with \nEsc. I'd say it makes sense to allow Esc to work when it gets into \n\"Success\" state though, as in the screenshot.\n\n\nThanks,\nVasili\n\nOn 10/12/2019 13.02, Pratyush Yadav wrote:\n> Hi Vasili,\n> \n> Please try to not top-post on the list.\n> \n> On 09/12/19 04:53PM, Vasili Novikov wrote:\n>> What have console windows to do with git gui though? I'd work under the\n> \n> Well, the window/popup in question is internally named \"console\" and is\n> defined in lib/console.tcl. It is used by many parts of git-gui that\n> need to execute a command and show the output to the user.\n> \n>> following assumptions:\n>> * we're talking about a GUI window, not a TUI one\n>> * the window has no useful information at all except the fact that something\n>> has \"finished\", is \"done\". There are no actions that you can take except to\n>> dismiss the window.\n> \n> It also shows you the output of a command currently in progress (like\n> git-push). My main argument with avoiding Escape is that people often\n> expect Escape to stop an ongoing command. In this case though, closing\n> the window does not actually stop the command. It keeps going on in the\n> background.\n> \n> But since the window is gone, people might think the command they were\n> running has stopped, which might lead to some unexpected results.\n> \n>> If we agree on the following assumptions, then I see these real-world\n>> examples:\n>> * Mousepad > About > Esc = closes the popup\n>> * Firefox > About > Esc = closes the popup\n>> * Thunar > select any file and ask its properties > Esc = closes the window\n>> * file-roller (GNOME compressed archive manager) > Extract archive > Observe\n>> success window upon completion > Esc = closes the window.\n> \n> In this case, the thing is done. There is no ongoing task. Not quite the\n> case with the console window in git-gui, which can also show ongoing\n> tasks.\n> \n>> Are there any real-world examples where `Ctrl W` or `Esc D` work but `Esc`\n>> doesn't, to consider these alternatives as more intuitive to users?\n>>\n>>\n>> On 09/12/2019 10.18, Johannes Schindelin wrote:\n>>> Hi Pratyush,\n>>>\n>>> On Mon, 9 Dec 2019, Pratyush Yadav wrote:\n>>>\n>>>> On 07/12/19 05:24PM, Johannes Schindelin wrote:\n>>>>>\n>>>>> On Sat, 7 Dec 2019, Pratyush Yadav wrote:\n>>>>>\n>>>>>> It is often expected that popup windows like the console window be\n>>>>>> close-able with Esc.\n>>>>>\n>>>>> Seeing as the console windows is not your regular popup window with an\n>>>>> \"OK\" button, I could see how it would be all too easy to close the window\n>>>>> via the Esc button all too easily, annoying users.\n>>>>\n>>>> I'm not sure why it is \"too easy\" to hit Escape. If you're hitting Esc\n>>>> (which for most people is pretty far from other more frequently used\n>>>> keys) you expect _something_ to happen. People don't just spam Esc for\n>>>> no reason, do they?\n>>>\n>>> Is it possible to issue a command in that console window? If yes, Esc D is\n>>> what people like me would possibly use to delete entire words.\n>>>\n>>> Even if not, if there is no \"OK\" button, it would annoy me no end if the\n>>> Escape key closes the window (it is not a dialog box, after all).\n>>>\n>>>>> For windows like the console one, I would expect Ctrl+W a much more\n>>>>> natural keyboard shortcut to close it.\n>>>>\n>>>> But, that \"something\" the user expects to happen could also be \"stop the\n>>>> command\". AFAIK, Esc is often expected to stop commands. But closing the\n>>>> console window won't actually stop the command. It will keep running in\n>>>> the background, and when the command is done, the window will open again\n>>>> showing the final output.\n>>>>\n>>>> So all in all, I do think Ctrl-W would be a better idea. Will re-roll.\n>>>\n>>> Thank you,\n>>> Dscho\n>>>\n>>\n>> -- \n>> Vasilii Novikov\n>> Software Developer\n>> vasilii.novikov@zivver.com\n>>\n>> ZIVVER B.V. • Koningin Wilhelminaplein 30 • 1062 KR Amsterdam\n>> www.zivver.com • +31 85 01 60 555 <+31-85-0160555>\n>> Follow us on: twitter , facebook\n>> and linkedin\n>> \n>>\n>> ✓ Voldoe jij al aan de GDPR-wetgeving?\n>> \n> \n\n-- \nVasilii Novikov\n"},{"id":"387885","messageId":"20191210133105.apfim55w7osvskvh@yadavpratyush.com","threadId":"52396","inReplyTo":"949c8fca-bf7d-ebde-4f28-10cf193c0411@zivver.com","subject":"Re: [PATCH] git-gui: allow closing console window with Escape","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2019-12-10T13:31:05Z","receivedAt":"2019-12-10T13:31:18Z","isPatch":true,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"(+Cc Dscho who got dropped from the Cc list somewhere along the way)\n\nHi Vasili,\n\nOn 10/12/19 01:11PM, Vasili Novikov wrote:\n> Hi all,\n> Sorry if threading was broken: Thunderbird possibly doesn't fully support\n> mbox import that I used. Or I did it unproperly. Either way, hope it's\n> correct now.\n\nThreading seems to works fine for you. I meant avoiding top posting. \nMore explanation on top posting and bottom posting here \nhttp://www.idallen.com/topposting.html\n \n> Thanks for explaining. I misunderstood the purpose of the window. If it's a\n> slow ongoing task, then indeed it should not be closeable with Esc. I'd say\n> it makes sense to allow Esc to work when it gets into \"Success\" state\n> though, as in the screenshot.\n\nHmm, I like the idea. Does that work for you Dscho?\n \n> \n> Thanks,\n> Vasili\n> \n> On 10/12/2019 13.02, Pratyush Yadav wrote:\n> > Hi Vasili,\n> > \n> > Please try to not top-post on the list.\n> > \n> > On 09/12/19 04:53PM, Vasili Novikov wrote:\n> > > What have console windows to do with git gui though? I'd work under the\n> > \n> > Well, the window/popup in question is internally named \"console\" and is\n> > defined in lib/console.tcl. It is used by many parts of git-gui that\n> > need to execute a command and show the output to the user.\n> > \n> > > following assumptions:\n> > > * we're talking about a GUI window, not a TUI one\n> > > * the window has no useful information at all except the fact that something\n> > > has \"finished\", is \"done\". There are no actions that you can take except to\n> > > dismiss the window.\n> > It also shows you the output of a command currently in progress (like\n> > git-push). My main argument with avoiding Escape is that people often\n> > expect Escape to stop an ongoing command. In this case though, closing\n> > the window does not actually stop the command. It keeps going on in the\n> > background.\n> > \n> > But since the window is gone, people might think the command they were\n> > running has stopped, which might lead to some unexpected results.\n> > \n> > > If we agree on the following assumptions, then I see these real-world\n> > > examples:\n> > > * Mousepad > About > Esc = closes the popup\n> > > * Firefox > About > Esc = closes the popup\n> > > * Thunar > select any file and ask its properties > Esc = closes the window\n> > > * file-roller (GNOME compressed archive manager) > Extract archive > Observe\n> > > success window upon completion > Esc = closes the window.\n> > \n> > In this case, the thing is done. There is no ongoing task. Not quite the\n> > case with the console window in git-gui, which can also show ongoing\n> > tasks.\n> > > Are there any real-world examples where `Ctrl W` or `Esc D` work but `Esc`\n> > > doesn't, to consider these alternatives as more intuitive to users?\n\n-- \nRegards,\nPratyush Yadav\n"},{"id":"388107","messageId":"nycvar.QRO.7.76.6.1912131428490.46@tvgsbejvaqbjf.bet","threadId":"52396","inReplyTo":"20191210133105.apfim55w7osvskvh@yadavpratyush.com","subject":"Re: [PATCH] git-gui: allow closing console window with Escape","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-12-13T13:29:35Z","receivedAt":"2019-12-13T20:37:19Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 10 Dec 2019, Pratyush Yadav wrote:\n\n> On 10/12/19 01:11PM, Vasili Novikov wrote:\n>\n> > Sorry if threading was broken: Thunderbird possibly doesn't fully support\n> > mbox import that I used. Or I did it unproperly. Either way, hope it's\n> > correct now.\n>\n> Threading seems to works fine for you. I meant avoiding top posting.\n> More explanation on top posting and bottom posting here\n> http://www.idallen.com/topposting.html\n>\n> > Thanks for explaining. I misunderstood the purpose of the window. If it's a\n> > slow ongoing task, then indeed it should not be closeable with Esc. I'd say\n> > it makes sense to allow Esc to work when it gets into \"Success\" state\n> > though, as in the screenshot.\n>\n> Hmm, I like the idea. Does that work for you Dscho?\n\nI'm fine with whatever you settle with, I am not really a Git GUI user (I\njust deal with a couple of those users in my role as Git for Windows\nmaintainer).\n\nCiao,\nDscho\n"}]}