{"thread":{"id":"52350","subject":"[PATCH] t1400: use test_must_be_empty","startedAt":"2019-11-26T19:42:07Z","lastAt":"2019-11-26T19:42:07Z","messageCount":1,"participants":["René Scharfe"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"387101","messageId":"ad30f426-4b9e-431c-b1f6-63ca2bb0fa3d@web.de","threadId":"52350","inReplyTo":null,"subject":"[PATCH] t1400: use test_must_be_empty","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2019-11-26T19:41:57Z","receivedAt":"2019-11-26T19:42:07Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Use test_must_be_empty instead of reading the file and comparing its\ncontents to an empty string.  That's more efficient, as the function\nonly needs built-in meta-data only check in the usual case, and provides\nnicer debug output otherwise.\n\nSigned-off-by: René Scharfe <l.s.r@web.de>\n---\n t/t1400-update-ref.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t1400-update-ref.sh b/t/t1400-update-ref.sh\nindex 1fbd940408..ae8e2fcf3b 100755\n--- a/t/t1400-update-ref.sh\n+++ b/t/t1400-update-ref.sh\n@@ -378,13 +378,13 @@ test_expect_success 'Query \"master@{May 26 2005 23:32:00}\" (exactly history star\n \ttest_when_finished \"rm -f o e\" &&\n \tgit rev-parse --verify \"master@{May 26 2005 23:32:00}\" >o 2>e &&\n \ttest $C = $(cat o) &&\n-\ttest \"\" = \"$(cat e)\"\n+\ttest_must_be_empty e\n '\n test_expect_success 'Query \"master@{May 26 2005 23:32:30}\" (first non-creation change)' '\n \ttest_when_finished \"rm -f o e\" &&\n \tgit rev-parse --verify \"master@{May 26 2005 23:32:30}\" >o 2>e &&\n \ttest $A = $(cat o) &&\n-\ttest \"\" = \"$(cat e)\"\n+\ttest_must_be_empty e\n '\n test_expect_success 'Query \"master@{2005-05-26 23:33:01}\" (middle of history with gap)' '\n \ttest_when_finished \"rm -f o e\" &&\n@@ -396,13 +396,13 @@ test_expect_success 'Query \"master@{2005-05-26 23:38:00}\" (middle of history)' '\n \ttest_when_finished \"rm -f o e\" &&\n \tgit rev-parse --verify \"master@{2005-05-26 23:38:00}\" >o 2>e &&\n \ttest $Z = $(cat o) &&\n-\ttest \"\" = \"$(cat e)\"\n+\ttest_must_be_empty e\n '\n test_expect_success 'Query \"master@{2005-05-26 23:43:00}\" (exact end of history)' '\n \ttest_when_finished \"rm -f o e\" &&\n \tgit rev-parse --verify \"master@{2005-05-26 23:43:00}\" >o 2>e &&\n \ttest $E = $(cat o) &&\n-\ttest \"\" = \"$(cat e)\"\n+\ttest_must_be_empty e\n '\n test_expect_success 'Query \"master@{2005-05-28}\" (past end of history)' '\n \ttest_when_finished \"rm -f o e\" &&\n--\n2.24.0\n"}]}