{"thread":{"id":"52349","subject":"[PATCH] t1410: use test_line_count","startedAt":"2019-11-26T18:22:01Z","lastAt":"2019-11-26T22:16:15Z","messageCount":2,"participants":["René Scharfe","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"387097","messageId":"5b872979-b29d-b120-870d-1cac807363ed@web.de","threadId":"52349","inReplyTo":null,"subject":"[PATCH] t1410: use test_line_count","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2019-11-26T18:21:54Z","receivedAt":"2019-11-26T18:22:01Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Use test_line_count to check if the number of lines matches\nexpectations, for improved consistency and nicer debug output.\n\nSigned-off-by: René Scharfe <l.s.r@web.de>\n---\n t/t1410-reflog.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh\nindex 82950c0282..76d9b744a6 100755\n--- a/t/t1410-reflog.sh\n+++ b/t/t1410-reflog.sh\n@@ -195,7 +195,7 @@ test_expect_success 'delete' '\n\n \tgit reflog delete master@{1} &&\n \tgit reflog show master > output &&\n-\ttest $(($master_entry_count - 1)) = $(wc -l < output) &&\n+\ttest_line_count = $(($master_entry_count - 1)) output &&\n \ttest $HEAD_entry_count = $(git reflog | wc -l) &&\n \t! grep ox < output &&\n\n@@ -209,7 +209,7 @@ test_expect_success 'delete' '\n\n \tgit reflog delete master@{07.04.2005.15:15:00.-0700} &&\n \tgit reflog show master > output &&\n-\ttest $(($master_entry_count - 1)) = $(wc -l < output) &&\n+\ttest_line_count = $(($master_entry_count - 1)) output &&\n \t! grep dragon < output\n\n '\n--\n2.24.0\n"},{"id":"387113","messageId":"nycvar.QRO.7.76.6.1911262315330.31080@tvgsbejvaqbjf.bet","threadId":"52349","inReplyTo":"5b872979-b29d-b120-870d-1cac807363ed@web.de","subject":"Re: [PATCH] t1410: use test_line_count","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-11-26T22:15:50Z","receivedAt":"2019-11-26T22:16:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi René,\n\nOn Tue, 26 Nov 2019, René Scharfe wrote:\n\n> Use test_line_count to check if the number of lines matches\n> expectations, for improved consistency and nicer debug output.\n>\n> Signed-off-by: René Scharfe <l.s.r@web.de>\n\nACK!\n\nThanks,\nDscho\n\n> ---\n>  t/t1410-reflog.sh | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh\n> index 82950c0282..76d9b744a6 100755\n> --- a/t/t1410-reflog.sh\n> +++ b/t/t1410-reflog.sh\n> @@ -195,7 +195,7 @@ test_expect_success 'delete' '\n>\n>  \tgit reflog delete master@{1} &&\n>  \tgit reflog show master > output &&\n> -\ttest $(($master_entry_count - 1)) = $(wc -l < output) &&\n> +\ttest_line_count = $(($master_entry_count - 1)) output &&\n>  \ttest $HEAD_entry_count = $(git reflog | wc -l) &&\n>  \t! grep ox < output &&\n>\n> @@ -209,7 +209,7 @@ test_expect_success 'delete' '\n>\n>  \tgit reflog delete master@{07.04.2005.15:15:00.-0700} &&\n>  \tgit reflog show master > output &&\n> -\ttest $(($master_entry_count - 1)) = $(wc -l < output) &&\n> +\ttest_line_count = $(($master_entry_count - 1)) output &&\n>  \t! grep dragon < output\n>\n>  '\n> --\n> 2.24.0\n>\n"}]}