{"thread":{"id":"52267","subject":"[PATCH] INSTALL: use existing shell scripts as example","startedAt":"2019-11-14T17:33:21Z","lastAt":"2019-11-15T05:56:24Z","messageCount":2,"participants":["Andrei Rybak","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"386195","messageId":"20191114173316.9190-1-rybak.a.v@gmail.com","threadId":"52267","inReplyTo":null,"subject":"[PATCH] INSTALL: use existing shell scripts as example","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2019-11-14T17:33:16Z","receivedAt":"2019-11-14T17:33:21Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"Script git-pull.sh has been removed in commit [1].  Use command\n\"request-pull\" as an example of a shell script instead.  Recently, many\nof shell script commands have been re-written in C, so tweak the wording\nof the sentence, while we're here.\n\n[1]: b1456605c2 (pull: remove redirection to git-pull.sh, 2015-06-18)\n\nSigned-off-by: Andrei Rybak <rybak.a.v@gmail.com>\n---\n INSTALL | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/INSTALL b/INSTALL\nindex c39006e8e7..e3170b3cee 100644\n--- a/INSTALL\n+++ b/INSTALL\n@@ -116,8 +116,8 @@ Issues of note:\n \n \t- \"ssh\" is used to push and pull over the net.\n \n-\t- A POSIX-compliant shell is required to run many scripts needed\n-\t  for everyday use (e.g. \"bisect\", \"pull\").\n+\t- A POSIX-compliant shell is required to run some scripts needed\n+\t  for everyday use (e.g. \"bisect\", \"request-pull\").\n \n \t- \"Perl\" version 5.8 or later is needed to use some of the\n \t  features (e.g. preparing a partial commit using \"git add -i/-p\",\n-- \n2.24.0.windows.2\n\n"},{"id":"386259","messageId":"xmqqftip7ke8.fsf@gitster-ct.c.googlers.com","threadId":"52267","inReplyTo":"20191114173316.9190-1-rybak.a.v@gmail.com","subject":"Re: [PATCH] INSTALL: use existing shell scripts as example","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-11-15T05:56:15Z","receivedAt":"2019-11-15T05:56:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andrei Rybak <rybak.a.v@gmail.com> writes:\n\n> Script git-pull.sh has been removed in commit [1].  Use command\n> \"request-pull\" as an example of a shell script instead.  Recently, many\n> of shell script commands have been re-written in C, so tweak the wording\n> of the sentence, while we're here.\n>\n> [1]: b1456605c2 (pull: remove redirection to git-pull.sh, 2015-06-18)\n>\n> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>\n> ---\n>  INSTALL | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/INSTALL b/INSTALL\n> index c39006e8e7..e3170b3cee 100644\n> --- a/INSTALL\n> +++ b/INSTALL\n> @@ -116,8 +116,8 @@ Issues of note:\n>  \n>  \t- \"ssh\" is used to push and pull over the net.\n>  \n> -\t- A POSIX-compliant shell is required to run many scripts needed\n> -\t  for everyday use (e.g. \"bisect\", \"pull\").\n> +\t- A POSIX-compliant shell is required to run some scripts needed\n> +\t  for everyday use (e.g. \"bisect\", \"request-pull\").\n\nThis is not wrong per-se and does improve the section locally (i.e. \"pull\"\nwas a bad example of scripts needed for everyday use).\n\nBut in the longer term, I am not sure if we want to keep giving\nexamples in the first place---this sentence will require constant\nrewriting.\n\nAdmittedly, this \"Git is reasonably self-sufficient, but does\ndepend\" section itself is an oddball to list the requirements by the\nfinal product.  We may want to eject the section (not just this\nsentence) from INSTALL file altogether, as otherwise, the document\nitself is meant for those who build and install git from the source,\nand when you are building from the source, you do need a shell\nanyway.\n\nThanks, will queue.\n\n\n\n"}]}