{"thread":{"id":"52252","subject":"[PATCH] coccinelle: simplify variable declaractions in rules from the_repository.pending.cocci","startedAt":"2019-11-12T21:00:29Z","lastAt":"2019-11-12T21:00:29Z","messageCount":1,"participants":["Markus Elfring"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"386046","messageId":"c260ef87-21d6-8fbc-8060-d7d1c6330601@web.de","threadId":"52252","inReplyTo":null,"subject":"[PATCH] coccinelle: simplify variable declaractions in rules from the_repository.pending.cocci","fromName":"Markus Elfring","fromEmail":"markus.elfring@web.de","sentAt":"2019-11-12T21:00:24Z","receivedAt":"2019-11-12T21:00:29Z","isPatch":true,"sender":{"key":"markus.elfring@web.de","avatar":null},"body":"From: Markus Elfring <elfring@users.sourceforge.net>\nDate: Tue, 12 Nov 2019 21:55:18 +0100\n\nThis script contained some transformation rules for the semantic patch language\nwhere a few metavariables were declared with the same type “expression”.\nReduce duplicate SmPL code just by listing the desired variable names\ndirectly behind the type specification.\n\nSigned-off-by: Markus Elfring <elfring@users.sourceforge.net>\n---\n .../coccinelle/the_repository.pending.cocci   | 44 +++++--------------\n 1 file changed, 12 insertions(+), 32 deletions(-)\n\ndiff --git a/contrib/coccinelle/the_repository.pending.cocci b/contrib/coccinelle/the_repository.pending.cocci\nindex 2ee702ecf7..697e8fc77b 100644\n--- a/contrib/coccinelle/the_repository.pending.cocci\n+++ b/contrib/coccinelle/the_repository.pending.cocci\n@@ -3,9 +3,7 @@\n // our code base.\n\n @@\n-expression E;\n-expression F;\n-expression G;\n+expression E, F, G;\n @@\n - read_object_file(\n + repo_read_object_file(the_repository,\n@@ -42,17 +40,14 @@ expression F;\n   E)\n\n @@\n-expression E;\n-expression F;\n-expression G;\n+expression E, F, G;\n @@\n - parse_commit_internal(\n + repo_parse_commit_internal(the_repository,\n   E, F, G)\n\n @@\n-expression E;\n-expression F;\n+expression E, F;\n @@\n - parse_commit_gently(\n + repo_parse_commit_gently(the_repository,\n@@ -66,78 +61,63 @@ expression E;\n   E)\n\n @@\n-expression E;\n-expression F;\n+expression E, F;\n @@\n - get_merge_bases(\n + repo_get_merge_bases(the_repository,\n   E, F);\n\n @@\n-expression E;\n-expression F;\n-expression G;\n+expression E, F, G;\n @@\n - get_merge_bases_many(\n + repo_get_merge_bases_many(the_repository,\n   E, F, G);\n\n @@\n-expression E;\n-expression F;\n-expression G;\n+expression E, F, G;\n @@\n - get_merge_bases_many_dirty(\n + repo_get_merge_bases_many_dirty(the_repository,\n   E, F, G);\n\n @@\n-expression E;\n-expression F;\n+expression E, F;\n @@\n - in_merge_bases(\n + repo_in_merge_bases(the_repository,\n   E, F);\n\n @@\n-expression E;\n-expression F;\n-expression G;\n+expression E, F, G;\n @@\n - in_merge_bases_many(\n + repo_in_merge_bases_many(the_repository,\n   E, F, G);\n\n @@\n-expression E;\n-expression F;\n+expression E, F;\n @@\n - get_commit_buffer(\n + repo_get_commit_buffer(the_repository,\n   E, F);\n\n @@\n-expression E;\n-expression F;\n+expression E, F;\n @@\n - unuse_commit_buffer(\n + repo_unuse_commit_buffer(the_repository,\n   E, F);\n\n @@\n-expression E;\n-expression F;\n-expression G;\n+expression E, F, G;\n @@\n - logmsg_reencode(\n + repo_logmsg_reencode(the_repository,\n   E, F, G);\n\n @@\n-expression E;\n-expression F;\n-expression G;\n-expression H;\n+expression E, F, G, H;\n @@\n - format_commit_message(\n + repo_format_commit_message(the_repository,\n--\n2.24.0\n\n"}]}