{"thread":{"id":"5224","subject":"[PATCH] git-commit: no silent exit on duplicate Signed-off-by lines","startedAt":"2006-08-13T08:03:28Z","lastAt":"2006-08-14T02:41:46Z","messageCount":3,"participants":["Luben Tuikov","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"25178","messageId":"20060813080328.14584.qmail@web31805.mail.mud.yahoo.com","threadId":"5224","inReplyTo":null,"subject":"[PATCH] git-commit: no silent exit on duplicate Signed-off-by lines","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-13T08:03:28Z","receivedAt":"2006-08-13T08:03:28Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"git-commit would silently exit if duplicate Signed-off-by\nlines were found.  Users of git-commit would not know it,\nunless they checked '$?'.  This patch makes git-commit\nactually print out a message that nothing was commited\nsince duplicate Signed-off-lines were found.\n\nSigned-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n git-commit.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-commit.sh b/git-commit.sh\nindex 4cf3fab..edfd8c0 100755\n--- a/git-commit.sh\n+++ b/git-commit.sh\n@@ -690,7 +690,7 @@ case \"$verify\" in\n t)\n \tif test -x \"$GIT_DIR\"/hooks/commit-msg\n \tthen\n-\t\t\"$GIT_DIR\"/hooks/commit-msg \"$GIT_DIR\"/COMMIT_EDITMSG || exit\n+\t\t\"$GIT_DIR\"/hooks/commit-msg \"$GIT_DIR\"/COMMIT_EDITMSG || die \"Duplicate Signed-off-by lines -- nothing commited\"\n \tfi\n esac\n \n-- \n1.4.2.g73dbd\n"},{"id":"25179","messageId":"7vejvlm4op.fsf@assigned-by-dhcp.cox.net","threadId":"5224","inReplyTo":"20060813080328.14584.qmail@web31805.mail.mud.yahoo.com","subject":"Re: [PATCH] git-commit: no silent exit on duplicate Signed-off-by lines","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-13T08:16:06Z","receivedAt":"2006-08-13T08:16:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov <ltuikov@yahoo.com> writes:\n\n> @@ -690,7 +690,7 @@ case \"$verify\" in\n>  t)\n>  \tif test -x \"$GIT_DIR\"/hooks/commit-msg\n>  \tthen\n> -\t\t\"$GIT_DIR\"/hooks/commit-msg \"$GIT_DIR\"/COMMIT_EDITMSG || exit\n> +\t\t\"$GIT_DIR\"/hooks/commit-msg \"$GIT_DIR\"/COMMIT_EDITMSG || die \"Duplicate Signed-off-by lines -- nothing commited\"\n>  \tfi\n>  esac\n\nPlease emit the complaint from the sample hook/commit-msg\nscript, not from git-commit.\n"},{"id":"25210","messageId":"20060814024146.85979.qmail@web31807.mail.mud.yahoo.com","threadId":"5224","inReplyTo":"7vejvlm4op.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] git-commit: no silent exit on duplicate Signed-off-by lines","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-14T02:41:46Z","receivedAt":"2006-08-14T02:41:46Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano <junkio@cox.net> wrote:\n> Luben Tuikov <ltuikov@yahoo.com> writes:\n> \n> > @@ -690,7 +690,7 @@ case \"$verify\" in\n> >  t)\n> >  \tif test -x \"$GIT_DIR\"/hooks/commit-msg\n> >  \tthen\n> > -\t\t\"$GIT_DIR\"/hooks/commit-msg \"$GIT_DIR\"/COMMIT_EDITMSG || exit\n> > +\t\t\"$GIT_DIR\"/hooks/commit-msg \"$GIT_DIR\"/COMMIT_EDITMSG || die \"Duplicate Signed-off-by lines\n> -- nothing commited\"\n> >  \tfi\n> >  esac\n> \n> Please emit the complaint from the sample hook/commit-msg\n> script, not from git-commit.\n\nOk, I will. (In which case the aforementioned patch can be dropped\nin favor of the new one.)\n\n    Luben\n"}]}