{"thread":{"id":"52207","subject":"[PATCH v3] userdiff: add Elixir to supported userdiff languages","startedAt":"2019-11-06T23:49:52Z","lastAt":"2019-11-09T19:31:24Z","messageCount":5,"participants":["Łukasz Niemier","Johannes Sixt"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"385633","messageId":"20191106234941.48926-1-lukasz@niemier.pl","threadId":"52207","inReplyTo":null,"subject":"[PATCH v3] userdiff: add Elixir to supported userdiff languages","fromName":"Łukasz Niemier","fromEmail":"lukasz@niemier.pl","sentAt":"2019-11-06T23:49:41Z","receivedAt":"2019-11-06T23:49:52Z","isPatch":true,"sender":{"key":"lukasz@niemier.pl","avatar":"https://avatars.githubusercontent.com/u/291639?v=4"},"body":"Adds support for xfuncref in Elixir[1] language which is Ruby-like\nlanguage that runs on Erlang[3] Virtual Machine (BEAM).\n\n[1]: https://elixir-lang.org\n[2]: https://www.erlang.org\n\nSigned-off-by: Łukasz Niemier \n---\n t/t4018-diff-funcname.sh | 1 +\n t/t4018/elixir-do-not-pick-end | 5 +++++\n t/t4018/elixir-ex-unit-test | 6 ++++++\n t/t4018/elixir-function | 5 +++++\n t/t4018/elixir-macro | 5 +++++\n t/t4018/elixir-module | 9 +++++++++\n t/t4018/elixir-module-func | 8 ++++++++\n t/t4018/elixir-nested-module | 9 +++++++++\n t/t4018/elixir-private-function | 5 +++++\n t/t4018/elixir-protocol | 6 ++++++\n t/t4018/elixir-protocol-implementation | 5 +++++\n userdiff.c | 12 ++++++++++++\n 12 files changed, 76 insertions(+)\n create mode 100644 t/t4018/elixir-do-not-pick-end\n create mode 100644 t/t4018/elixir-ex-unit-test\n create mode 100644 t/t4018/elixir-function\n create mode 100644 t/t4018/elixir-macro\n create mode 100644 t/t4018/elixir-module\n create mode 100644 t/t4018/elixir-module-func\n create mode 100644 t/t4018/elixir-nested-module\n create mode 100644 t/t4018/elixir-private-function\n create mode 100644 t/t4018/elixir-protocol\n create mode 100644 t/t4018/elixir-protocol-implementation\n\ndiff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh\nindex 6f5ef0035e..c0f4839543 100755\n--- a/t/t4018-diff-funcname.sh\n+++ b/t/t4018-diff-funcname.sh\n@@ -32,6 +32,7 @@ diffpatterns=\"\n \tcsharp\n \tcss\n \tdts\n+\telixir\n \tfortran\n \tfountain\n \tgolang\ndiff --git a/t/t4018/elixir-do-not-pick-end b/t/t4018/elixir-do-not-pick-end\nnew file mode 100644\nindex 0000000000..fae08ba7e8\n--- /dev/null\n+++ b/t/t4018/elixir-do-not-pick-end\n@@ -0,0 +1,5 @@\n+defmodule RIGHT do\n+end\n+#\n+#\n+# ChangeMe; do not pick up 'end' line\ndiff --git a/t/t4018/elixir-ex-unit-test b/t/t4018/elixir-ex-unit-test\nnew file mode 100644\nindex 0000000000..0560a2b697\n--- /dev/null\n+++ b/t/t4018/elixir-ex-unit-test\n@@ -0,0 +1,6 @@\n+defmodule Test do\n+ test \"RIGHT\" do\n+ assert true == true\n+ assert ChangeMe\n+ end\n+end\ndiff --git a/t/t4018/elixir-function b/t/t4018/elixir-function\nnew file mode 100644\nindex 0000000000..d452f495a7\n--- /dev/null\n+++ b/t/t4018/elixir-function\n@@ -0,0 +1,5 @@\n+def function(RIGHT, arg) do\n+ # comment\n+ # comment\n+ ChangeMe\n+end\ndiff --git a/t/t4018/elixir-macro b/t/t4018/elixir-macro\nnew file mode 100644\nindex 0000000000..4f925e9ad4\n--- /dev/null\n+++ b/t/t4018/elixir-macro\n@@ -0,0 +1,5 @@\n+defmacro foo(RIGHT) do\n+ # Code\n+ # Code\n+ ChangeMe\n+end\ndiff --git a/t/t4018/elixir-module b/t/t4018/elixir-module\nnew file mode 100644\nindex 0000000000..91a4e7aa20\n--- /dev/null\n+++ b/t/t4018/elixir-module\n@@ -0,0 +1,9 @@\n+defmodule RIGHT do\n+ @moduledoc \"\"\"\n+ Foo bar\n+ \"\"\"\n+\n+ def ChangeMe(a) where is_map(a) do\n+ a\n+ end\n+end\ndiff --git a/t/t4018/elixir-module-func b/t/t4018/elixir-module-func\nnew file mode 100644\nindex 0000000000..c9910d0675\n--- /dev/null\n+++ b/t/t4018/elixir-module-func\n@@ -0,0 +1,8 @@\n+defmodule Foo do\n+ def fun(RIGHT) do\n+ # Code\n+ # Code\n+ # Code\n+ ChangeMe\n+ end\n+end\ndiff --git a/t/t4018/elixir-nested-module b/t/t4018/elixir-nested-module\nnew file mode 100644\nindex 0000000000..771ebc5c42\n--- /dev/null\n+++ b/t/t4018/elixir-nested-module\n@@ -0,0 +1,9 @@\n+defmodule MyApp.RIGHT do\n+ @moduledoc \"\"\"\n+ Foo bar\n+ \"\"\"\n+\n+ def ChangeMe(a) where is_map(a) do\n+ a\n+ end\n+end\ndiff --git a/t/t4018/elixir-private-function b/t/t4018/elixir-private-function\nnew file mode 100644\nindex 0000000000..1aabe33b7a\n--- /dev/null\n+++ b/t/t4018/elixir-private-function\n@@ -0,0 +1,5 @@\n+defp function(RIGHT, arg) do\n+ # comment\n+ # comment\n+ ChangeMe\n+end\ndiff --git a/t/t4018/elixir-protocol b/t/t4018/elixir-protocol\nnew file mode 100644\nindex 0000000000..7d9173691e\n--- /dev/null\n+++ b/t/t4018/elixir-protocol\n@@ -0,0 +1,6 @@\n+defprotocol RIGHT do\n+ @doc \"\"\"\n+ Calculates the size (and not the length!) of a data structure\n+ \"\"\"\n+ def size(data, ChangeMe)\n+end\ndiff --git a/t/t4018/elixir-protocol-implementation b/t/t4018/elixir-protocol-implementation\nnew file mode 100644\nindex 0000000000..f9234bbfc4\n--- /dev/null\n+++ b/t/t4018/elixir-protocol-implementation\n@@ -0,0 +1,5 @@\n+defimpl RIGHT do\n+ # Docs\n+ # Docs\n+ def foo(ChangeMe), do: :ok\n+end\ndiff --git a/userdiff.c b/userdiff.c\nindex e187d356f6..577053c10a 100644\n--- a/userdiff.c\n+++ b/userdiff.c\n@@ -32,6 +32,18 @@ PATTERNS(\"dts\",\n \t /* Property names and math operators */\n \t \"[a-zA-Z0-9,._+?#-]+\"\n \t \"|[-+*/%&^|!~]|>>|<<|&&|\\\\|\\\\|\"),\n+PATTERNS(\"elixir\",\n+\t \"^[ \\t]*((def(macro|module|impl|protocol|p)?|test)[ \\t].*)$\",\n+\t /* Atoms, names, and module attributes */\n+\t \"|[@:]?[a-zA-Z0-9@_?!]+\"\n+\t /* Numbers with specific base */\n+\t \"|[-+]?0[xob][0-9a-fA-F]+\"\n+\t /* Numbers */\n+\t \"|[-+]?[0-9][0-9_.]*([eE][-+]?[0-9_]+)?\"\n+\t /* Operators and atoms that represent them */\n+\t \"|:?(\\\\+\\\\+|--|\\\\.\\\\.|~~~|<>|\\\\^\\\\^\\\\^||<<?>>|<?>|<~>|<=|>=|===?|!==?|=~|&&&?|\\\\|\\\\|\\\\|?|=>|<-|\\\\\\\\\\\\\\\\|->)\"\n+\t /* Not real operators, but should be grouped */\n+\t \"|:?%[A-Za-z0-9_.]\\\\{\\\\}?\"),\n IPATTERN(\"fortran\",\n \t \"!^([C*]|[ \\t]*!)\\n\"\n \t \"!^[ \\t]*MODULE[ \\t]+PROCEDURE[ \\t]\\n\"\n-- \n2.23.0\n\n"},{"id":"385738","messageId":"f85a5c31-52ff-85be-b1e0-f3982fd2a7f2@kdbg.org","threadId":"52207","inReplyTo":"20191106234941.48926-1-lukasz@niemier.pl","subject":"Re: [PATCH v3] userdiff: add Elixir to supported userdiff languages","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2019-11-07T20:35:01Z","receivedAt":"2019-11-07T20:35:06Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Please keep the Cc list when you send new patch versions. Also, it is\ncustomary to send them as replies to the earlier iterations, so that\nthey all end up in the same thread.\n\nAm 07.11.19 um 00:49 schrieb Łukasz Niemier:\n> Adds support for xfuncref in Elixir[1] language which is Ruby-like\n> language that runs on Erlang[3] Virtual Machine (BEAM).\n> \n> [1]: https://elixir-lang.org\n> [2]: https://www.erlang.org\n\nThanks! Much appreciated.\n\n> \n> Signed-off-by: Łukasz Niemier \n> ---\n\n> diff --git a/t/t4018/elixir-do-not-pick-end b/t/t4018/elixir-do-not-pick-end\n> new file mode 100644\n> index 0000000000..fae08ba7e8\n> --- /dev/null\n> +++ b/t/t4018/elixir-do-not-pick-end\n> @@ -0,0 +1,5 @@\n> +defmodule RIGHT do\n> +end\n> +#\n> +#\n> +# ChangeMe; do not pick up 'end' line\n\nOK.\n\n> diff --git a/t/t4018/elixir-ex-unit-test b/t/t4018/elixir-ex-unit-test\n> new file mode 100644\n> index 0000000000..0560a2b697\n> --- /dev/null\n> +++ b/t/t4018/elixir-ex-unit-test\n> @@ -0,0 +1,6 @@\n> +defmodule Test do\n> + test \"RIGHT\" do\n> + assert true == true\n> + assert ChangeMe\n> + end\n> +end\n\nA test, and also indented. Good.\n\n> diff --git a/t/t4018/elixir-module-func b/t/t4018/elixir-module-func\n> new file mode 100644\n> index 0000000000..c9910d0675\n> --- /dev/null\n> +++ b/t/t4018/elixir-module-func\n> @@ -0,0 +1,8 @@\n> +defmodule Foo do\n> + def fun(RIGHT) do\n> + # Code\n> + # Code\n> + # Code\n> + ChangeMe\n> + end\n> +end\n\nAn indented function. Good.\n\nThese other tests (which I stripped away) ensure that the hunk header\npattern does not become too restrictive. They all look good.\n\n> diff --git a/userdiff.c b/userdiff.c\n> index e187d356f6..577053c10a 100644\n> --- a/userdiff.c\n> +++ b/userdiff.c\n> @@ -32,6 +32,18 @@ PATTERNS(\"dts\",\n> \t /* Property names and math operators */\n> \t \"[a-zA-Z0-9,._+?#-]+\"\n> \t \"|[-+*/%&^|!~]|>>|<<|&&|\\\\|\\\\|\"),\n> +PATTERNS(\"elixir\",\n> +\t \"^[ \\t]*((def(macro|module|impl|protocol|p)?|test)[ \\t].*)$\",\n> +\t /* Atoms, names, and module attributes */\n> +\t \"|[@:]?[a-zA-Z0-9@_?!]+\"\n\nThere are no single- and double-quote anymore. An oversight? Or an error\nin the earlier iteration?\n\n> +\t /* Numbers with specific base */\n> +\t \"|[-+]?0[xob][0-9a-fA-F]+\"\n> +\t /* Numbers */\n> +\t \"|[-+]?[0-9][0-9_.]*([eE][-+]?[0-9_]+)?\"\n\nThe leading optional sign may be problematic. When a patch changes \"i+1\"\nto \"i+2\", it would be highlighted as \"i{-+1-}{++2+}\" instead of as\n\"i+{-1-}{+2+}\". You could remove the leading optional sign and let it be\nprocessed as an operator. But we also have an optional sign in the cpp\npattern as well, and haven't noticed it until now, so...\n\n> +\t /* Operators and atoms that represent them */\n> +\t \"|:?(\\\\+\\\\+|--|\\\\.\\\\.|~~~|<>|\\\\^\\\\^\\\\^||<<?>>|<?>|<~>|<=|>=|===?|!==?|=~|&&&?|\\\\|\\\\|\\\\|?|=>|<-|\\\\\\\\\\\\\\\\|->)\"\n> +\t /* Not real operators, but should be grouped */\n> +\t \"|:?%[A-Za-z0-9_.]\\\\{\\\\}?\"),\n> IPATTERN(\"fortran\",\n> \t \"!^([C*]|[ \\t]*!)\\n\"\n> \t \"!^[ \\t]*MODULE[ \\t]+PROCEDURE[ \\t]\\n\"\n> \n\nIn summary, this version looks good!\n\nAcked-by: Johannes Sixt \n\n-- Hannes\n"},{"id":"385789","messageId":"86417D50-2C28-477A-BC49-9097A24A3BF3@niemier.pl","threadId":"52207","inReplyTo":"f85a5c31-52ff-85be-b1e0-f3982fd2a7f2@kdbg.org","subject":"Re: [PATCH v3] userdiff: add Elixir to supported userdiff languages","fromName":"Łukasz Niemier","fromEmail":"lukasz@niemier.pl","sentAt":"2019-11-08T15:42:00Z","receivedAt":"2019-11-08T15:42:07Z","isPatch":true,"sender":{"key":"lukasz@niemier.pl","avatar":"https://avatars.githubusercontent.com/u/291639?v=4"},"body":"> Please keep the Cc list when you send new patch versions. Also, it is\n> customary to send them as replies to the earlier iterations, so that\n> they all end up in the same thread.\n\nSorry, I am still learning how to use git send-email and I thought it would be handled automatically.\nI need to find how to operate it properly and how to configure it to reply in thread instead of\ncreating new one.\n\n> There are no single- and double-quote anymore. An oversight? Or an error\n> in the earlier iteration?\n\nNo, I intentionally left them out, as :’foo bar’ is allowed atom, and I didn’t want to complicate\neverything word regex. Instead I assumed that these are so rare, that it should not be a problem.\n\n> The leading optional sign may be problematic. When a patch changes \"i+1\"\n> to \"i+2\", it would be highlighted as \"i{-+1-}{++2+}\" instead of as\n> \"i+{-1-}{+2+}\". You could remove the leading optional sign and let it be\n> processed as an operator. But we also have an optional sign in the cpp\n> pattern as well, and haven't noticed it until now, so…\n\nI copied this pattern from other languages, so I assumed that this is what is expected.\nIt could be fixed, but I think it should be handled in separate patch.\n\n--\n\nŁukasz Niemier\nlukasz@niemier.pl\n\n\n\n\n\n"},{"id":"385814","messageId":"20191108213824.11622-1-lukasz@niemier.pl","threadId":"52207","inReplyTo":"20191106234941.48926-1-lukasz@niemier.pl","subject":"[PATCH v4] userdiff: add Elixir to supported userdiff languages","fromName":"Łukasz Niemier","fromEmail":"lukasz@niemier.pl","sentAt":"2019-11-08T21:38:24Z","receivedAt":"2019-11-08T21:38:40Z","isPatch":true,"sender":{"key":"lukasz@niemier.pl","avatar":"https://avatars.githubusercontent.com/u/291639?v=4"},"body":"Adds support for xfuncref in Elixir[1] language which is Ruby-like\nlanguage that runs on Erlang[3] Virtual Machine (BEAM).\n\n[1]: https://elixir-lang.org\n[2]: https://www.erlang.org\n\nSigned-off-by: Łukasz Niemier \n---\nAdd entry to the documentation of gitattributes as well.\n\n Documentation/gitattributes.txt | 2 ++\n t/t4018-diff-funcname.sh | 1 +\n t/t4018/elixir-do-not-pick-end | 5 +++++\n t/t4018/elixir-ex-unit-test | 6 ++++++\n t/t4018/elixir-function | 5 +++++\n t/t4018/elixir-macro | 5 +++++\n t/t4018/elixir-module | 9 +++++++++\n t/t4018/elixir-module-func | 8 ++++++++\n t/t4018/elixir-nested-module | 9 +++++++++\n t/t4018/elixir-private-function | 5 +++++\n t/t4018/elixir-protocol | 6 ++++++\n t/t4018/elixir-protocol-implementation | 5 +++++\n userdiff.c | 12 ++++++++++++\n 13 files changed, 78 insertions(+)\n create mode 100644 t/t4018/elixir-do-not-pick-end\n create mode 100644 t/t4018/elixir-ex-unit-test\n create mode 100644 t/t4018/elixir-function\n create mode 100644 t/t4018/elixir-macro\n create mode 100644 t/t4018/elixir-module\n create mode 100644 t/t4018/elixir-module-func\n create mode 100644 t/t4018/elixir-nested-module\n create mode 100644 t/t4018/elixir-private-function\n create mode 100644 t/t4018/elixir-protocol\n create mode 100644 t/t4018/elixir-protocol-implementation\n\ndiff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt\nindex c5a528c667..03d8fe6f30 100644\n--- a/Documentation/gitattributes.txt\n+++ b/Documentation/gitattributes.txt\n@@ -812,6 +812,8 @@ patterns are available:\n \n - `dts` suitable for devicetree (DTS) files.\n \n+- `elixir` suitable for source code in the Elixir language.\n+\n - `fortran` suitable for source code in the Fortran language.\n \n - `fountain` suitable for Fountain documents.\ndiff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh\nindex 6f5ef0035e..c0f4839543 100755\n--- a/t/t4018-diff-funcname.sh\n+++ b/t/t4018-diff-funcname.sh\n@@ -32,6 +32,7 @@ diffpatterns=\"\n \tcsharp\n \tcss\n \tdts\n+\telixir\n \tfortran\n \tfountain\n \tgolang\ndiff --git a/t/t4018/elixir-do-not-pick-end b/t/t4018/elixir-do-not-pick-end\nnew file mode 100644\nindex 0000000000..fae08ba7e8\n--- /dev/null\n+++ b/t/t4018/elixir-do-not-pick-end\n@@ -0,0 +1,5 @@\n+defmodule RIGHT do\n+end\n+#\n+#\n+# ChangeMe; do not pick up 'end' line\ndiff --git a/t/t4018/elixir-ex-unit-test b/t/t4018/elixir-ex-unit-test\nnew file mode 100644\nindex 0000000000..0560a2b697\n--- /dev/null\n+++ b/t/t4018/elixir-ex-unit-test\n@@ -0,0 +1,6 @@\n+defmodule Test do\n+ test \"RIGHT\" do\n+ assert true == true\n+ assert ChangeMe\n+ end\n+end\ndiff --git a/t/t4018/elixir-function b/t/t4018/elixir-function\nnew file mode 100644\nindex 0000000000..d452f495a7\n--- /dev/null\n+++ b/t/t4018/elixir-function\n@@ -0,0 +1,5 @@\n+def function(RIGHT, arg) do\n+ # comment\n+ # comment\n+ ChangeMe\n+end\ndiff --git a/t/t4018/elixir-macro b/t/t4018/elixir-macro\nnew file mode 100644\nindex 0000000000..4f925e9ad4\n--- /dev/null\n+++ b/t/t4018/elixir-macro\n@@ -0,0 +1,5 @@\n+defmacro foo(RIGHT) do\n+ # Code\n+ # Code\n+ ChangeMe\n+end\ndiff --git a/t/t4018/elixir-module b/t/t4018/elixir-module\nnew file mode 100644\nindex 0000000000..91a4e7aa20\n--- /dev/null\n+++ b/t/t4018/elixir-module\n@@ -0,0 +1,9 @@\n+defmodule RIGHT do\n+ @moduledoc \"\"\"\n+ Foo bar\n+ \"\"\"\n+\n+ def ChangeMe(a) where is_map(a) do\n+ a\n+ end\n+end\ndiff --git a/t/t4018/elixir-module-func b/t/t4018/elixir-module-func\nnew file mode 100644\nindex 0000000000..c9910d0675\n--- /dev/null\n+++ b/t/t4018/elixir-module-func\n@@ -0,0 +1,8 @@\n+defmodule Foo do\n+ def fun(RIGHT) do\n+ # Code\n+ # Code\n+ # Code\n+ ChangeMe\n+ end\n+end\ndiff --git a/t/t4018/elixir-nested-module b/t/t4018/elixir-nested-module\nnew file mode 100644\nindex 0000000000..771ebc5c42\n--- /dev/null\n+++ b/t/t4018/elixir-nested-module\n@@ -0,0 +1,9 @@\n+defmodule MyApp.RIGHT do\n+ @moduledoc \"\"\"\n+ Foo bar\n+ \"\"\"\n+\n+ def ChangeMe(a) where is_map(a) do\n+ a\n+ end\n+end\ndiff --git a/t/t4018/elixir-private-function b/t/t4018/elixir-private-function\nnew file mode 100644\nindex 0000000000..1aabe33b7a\n--- /dev/null\n+++ b/t/t4018/elixir-private-function\n@@ -0,0 +1,5 @@\n+defp function(RIGHT, arg) do\n+ # comment\n+ # comment\n+ ChangeMe\n+end\ndiff --git a/t/t4018/elixir-protocol b/t/t4018/elixir-protocol\nnew file mode 100644\nindex 0000000000..7d9173691e\n--- /dev/null\n+++ b/t/t4018/elixir-protocol\n@@ -0,0 +1,6 @@\n+defprotocol RIGHT do\n+ @doc \"\"\"\n+ Calculates the size (and not the length!) of a data structure\n+ \"\"\"\n+ def size(data, ChangeMe)\n+end\ndiff --git a/t/t4018/elixir-protocol-implementation b/t/t4018/elixir-protocol-implementation\nnew file mode 100644\nindex 0000000000..f9234bbfc4\n--- /dev/null\n+++ b/t/t4018/elixir-protocol-implementation\n@@ -0,0 +1,5 @@\n+defimpl RIGHT do\n+ # Docs\n+ # Docs\n+ def foo(ChangeMe), do: :ok\n+end\ndiff --git a/userdiff.c b/userdiff.c\nindex e187d356f6..577053c10a 100644\n--- a/userdiff.c\n+++ b/userdiff.c\n@@ -32,6 +32,18 @@ PATTERNS(\"dts\",\n \t /* Property names and math operators */\n \t \"[a-zA-Z0-9,._+?#-]+\"\n \t \"|[-+*/%&^|!~]|>>|<<|&&|\\\\|\\\\|\"),\n+PATTERNS(\"elixir\",\n+\t \"^[ \\t]*((def(macro|module|impl|protocol|p)?|test)[ \\t].*)$\",\n+\t /* Atoms, names, and module attributes */\n+\t \"|[@:]?[a-zA-Z0-9@_?!]+\"\n+\t /* Numbers with specific base */\n+\t \"|[-+]?0[xob][0-9a-fA-F]+\"\n+\t /* Numbers */\n+\t \"|[-+]?[0-9][0-9_.]*([eE][-+]?[0-9_]+)?\"\n+\t /* Operators and atoms that represent them */\n+\t \"|:?(\\\\+\\\\+|--|\\\\.\\\\.|~~~|<>|\\\\^\\\\^\\\\^||<<?>>|<?>|<~>|<=|>=|===?|!==?|=~|&&&?|\\\\|\\\\|\\\\|?|=>|<-|\\\\\\\\\\\\\\\\|->)\"\n+\t /* Not real operators, but should be grouped */\n+\t \"|:?%[A-Za-z0-9_.]\\\\{\\\\}?\"),\n IPATTERN(\"fortran\",\n \t \"!^([C*]|[ \\t]*!)\\n\"\n \t \"!^[ \\t]*MODULE[ \\t]+PROCEDURE[ \\t]\\n\"\n-- \n2.23.0\n\n"},{"id":"385834","messageId":"5a8639a6-0a47-1a11-3886-f5512474b364@kdbg.org","threadId":"52207","inReplyTo":"20191108213824.11622-1-lukasz@niemier.pl","subject":"Re: [PATCH v4] userdiff: add Elixir to supported userdiff languages","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2019-11-09T19:31:19Z","receivedAt":"2019-11-09T19:31:24Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 08.11.19 um 22:38 schrieb Łukasz Niemier:\n> Adds support for xfuncref in Elixir[1] language which is Ruby-like\n> language that runs on Erlang[3] Virtual Machine (BEAM).\n> \n> [1]: https://elixir-lang.org\n> [2]: https://www.erlang.org\n> \n> Signed-off-by: Łukasz Niemier \n> ---\n> Add entry to the documentation of gitattributes as well.\n\nOh, yes! Thanks for being diligent! Let me repeat my\n\nAcked-by: Johannes Sixt \n\n-- Hannes\n"}]}