{"thread":{"id":"52199","subject":"[PATCH 1/1] t: fix typo in test descriptions","startedAt":"2019-11-06T04:18:13Z","lastAt":"2019-11-06T15:15:09Z","messageCount":6,"participants":["Nathan Stocks via GitGitGadget","Jeff King","Nathan Stocks","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"385528","messageId":"5729dd380708da7b40805f75c5d475ff4c0b28c5.1573013889.git.gitgitgadget@gmail.com","threadId":"52199","inReplyTo":"pull.448.git.1573013889.gitgitgadget@gmail.com","subject":"[PATCH 1/1] t: fix typo in test descriptions","fromName":"Nathan Stocks via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-11-06T04:18:09Z","receivedAt":"2019-11-06T04:18:13Z","isPatch":true,"sender":{"key":"cleancut@github.com","avatar":"https://gravatar.com/avatar/6c05e16f2d9dba4fea3357b4e386db7cac53c984eece5c384e2569063c102cf8?d=mp&s=160"},"body":"From: Nathan Stocks \n\nFix two test descriptions which stated \"git -ls-files\" when the actual\ncommand being tested was \"git ls-files\".\n\nSigned-off-by: Nathan Stocks \n---\n t/t3060-ls-files-with-tree.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t3060-ls-files-with-tree.sh b/t/t3060-ls-files-with-tree.sh\nindex 44f378ce41..52ed665fcd 100755\n--- a/t/t3060-ls-files-with-tree.sh\n+++ b/t/t3060-ls-files-with-tree.sh\n@@ -47,7 +47,7 @@ test_expect_success setup '\n \tgit add .\n '\n \n-test_expect_success 'git -ls-files --with-tree should succeed from subdir' '\n+test_expect_success 'git ls-files --with-tree should succeed from subdir' '\n \t# We have to run from a sub-directory to trigger prune_path\n \t# Then we finally get to run our --with-tree test\n \t(\n@@ -57,7 +57,7 @@ test_expect_success 'git -ls-files --with-tree should succeed from subdir' '\n '\n \n test_expect_success \\\n- 'git -ls-files --with-tree should add entries from named tree.' \\\n+ 'git ls-files --with-tree should add entries from named tree.' \\\n 'test_cmp expected output'\n \n test_done\n-- \ngitgitgadget\n"},{"id":"385529","messageId":"pull.448.git.1573013889.gitgitgadget@gmail.com","threadId":"52199","inReplyTo":null,"subject":"[PATCH 0/1] t: fix typo in test descriptions","fromName":"Nathan Stocks via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-11-06T04:18:08Z","receivedAt":"2019-11-06T04:18:14Z","isPatch":true,"sender":{"key":"cleancut@github.com","avatar":"https://gravatar.com/avatar/6c05e16f2d9dba4fea3357b4e386db7cac53c984eece5c384e2569063c102cf8?d=mp&s=160"},"body":"Fix two test descriptions which stated \"git -ls-files\" when the actual\ncommand being tested was \"git ls-files\".\n\nI based this patch off of 'maint' since the typo predates the latest\nrelease, but the patch can be applied cleanly to 'master'.\n\nI happened to run across this while running the following quick-and-dirty\ncommand to see if it looked like there were any undocumented top-level git\noptions that were run from inside tests. The answer to that was\nunsurprisingly \"no\", but it did turn up this typo to fix!\n\ngit grep \"[^./i]git -\" |\n grep -v 'git -C' |\n grep -v 'git -c' |\n grep -v 'git --help' |\n grep -v 'git --exec-path' |\n grep -v 'git --version' |\n grep -v 'git --html-path' |\n grep -v 'git --man-path' |\n grep -v 'git --info-path' |\n grep -v 'git -p' |\n grep -v 'git --paginate' |\n grep -v 'git -P' |\n grep -v 'git --no-pager' |\n grep -v 'git --no-replace-objects' |\n grep -v 'git --bare' |\n grep -v 'git --git-dir' |\n grep -v 'git --work-tree' |\n grep -v 'git --namespace' |\n grep -v 'test_completion' |\n grep -v 'git-grep.*acted as if' |\n grep -v 'git --super-prefix' |\n grep -v 'git --no-replace-objects' |\n grep -v 'git --literal-pathspecs' |\n grep -v 'git --glob-pathspecs' |\n grep -v 'git --noglob-pathspecs' |\n grep -v 'git --icase-pathspecs' |\n grep -v 'git --no-optional-locks' |\n grep -v 'git --list-cmds' |\n grep -v 'git ->'\n\nNathan Stocks (1):\n t: fix typo in test descriptions\n\n t/t3060-ls-files-with-tree.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-448%2FCleanCut%2Ft3060-fix-description-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-448/CleanCut/t3060-fix-description-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/448\n-- \ngitgitgadget\n"},{"id":"385530","messageId":"20191106042806.GF4307@sigill.intra.peff.net","threadId":"52199","inReplyTo":"5729dd380708da7b40805f75c5d475ff4c0b28c5.1573013889.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] t: fix typo in test descriptions","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-11-06T04:28:06Z","receivedAt":"2019-11-06T04:28:08Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Nov 06, 2019 at 04:18:09AM +0000, Nathan Stocks via GitGitGadget wrote:\n\n> From: Nathan Stocks \n> \n> Fix two test descriptions which stated \"git -ls-files\" when the actual\n> command being tested was \"git ls-files\".\n\nThanks, this is obviously an improvement.\n\nI was curious if there was any backstory here. They came from 54e1abce90\n(Add test case for ls-files --with-tree, 2007-10-03). That was around\nthe time of transitioning from \"git-ls-files\" to \"git ls-files\", so\nmaybe that caused the confusion. :)\n\n-Peff\n"},{"id":"385533","messageId":"CAFo48e625pWZRyXuqFezMXXCHgFg7R2073CMCLQstVRtuX343A@mail.gmail.com","threadId":"52199","inReplyTo":"20191106042806.GF4307@sigill.intra.peff.net","subject":"Re: [PATCH 1/1] t: fix typo in test descriptions","fromName":"Nathan Stocks","fromEmail":"cleancut@github.com","sentAt":"2019-11-06T04:45:49Z","receivedAt":"2019-11-06T04:46:07Z","isPatch":true,"sender":{"key":"cleancut@github.com","avatar":"https://gravatar.com/avatar/6c05e16f2d9dba4fea3357b4e386db7cac53c984eece5c384e2569063c102cf8?d=mp&s=160"},"body":"That would make sense. It would be easy to add a space and forget to\nremove the hyphen.\n\n~ Nathan\n\nOn Tue, Nov 5, 2019 at 9:28 PM Jeff King wrote:\n>\n> On Wed, Nov 06, 2019 at 04:18:09AM +0000, Nathan Stocks via GitGitGadget wrote:\n>\n> > From: Nathan Stocks \n> >\n> > Fix two test descriptions which stated \"git -ls-files\" when the actual\n> > command being tested was \"git ls-files\".\n>\n> Thanks, this is obviously an improvement.\n>\n> I was curious if there was any backstory here. They came from 54e1abce90\n> (Add test case for ls-files --with-tree, 2007-10-03). That was around\n> the time of transitioning from \"git-ls-files\" to \"git ls-files\", so\n> maybe that caused the confusion. :)\n>\n> -Peff\n"},{"id":"385541","messageId":"20191106073731.GA86608@syl.local","threadId":"52199","inReplyTo":"5729dd380708da7b40805f75c5d475ff4c0b28c5.1573013889.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] t: fix typo in test descriptions","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2019-11-06T07:37:31Z","receivedAt":"2019-11-06T07:37:35Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi Nathan,\n\nOn Wed, Nov 06, 2019 at 04:18:09AM +0000, Nathan Stocks via GitGitGadget wrote:\n> From: Nathan Stocks \n>\n> Fix two test descriptions which stated \"git -ls-files\" when the actual\n> command being tested was \"git ls-files\".\n>\n> Signed-off-by: Nathan Stocks \n> ---\n> t/t3060-ls-files-with-tree.sh | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nNice find. I agree with your and Peff's conclusion about when these\nmight have been introduced, so that they have survived so long indicates\nthat this was an especially good find indeed.\n\nYour patch looks great to me.\n\n Reviewed-by: Taylor Blau \n\n> diff --git a/t/t3060-ls-files-with-tree.sh b/t/t3060-ls-files-with-tree.sh\n> index 44f378ce41..52ed665fcd 100755\n> --- a/t/t3060-ls-files-with-tree.sh\n> +++ b/t/t3060-ls-files-with-tree.sh\n> @@ -47,7 +47,7 @@ test_expect_success setup '\n> \tgit add .\n> '\n>\n> -test_expect_success 'git -ls-files --with-tree should succeed from subdir' '\n> +test_expect_success 'git ls-files --with-tree should succeed from subdir' '\n> \t# We have to run from a sub-directory to trigger prune_path\n> \t# Then we finally get to run our --with-tree test\n> \t(\n> @@ -57,7 +57,7 @@ test_expect_success 'git -ls-files --with-tree should succeed from subdir' '\n> '\n>\n> test_expect_success \\\n> - 'git -ls-files --with-tree should add entries from named tree.' \\\n> + 'git ls-files --with-tree should add entries from named tree.' \\\n> 'test_cmp expected output'\n>\n> test_done\n> --\n> gitgitgadget\n\nThanks,\nTaylor\n"},{"id":"385593","messageId":"CAFo48e7NeHo7465G_as5ZUjYg9pHh+rM7iZ0kDyRypV-JLJibQ@mail.gmail.com","threadId":"52199","inReplyTo":"20191106073731.GA86608@syl.local","subject":"Re: [PATCH 1/1] t: fix typo in test descriptions","fromName":"Nathan Stocks","fromEmail":"cleancut@github.com","sentAt":"2019-11-06T15:14:51Z","receivedAt":"2019-11-06T15:15:09Z","isPatch":true,"sender":{"key":"cleancut@github.com","avatar":"https://gravatar.com/avatar/6c05e16f2d9dba4fea3357b4e386db7cac53c984eece5c384e2569063c102cf8?d=mp&s=160"},"body":"On Wed, Nov 6, 2019 at 12:37 AM Taylor Blau wrote:\n> Nice find. I agree with your and Peff's conclusion about when these\n> might have been introduced, so that they have survived so long indicates\n> that this was an especially good find indeed.\n>\n> Your patch looks great to me.\n>\n> Reviewed-by: Taylor Blau \n\nGreat, thanks!\n\n~ Nathan\n"}]}