{"thread":{"id":"52197","subject":"[PATCH 0/3] Other doc fixes","startedAt":"2019-11-05T23:31:36Z","lastAt":"2019-11-07T05:41:55Z","messageCount":6,"participants":["Elijah Newren via GitGitGadget","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"385494","messageId":"pull.454.git.1572996692.gitgitgadget@gmail.com","threadId":"52197","inReplyTo":null,"subject":"[PATCH 0/3] Other doc fixes","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-11-05T23:31:29Z","receivedAt":"2019-11-05T23:31:36Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"In addition to the pile of spelling fixes in my other pull request, here are\nsome simple documentation fixes other than spelling errors (remove repeated\nword, '.' vs '->', missing hyphen).\n\nElijah Newren (3):\n git-filter-branch.txt: correct argument name typo\n hashmap: fix documentation misuses of -> versus .\n name-hash.c: remove duplicate word in comment\n\n Documentation/git-filter-branch.txt | 2 +-\n hashmap.h | 6 +++---\n name-hash.c | 2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)\n\n\nbase-commit: da72936f544fec5a335e66432610e4cef4430991\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-454%2Fnewren%2Fother-doc-fixes-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-454/newren/other-doc-fixes-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/454\n-- \ngitgitgadget\n"},{"id":"385495","messageId":"f7503d644c2baa9f5b8a71c998741f8232385508.1572996692.git.gitgitgadget@gmail.com","threadId":"52197","inReplyTo":"pull.454.git.1572996692.gitgitgadget@gmail.com","subject":"[PATCH 3/3] name-hash.c: remove duplicate word in comment","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-11-05T23:31:32Z","receivedAt":"2019-11-05T23:31:37Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"From: Elijah Newren \n\nSigned-off-by: Elijah Newren \n---\n name-hash.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/name-hash.c b/name-hash.c\nindex ceb1d7bd6f..4885bae5da 100644\n--- a/name-hash.c\n+++ b/name-hash.c\n@@ -218,7 +218,7 @@ static int lookup_lazy_params(struct index_state *istate)\n * However, the hashmap is going to put items into bucket\n * chains based on their hash values. Use that to create n\n * mutexes and lock on mutex[bucket(hash) % n]. This will\n- * decrease the collision rate by (hopefully) by a factor of n.\n+ * decrease the collision rate by (hopefully) a factor of n.\n */\n static void init_dir_mutex(void)\n {\n-- \ngitgitgadget\n"},{"id":"385496","messageId":"5bf1b5710f7f9bc6d217e5f7c1ee0d37a6f1617f.1572996692.git.gitgitgadget@gmail.com","threadId":"52197","inReplyTo":"pull.454.git.1572996692.gitgitgadget@gmail.com","subject":"[PATCH 1/3] git-filter-branch.txt: correct argument name typo","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-11-05T23:31:30Z","receivedAt":"2019-11-05T23:31:37Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"From: Elijah Newren \n\nSigned-off-by: Elijah Newren \n---\n Documentation/git-filter-branch.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt\nindex 5876598852..1ba4667b12 100644\n--- a/Documentation/git-filter-branch.txt\n+++ b/Documentation/git-filter-branch.txt\n@@ -649,7 +649,7 @@ create hoards of confusing empty commits\n commits from before the filtering operation are also pruned instead of\n just pruning commits that became empty due to filtering rules.\n \n-* If --prune empty is specified, sometimes empty commits are missed\n+* If --prune-empty is specified, sometimes empty commits are missed\n and left around anyway (a somewhat rare bug, but it happens...)\n \n * A minor issue, but users who have a goal to update all names and\n-- \ngitgitgadget\n\n"},{"id":"385497","messageId":"ebf6c7a8120438466e0a679d3066ac1d1525bf76.1572996692.git.gitgitgadget@gmail.com","threadId":"52197","inReplyTo":"pull.454.git.1572996692.gitgitgadget@gmail.com","subject":"[PATCH 2/3] hashmap: fix documentation misuses of -> versus .","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-11-05T23:31:31Z","receivedAt":"2019-11-05T23:31:40Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"From: Elijah Newren \n\nSigned-off-by: Elijah Newren \n---\n hashmap.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/hashmap.h b/hashmap.h\nindex bd2701549f..6036069c23 100644\n--- a/hashmap.h\n+++ b/hashmap.h\n@@ -59,7 +59,7 @@\n *\n * if (!strcmp(\"print_all_by_key\", action)) {\n * struct long2string k, *e;\n- * hashmap_entry_init(&k->ent, memhash(&key, sizeof(long)));\n+ * hashmap_entry_init(&k.ent, memhash(&key, sizeof(long)));\n * k.key = key;\n *\n * flags &= ~COMPARE_VALUE;\n@@ -87,12 +87,12 @@\n *\n * if (!strcmp(\"has_exact_match_no_heap_alloc\", action)) {\n * struct long2string k;\n- * hashmap_entry_init(&k->ent, memhash(&key, sizeof(long)));\n+ * hashmap_entry_init(&k.ent, memhash(&key, sizeof(long)));\n * k.key = key;\n *\n * flags |= COMPARE_VALUE;\n * printf(\"%sfound\\n\",\n- * hashmap_get(&map, &k->ent, value) ? \"\" : \"not \");\n+ * hashmap_get(&map, &k.ent, value) ? \"\" : \"not \");\n * }\n *\n * if (!strcmp(\"end\", action)) {\n-- \ngitgitgadget\n\n"},{"id":"385525","messageId":"20191106040648.GC4307@sigill.intra.peff.net","threadId":"52197","inReplyTo":"pull.454.git.1572996692.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/3] Other doc fixes","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-11-06T04:06:48Z","receivedAt":"2019-11-06T04:06:50Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Nov 05, 2019 at 11:31:29PM +0000, Elijah Newren via GitGitGadget wrote:\n\n> In addition to the pile of spelling fixes in my other pull request, here are\n> some simple documentation fixes other than spelling errors (remove repeated\n> word, '.' vs '->', missing hyphen).\n\nThanks, these all look trivially correct to me.\n\n-Peff\n"},{"id":"385658","messageId":"xmqqwoccqm3l.fsf@gitster-ct.c.googlers.com","threadId":"52197","inReplyTo":"f7503d644c2baa9f5b8a71c998741f8232385508.1572996692.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 3/3] name-hash.c: remove duplicate word in comment","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-11-07T05:41:50Z","receivedAt":"2019-11-07T05:41:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Elijah Newren via GitGitGadget\" writes:\n\n> From: Elijah Newren \n>\n> Signed-off-by: Elijah Newren \n> ---\n> name-hash.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/name-hash.c b/name-hash.c\n> index ceb1d7bd6f..4885bae5da 100644\n> --- a/name-hash.c\n> +++ b/name-hash.c\n> @@ -218,7 +218,7 @@ static int lookup_lazy_params(struct index_state *istate)\n> * However, the hashmap is going to put items into bucket\n> * chains based on their hash values. Use that to create n\n> * mutexes and lock on mutex[bucket(hash) % n]. This will\n> - * decrease the collision rate by (hopefully) by a factor of n.\n> + * decrease the collision rate by (hopefully) a factor of n.\n> */\n> static void init_dir_mutex(void)\n> {\n\nThanks. Will queue all 3.\n"}]}