{"thread":{"id":"52121","subject":"[PATCH] builtin/commit-graph.c: remove subcommand-less usage string","startedAt":"2019-10-25T16:49:17Z","lastAt":"2019-10-25T17:35:41Z","messageCount":2,"participants":["SZEDER Gábor","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"384875","messageId":"20191025164909.354-1-szeder.dev@gmail.com","threadId":"52121","inReplyTo":null,"subject":"[PATCH] builtin/commit-graph.c: remove subcommand-less usage string","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-10-25T16:49:09Z","receivedAt":"2019-10-25T16:49:17Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"The first line in 'git commit-graph's usage string indicates that this\ncommand can be invoked without specifying a subcommand.  However, this\nis not the case:\n\n  $ git commit-graph\n  usage: git commit-graph [--object-dir <objdir>]\n     or: git commit-graph read [--object-dir <objdir>]\n  [...]\n  $ echo $?\n  129\n\nRemove this line from the usage string.\n\nThe synopsis in the manpage doesn't contain this line.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\n---\n builtin/commit-graph.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin/commit-graph.c b/builtin/commit-graph.c\nindex c6219ebe11..4d9b9c862f 100644\n--- a/builtin/commit-graph.c\n+++ b/builtin/commit-graph.c\n@@ -8,7 +8,6 @@\n #include \"object-store.h\"\n \n static char const * const builtin_commit_graph_usage[] = {\n-\tN_(\"git commit-graph [--object-dir <objdir>]\"),\n \tN_(\"git commit-graph read [--object-dir <objdir>]\"),\n \tN_(\"git commit-graph verify [--object-dir <objdir>] [--shallow] [--[no-]progress]\"),\n \tN_(\"git commit-graph write [--object-dir <objdir>] [--append|--split] [--reachable|--stdin-packs|--stdin-commits] [--[no-]progress] <split options>\"),\n-- \n2.24.0.rc1.539.g061db24550\n\n"},{"id":"384877","messageId":"0ba48f8e-3869-ff08-b46d-53feb7675d2b@gmail.com","threadId":"52121","inReplyTo":"20191025164909.354-1-szeder.dev@gmail.com","subject":"Re: [PATCH] builtin/commit-graph.c: remove subcommand-less usage string","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2019-10-25T17:35:31Z","receivedAt":"2019-10-25T17:35:41Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 10/25/2019 12:49 PM, SZEDER Gábor wrote:\n> The first line in 'git commit-graph's usage string indicates that this\n> command can be invoked without specifying a subcommand.  However, this\n> is not the case:\n> \n>   $ git commit-graph\n>   usage: git commit-graph [--object-dir <objdir>]\n>      or: git commit-graph read [--object-dir <objdir>]\n>   [...]\n>   $ echo $?\n>   129\n> \n> Remove this line from the usage string.\n> \n> The synopsis in the manpage doesn't contain this line.\n> \n> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>\n> ---\n>  builtin/commit-graph.c | 1 -\n>  1 file changed, 1 deletion(-)\n> \n> diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c\n> index c6219ebe11..4d9b9c862f 100644\n> --- a/builtin/commit-graph.c\n> +++ b/builtin/commit-graph.c\n> @@ -8,7 +8,6 @@\n>  #include \"object-store.h\"\n>  \n>  static char const * const builtin_commit_graph_usage[] = {\n> -\tN_(\"git commit-graph [--object-dir <objdir>]\"),\n>  \tN_(\"git commit-graph read [--object-dir <objdir>]\"),\n>  \tN_(\"git commit-graph verify [--object-dir <objdir>] [--shallow] [--[no-]progress]\"),\n>  \tN_(\"git commit-graph write [--object-dir <objdir>] [--append|--split] [--reachable|--stdin-packs|--stdin-commits] [--[no-]progress] <split options>\"),\n\nGood catch! Thanks for cleaning this up.\n\n-Stolee\n\n"}]}