{"thread":{"id":"52078","subject":"[Outreachy] First contribution","startedAt":"2019-10-21T10:39:30Z","lastAt":"2019-10-22T13:42:36Z","messageCount":3,"participants":["Miriam R.","Emily Shaffer"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"384499","messageId":"CAN7CjDCacSKzN8fXgUe4ejNqM+AAe1o7NaDaFgM5WcYYV0bQ9g@mail.gmail.com","threadId":"52078","inReplyTo":null,"subject":"[Outreachy] First contribution","fromName":"Miriam R.","fromEmail":"mirucam@gmail.com","sentAt":"2019-10-21T10:39:16Z","receivedAt":"2019-10-21T10:39:30Z","isPatch":false,"sender":{"key":"mirucam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/56339109?v=4"},"body":"Dear Git developers,\nI’m an Outreachy applicant, I would like to make my contribution to\napply to this Outreachy internship period.\n\nI have found this issue tagged as open and goodfirstissue:\nhttps://github.com/gitgitgadget/git/issues/230\n\nBut there is a PR from 4 months ago:\nhttps://github.com/gitgitgadget/git/pull/271  and I don't know how to\nfind out if a patch including that change already exists or if it\nmakes sense to do it.\n\nIn case this issue is not suitable for my first contribution,  I have\nalso found this:\nhttps://github.com/gitgitgadget/git/issues/379\n\nIn case any of them aren’t ok for you, I’ll try to find another.\n\nThank you.\n\nKind regards,\nMiriam.\n"},{"id":"384538","messageId":"20191021183519.GA139951@google.com","threadId":"52078","inReplyTo":"CAN7CjDCacSKzN8fXgUe4ejNqM+AAe1o7NaDaFgM5WcYYV0bQ9g@mail.gmail.com","subject":"Re: [Outreachy] First contribution","fromName":"Emily Shaffer","fromEmail":"emilyshaffer@google.com","sentAt":"2019-10-21T18:35:19Z","receivedAt":"2019-10-21T18:35:27Z","isPatch":false,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"On Mon, Oct 21, 2019 at 12:39:16PM +0200, Miriam R. wrote:\n> Dear Git developers,\n> I’m an Outreachy applicant, I would like to make my contribution to\n> apply to this Outreachy internship period.\n\nWelcome, Miriam! Good to hear from you.\n\n> \n> I have found this issue tagged as open and goodfirstissue:\n> https://github.com/gitgitgadget/git/issues/230\n> \n> But there is a PR from 4 months ago:\n> https://github.com/gitgitgadget/git/pull/271  and I don't know how to\n> find out if a patch including that change already exists or if it\n> makes sense to do it.\n\nGitGitGadget exists to repackage PRs (which Git project doesn't use)\ninto emailed patches (which Git project does use) when the author writes\n/submit on the PR comment chain. In that PR I see Johannes asking for a\n/submit, but no submit; next I would check if a patch with the same\ntitle came through in the mailing list by searching on the\npublic-inbox.org mirror:\n\nhttps://public-inbox.org/git/?q=is_directory+dir_exists\n\nLooks like, no, a patch with those hotwords wasn't mailed. Finally, I\nwould check the project to see if it's still an issue:\n\n  $ cd my-git-dir/\n  $ git grep is_directory\n\nI still see 30 instances of is_directory in the codebase, so looks like\nwe haven't made this change. :)\n\n> \n> In case this issue is not suitable for my first contribution,  I have\n> also found this:\n> https://github.com/gitgitgadget/git/issues/379\n\nThis is also a fine change if you want to make it.\n\nGood luck, and remember it's fine to ask the mentor for the project you\nultimately want to help on for help, code review in advance, etc.\n\n - Emily\n"},{"id":"384602","messageId":"CAN7CjDBZTBQKbDB=rCojEzqvwKZf8pfGq4ZwEmRV43FVWS8e=g@mail.gmail.com","threadId":"52078","inReplyTo":"20191021183519.GA139951@google.com","subject":"Re: [Outreachy] First contribution","fromName":"Miriam R.","fromEmail":"mirucam@gmail.com","sentAt":"2019-10-22T13:42:22Z","receivedAt":"2019-10-22T13:42:36Z","isPatch":false,"sender":{"key":"mirucam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/56339109?v=4"},"body":"El lun., 21 oct. 2019 a las 20:35, Emily Shaffer\n(<emilyshaffer@google.com>) escribió:\n>\n> On Mon, Oct 21, 2019 at 12:39:16PM +0200, Miriam R. wrote:\n> > Dear Git developers,\n> > I’m an Outreachy applicant, I would like to make my contribution to\n> > apply to this Outreachy internship period.\n>\n> Welcome, Miriam! Good to hear from you.\n>\n> >\n> > I have found this issue tagged as open and goodfirstissue:\n> > https://github.com/gitgitgadget/git/issues/230\n> >\n> > But there is a PR from 4 months ago:\n> > https://github.com/gitgitgadget/git/pull/271  and I don't know how to\n> > find out if a patch including that change already exists or if it\n> > makes sense to do it.\n>\n> GitGitGadget exists to repackage PRs (which Git project doesn't use)\n> into emailed patches (which Git project does use) when the author writes\n> /submit on the PR comment chain. In that PR I see Johannes asking for a\n> /submit, but no submit; next I would check if a patch with the same\n> title came through in the mailing list by searching on the\n> public-inbox.org mirror:\n>\n> https://public-inbox.org/git/?q=is_directory+dir_exists\n>\n> Looks like, no, a patch with those hotwords wasn't mailed. Finally, I\n> would check the project to see if it's still an issue:\n>\n>   $ cd my-git-dir/\n>   $ git grep is_directory\n>\n> I still see 30 instances of is_directory in the codebase, so looks like\n> we haven't made this change. :)\n>\n\nThank you Emily!! Then I'll do this issue #230 :)\n\n> >\n> > In case this issue is not suitable for my first contribution,  I have\n> > also found this:\n> > https://github.com/gitgitgadget/git/issues/379\n>\n> This is also a fine change if you want to make it.\n>\n> Good luck, and remember it's fine to ask the mentor for the project you\n> ultimately want to help on for help, code review in advance, etc.\n\nThank you for the advice!, I'm already in touch with Christian Couder.\n\nBest,\nMiriam\n\n>\n>  - Emily\n"}]}