{"thread":{"id":"52009","subject":"[PATCH 0/1] t1308-config-set: fix a test that has a typo","startedAt":"2019-10-10T12:35:36Z","lastAt":"2019-10-11T05:35:59Z","messageCount":4,"participants":["Johannes Schindelin via GitGitGadget","Tanay Abhra via GitGitGadget","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"383799","messageId":"pull.387.git.gitgitgadget@gmail.com","threadId":"52009","inReplyTo":null,"subject":"[PATCH 0/1] t1308-config-set: fix a test that has a typo","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-10T12:35:33Z","receivedAt":"2019-10-10T12:35:36Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"I am currently trying to whittle down the number of open PRs at \nhttps://github.com/git/git, and this is one of the patches I deem valuable\nenough (and complete enough) to put through to the Git mailing list even\nwhen the original contributor has gone silent.\n\nTanay Abhra (1):\n t1308-config-set: fix a test that has a typo\n\n t/t1308-config-set.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\n\nbase-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-387%2Fdscho%2Fconfig-set-test-fix-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-387/dscho/config-set-test-fix-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/387\n-- \ngitgitgadget\n"},{"id":"383800","messageId":"7b88e36723e3e6d51118d62211f487b497c532cc.1570710932.git.gitgitgadget@gmail.com","threadId":"52009","inReplyTo":"pull.387.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] t1308-config-set: fix a test that has a typo","fromName":"Tanay Abhra via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-10T12:35:34Z","receivedAt":"2019-10-10T12:35:40Z","isPatch":true,"sender":{"key":"tanayabh@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2097229?v=4"},"body":"From: Tanay Abhra \n\nChange test 'find value_list for a key from a configset' to redirect the\nresult to 'expect' instead of 'except' which was a typo.\n\nWith this change, the test case actually fails because it uses\n`configset_get_value`. Clearly, this was intended to be\n`configset_get_value_multi` since the test expects a list of values\ninstead of a single value, so let's fix that, too.\n\nOriginally contributed as https://github.com/git/git/pull/451.\n\nSigned-off-by: Tanay Abhra \nSigned-off-by: Johannes Schindelin \n---\n t/t1308-config-set.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh\nindex d0a2727b85..7b4e1a63eb 100755\n--- a/t/t1308-config-set.sh\n+++ b/t/t1308-config-set.sh\n@@ -166,14 +166,14 @@ test_expect_success 'find value with highest priority from a configset' '\n '\n \n test_expect_success 'find value_list for a key from a configset' '\n-\tcat >except <<-\\EOF &&\n+\tcat >expect <<-\\EOF &&\n+\tlama\n+\tball\n \tsam\n \tbat\n \thask\n-\tlama\n-\tball\n \tEOF\n-\ttest-tool config configset_get_value case.baz config2 .git/config >actual &&\n+\ttest-tool config configset_get_value_multi case.baz config2 .git/config >actual &&\n \ttest_cmp expect actual\n '\n \n-- \ngitgitgadget\n"},{"id":"383837","messageId":"nycvar.QRO.7.76.6.1910102247570.46@tvgsbejvaqbjf.bet","threadId":"52009","inReplyTo":"7b88e36723e3e6d51118d62211f487b497c532cc.1570710932.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] t1308-config-set: fix a test that has a typo","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-10-10T20:48:52Z","receivedAt":"2019-10-10T20:49:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Team,\n\nOn Thu, 10 Oct 2019, Tanay Abhra via GitGitGadget wrote:\n\n> diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh\n> index d0a2727b85..7b4e1a63eb 100755\n> --- a/t/t1308-config-set.sh\n> +++ b/t/t1308-config-set.sh\n> @@ -166,14 +166,14 @@ test_expect_success 'find value with highest priority from a configset' '\n> '\n>\n> test_expect_success 'find value_list for a key from a configset' '\n> -\tcat >except <<-\\EOF &&\n> +\tcat >expect <<-\\EOF &&\n\nI should note that I looked through all of the hits of `git grep -w\nexcept -- t/` and did not find any other typo.\n\nThanks,\nJohannes\n\n> +\tlama\n> +\tball\n> \tsam\n> \tbat\n> \thask\n> -\tlama\n> -\tball\n> \tEOF\n> -\ttest-tool config configset_get_value case.baz config2 .git/config >actual &&\n> +\ttest-tool config configset_get_value_multi case.baz config2 .git/config >actual &&\n> \ttest_cmp expect actual\n> '\n>\n> --\n> gitgitgadget\n>\n"},{"id":"383869","messageId":"xmqqv9svhmix.fsf@gitster-ct.c.googlers.com","threadId":"52009","inReplyTo":"nycvar.QRO.7.76.6.1910102247570.46@tvgsbejvaqbjf.bet","subject":"Re: [PATCH 1/1] t1308-config-set: fix a test that has a typo","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-10-11T05:35:50Z","receivedAt":"2019-10-11T05:35:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> I should note that I looked through all of the hits of `git grep -w\n> except -- t/` and did not find any other typo.\n\nThanks.\n"}]}